Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](planner) fix bug of select stmt toSql #37274

Merged
merged 2 commits into from
Jul 5, 2024
Merged

[fix](planner) fix bug of select stmt toSql #37274

merged 2 commits into from
Jul 5, 2024

Conversation

feiniaofeiafei
Copy link
Contributor

@feiniaofeiafei feiniaofeiafei commented Jul 4, 2024 •
edited
Loading

PR #33726 does not correctly fix the create view problem of the legacy optimizer caused by the toSql bug (* except syntax). The results of the regression test cases are also problematic. This pr fix the problem.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@feiniaofeiafei
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40236 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9c122dcc0a5b812b7a3a26ec3988ba6ea0a61fe1, data reload: false

------ Round 1 ----------------------------------
q1	17609	5040	4299	4299
q2	2014	189	190	189
q3	10447	1209	1179	1179
q4	10181	767	747	747
q5	7484	2618	2650	2618
q6	221	139	136	136
q7	962	595	599	595
q8	9224	2103	2097	2097
q9	9057	6511	6473	6473
q10	8984	3792	3760	3760
q11	455	242	249	242
q12	536	253	248	248
q13	19004	2982	2963	2963
q14	281	228	233	228
q15	536	486	486	486
q16	514	388	385	385
q17	973	699	668	668
q18	8177	7497	7446	7446
q19	8009	1574	1620	1574
q20	665	332	328	328
q21	4944	3234	3251	3234
q22	399	341	343	341
Total cold run time: 120676 ms
Total hot run time: 40236 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4438	4272	4227	4227
q2	384	277	288	277
q3	3235	2967	2955	2955
q4	1984	1663	1755	1663
q5	5525	5440	5457	5440
q6	221	145	139	139
q7	2258	1829	1817	1817
q8	3355	3401	3439	3401
q9	8666	8853	8811	8811
q10	4087	3715	3913	3715
q11	581	494	494	494
q12	820	604	642	604
q13	16383	3166	3224	3166
q14	335	285	289	285
q15	538	480	479	479
q16	507	436	415	415
q17	1819	1543	1536	1536
q18	8124	8040	7773	7773
q19	1801	1739	1718	1718
q20	2211	1866	1866	1866
q21	5165	4682	4886	4682
q22	648	589	539	539
Total cold run time: 73085 ms
Total hot run time: 56002 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 171023 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9c122dcc0a5b812b7a3a26ec3988ba6ea0a61fe1, data reload: false

query1	924	391	370	370
query2	6412	2390	2392	2390
query3	6638	203	209	203
query4	18809	17584	17260	17260
query5	3648	480	508	480
query6	267	177	189	177
query7	4601	295	294	294
query8	317	284	274	274
query9	8463	2395	2374	2374
query10	547	300	282	282
query11	10445	9969	10092	9969
query12	111	83	82	82
query13	1654	366	394	366
query14	8390	7703	7630	7630
query15	235	184	186	184
query16	7785	304	295	295
query17	1707	559	512	512
query18	1954	270	265	265
query19	186	157	145	145
query20	86	80	83	80
query21	201	132	123	123
query22	4269	4082	4034	4034
query23	34148	33794	33886	33794
query24	10778	2884	2789	2789
query25	597	376	393	376
query26	715	159	153	153
query27	2290	330	325	325
query28	6119	2152	2149	2149
query29	896	649	659	649
query30	256	158	153	153
query31	988	748	770	748
query32	98	55	57	55
query33	716	296	283	283
query34	977	465	485	465
query35	758	647	629	629
query36	1102	956	1006	956
query37	145	77	77	77
query38	2923	2893	2843	2843
query39	916	830	806	806
query40	214	133	126	126
query41	53	53	51	51
query42	109	98	100	98
query43	610	564	539	539
query44	1182	713	727	713
query45	195	154	163	154
query46	1094	729	714	714
query47	1856	1750	1758	1750
query48	380	295	290	290
query49	823	406	412	406
query50	764	380	377	377
query51	6962	6848	6861	6848
query52	101	94	91	91
query53	363	286	285	285
query54	899	438	440	438
query55	72	70	72	70
query56	280	259	273	259
query57	1135	1040	1053	1040
query58	259	241	237	237
query59	3366	3330	3065	3065
query60	310	279	277	277
query61	95	92	94	92
query62	601	443	449	443
query63	327	290	285	285
query64	8772	2373	1741	1741
query65	3150	3127	3085	3085
query66	740	325	327	325
query67	15569	15202	15075	15075
query68	4519	529	516	516
query69	630	384	318	318
query70	1172	1134	1107	1107
query71	375	273	276	273
query72	7277	5605	2766	2766
query73	737	320	321	320
query74	5891	5515	5565	5515
query75	3380	2658	2707	2658
query76	2626	952	953	952
query77	594	308	302	302
query78	9600	8985	8779	8779
query79	3050	507	504	504
query80	2215	517	462	462
query81	550	217	220	217
query82	1119	108	108	108
query83	295	165	171	165
query84	269	85	87	85
query85	1421	274	279	274
query86	464	308	297	297
query87	3356	3098	3090	3090
query88	3925	2343	2343	2343
query89	476	394	381	381
query90	1799	179	183	179
query91	130	100	98	98
query92	57	48	47	47
query93	2727	498	497	497
query94	1175	207	212	207
query95	400	314	312	312
query96	595	262	262	262
query97	3260	3035	3026	3026
query98	214	196	193	193
query99	1188	863	857	857
Total cold run time: 267838 ms
Total hot run time: 171023 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.3 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9c122dcc0a5b812b7a3a26ec3988ba6ea0a61fe1, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.03
query3	0.22	0.05	0.05
query4	1.68	0.11	0.11
query5	0.52	0.50	0.50
query6	1.14	0.71	0.72
query7	0.02	0.01	0.01
query8	0.06	0.05	0.04
query9	0.56	0.48	0.48
query10	0.56	0.55	0.55
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.58	0.58	0.58
query14	0.77	0.79	0.77
query15	0.84	0.81	0.81
query16	0.36	0.37	0.36
query17	0.95	0.97	0.98
query18	0.21	0.29	0.23
query19	1.79	1.76	1.75
query20	0.02	0.01	0.01
query21	15.38	0.77	0.66
query22	4.45	7.11	1.79
query23	18.27	1.33	1.19
query24	2.17	0.22	0.22
query25	0.15	0.10	0.09
query26	0.26	0.18	0.17
query27	0.09	0.07	0.08
query28	13.18	1.01	0.98
query29	12.64	3.26	3.27
query30	0.25	0.06	0.05
query31	2.86	0.41	0.38
query32	3.26	0.48	0.46
query33	2.92	2.86	2.99
query34	17.10	4.40	4.43
query35	4.55	4.49	4.46
query36	0.65	0.47	0.47
query37	0.18	0.15	0.14
query38	0.14	0.14	0.14
query39	0.04	0.03	0.04
query40	0.17	0.14	0.13
query41	0.08	0.04	0.05
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.6 s
Total hot run time: 30.3 s

@feiniaofeiafei
Copy link
Contributor Author

run p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 40355ab into apache:master Jul 5, 2024
28 of 31 checks passed
@feiniaofeiafei feiniaofeiafei mentioned this pull request Jul 5, 2024
Merged
feiniaofeiafei added a commit to feiniaofeiafei/doris that referenced this pull request Jul 5, 2024
@feiniaofeiafei
[fix](planner) fix bug of select stmt toSql (apache#37274)
7d61d93 
PR apache#33726 does not correctly fix the create view problem of the legacy
optimizer caused by the toSql bug (* except syntax). The results of the
regression test cases are also problematic. This pr fix the problem.

---------

Co-authored-by: feiniaofeiafei <moailing@selectdb.com>
feiniaofeiafei added a commit to feiniaofeiafei/doris that referenced this pull request Jul 5, 2024
@feiniaofeiafei
[fix](planner) fix bug of select stmt toSql (apache#37274)
b34a026
@feiniaofeiafei feiniaofeiafei mentioned this pull request Jul 5, 2024
Merged
morrySnow pushed a commit that referenced this pull request Jul 8, 2024
@feiniaofeiafei
[fix](planner) fix bug of select stmt toSql (#37274) (#37346)
42a52d8 
cherry-pick from master #37274
morrySnow pushed a commit that referenced this pull request Jul 9, 2024
@feiniaofeiafei
[fix](planner) fix bug of select stmt toSql(#37274) (#37344)
8ef8325 
cherry-pick from master #37274
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
@feiniaofeiafei @dataroaring
[fix](planner) fix bug of select stmt toSql (#37274)
25b179b 
PR #33726 does not correctly fix the create view problem of the legacy
optimizer caused by the toSql bug (* except syntax). The results of the
regression test cases are also problematic. This pr fix the problem.

---------

Co-authored-by: feiniaofeiafei <moailing@selectdb.com>
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@feiniaofeiafei
[fix](planner) fix bug of select stmt toSql (apache#37274) (apache#37346
842783b 
)

cherry-pick from master apache#37274
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.13-merged dev/2.1.5-merged dev/3.0.1-merged p0_w reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@feiniaofeiafei @doris-robot @starocean999 @morrySnow @dataroaring