Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix](Timezone)The time zone should not be fixed to UTC+8. #37294

Merged
merged 1 commit into from
Jul 5, 2024
Merged

[Fix](Timezone)The time zone should not be fixed to UTC+8. #37294

merged 1 commit into from
Jul 5, 2024

Conversation

CalvinKirs
Copy link
Member

@CalvinKirs CalvinKirs commented Jul 4, 2024 •
edited
Loading

Proposed changes

It is generally more reasonable to use the system's default time zone rather than binding the default time zone to UTC+8. This approach ensures that the application will behave correctly in different environments and regions.

For countries that observe DST, this might require extra attention.

@CalvinKirs
[Fix](Timezone)The time zone should not be fixed to UTC+8.
78378e7 
It is generally more reasonable to use the system's default time zone rather than binding the default time zone to UTC+8. This approach ensures that the application will behave correctly in different environments and regions.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@CalvinKirs
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40537 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 78378e7c7fc121135421a11d574719e338eee079, data reload: false

------ Round 1 ----------------------------------
q1	18011	4574	4443	4443
q2	2683	195	192	192
q3	10956	1236	1141	1141
q4	10234	887	892	887
q5	7668	2753	2711	2711
q6	230	146	145	145
q7	980	623	635	623
q8	9367	2119	2120	2119
q9	8826	6496	6478	6478
q10	8893	3687	3697	3687
q11	458	238	247	238
q12	467	257	238	238
q13	17766	2995	2987	2987
q14	277	222	229	222
q15	526	493	494	493
q16	534	387	374	374
q17	973	700	797	700
q18	8036	7596	7371	7371
q19	5943	1526	1534	1526
q20	651	341	333	333
q21	5176	3287	4019	3287
q22	405	342	344	342
Total cold run time: 119060 ms
Total hot run time: 40537 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4400	4266	4291	4266
q2	382	266	270	266
q3	3000	2684	2701	2684
q4	1919	1598	1615	1598
q5	5224	5301	5299	5299
q6	217	132	136	132
q7	2102	1731	1732	1731
q8	3218	3386	3322	3322
q9	8371	8381	8383	8381
q10	3911	3647	3664	3647
q11	585	490	481	481
q12	802	624	596	596
q13	16345	3005	2990	2990
q14	281	284	263	263
q15	517	483	487	483
q16	466	442	413	413
q17	1772	1517	1472	1472
q18	7621	7469	7543	7469
q19	1751	1668	1683	1668
q20	1991	1804	1760	1760
q21	4895	4796	4795	4795
q22	625	542	590	542
Total cold run time: 70395 ms
Total hot run time: 54258 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172810 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 78378e7c7fc121135421a11d574719e338eee079, data reload: false

query1	913	381	374	374
query2	6456	2452	2491	2452
query3	6656	203	215	203
query4	19123	17326	17325	17325
query5	4176	497	512	497
query6	283	187	174	174
query7	4603	297	299	297
query8	336	304	293	293
query9	8460	2389	2406	2389
query10	635	313	303	303
query11	10595	10020	9977	9977
query12	139	91	90	90
query13	1648	384	383	383
query14	8850	7721	7189	7189
query15	231	188	191	188
query16	7744	319	324	319
query17	1784	579	544	544
query18	1951	287	280	280
query19	205	158	157	157
query20	95	84	85	84
query21	215	139	128	128
query22	4334	4122	3992	3992
query23	33663	33092	33013	33013
query24	11795	2859	2821	2821
query25	710	396	401	396
query26	1826	160	156	156
query27	3033	319	318	318
query28	7617	2086	2086	2086
query29	1176	655	624	624
query30	272	152	148	148
query31	985	763	740	740
query32	100	59	59	59
query33	790	314	313	313
query34	943	476	484	476
query35	773	640	627	627
query36	1076	984	912	912
query37	274	79	82	79
query38	2856	2764	2776	2764
query39	870	779	798	779
query40	289	133	132	132
query41	58	55	60	55
query42	116	99	105	99
query43	631	582	564	564
query44	1235	737	730	730
query45	199	166	165	165
query46	1078	729	720	720
query47	1887	1815	1773	1773
query48	381	305	311	305
query49	1219	447	436	436
query50	777	398	413	398
query51	6917	6708	6718	6708
query52	107	97	94	94
query53	371	316	300	300
query54	1005	459	459	459
query55	77	78	77	77
query56	312	291	301	291
query57	1178	1038	1068	1038
query58	278	272	394	272
query59	3557	3388	3376	3376
query60	329	304	289	289
query61	101	95	102	95
query62	661	457	437	437
query63	326	304	301	301
query64	9864	2256	1770	1770
query65	3174	3095	3114	3095
query66	1371	338	356	338
query67	15738	15158	14822	14822
query68	8777	551	556	551
query69	740	450	350	350
query70	1433	1158	1121	1121
query71	541	282	281	281
query72	8698	5541	5237	5237
query73	2194	326	326	326
query74	5854	5493	5523	5493
query75	5456	2674	2654	2654
query76	5461	998	982	982
query77	765	316	310	310
query78	9670	9750	8777	8777
query79	8799	507	510	507
query80	1969	483	480	480
query81	546	220	219	219
query82	266	103	104	103
query83	348	165	166	165
query84	277	84	83	83
query85	1005	318	277	277
query86	358	323	301	301
query87	3287	3076	3101	3076
query88	4337	2376	2373	2373
query89	516	399	384	384
query90	2161	197	193	193
query91	130	109	99	99
query92	63	50	49	49
query93	5629	509	502	502
query94	1471	213	209	209
query95	410	323	365	323
query96	610	262	275	262
query97	3171	3041	2996	2996
query98	219	201	192	192
query99	1133	847	856	847
Total cold run time: 297721 ms
Total hot run time: 172810 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.3 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 78378e7c7fc121135421a11d574719e338eee079, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.69	0.06	0.06
query5	0.50	0.49	0.50
query6	1.13	0.72	0.72
query7	0.02	0.02	0.01
query8	0.05	0.05	0.04
query9	0.55	0.49	0.50
query10	0.53	0.54	0.56
query11	0.16	0.11	0.11
query12	0.15	0.12	0.13
query13	0.59	0.59	0.58
query14	0.76	0.77	0.80
query15	0.83	0.80	0.82
query16	0.36	0.37	0.38
query17	0.94	0.96	0.95
query18	0.23	0.22	0.27
query19	1.74	1.65	1.69
query20	0.02	0.01	0.01
query21	15.40	0.74	0.65
query22	4.32	7.66	1.73
query23	18.26	1.31	1.27
query24	2.16	0.23	0.23
query25	0.15	0.09	0.08
query26	0.29	0.21	0.22
query27	0.45	0.23	0.23
query28	13.21	1.02	0.99
query29	12.64	3.30	3.27
query30	0.25	0.06	0.05
query31	2.87	0.40	0.38
query32	3.28	0.48	0.47
query33	2.88	2.92	2.92
query34	17.10	4.32	4.34
query35	4.44	4.41	4.46
query36	0.65	0.47	0.47
query37	0.17	0.15	0.16
query38	0.15	0.14	0.14
query39	0.04	0.03	0.03
query40	0.15	0.12	0.13
query41	0.09	0.05	0.04
query42	0.05	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.64 s
Total hot run time: 30.3 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

PR approved by anyone and no changes requested.

JNSimba
JNSimba approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@JNSimba JNSimba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CalvinKirs CalvinKirs merged commit fa389f4 into apache:master Jul 5, 2024
28 of 31 checks passed
@CalvinKirs CalvinKirs deleted the master-timezone-fix branch July 5, 2024 06:12
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
@CalvinKirs @dataroaring
[Fix](Timezone)The time zone should not be fixed to UTC+8. (#37294)
c58929a 
## Proposed changes


It is generally more reasonable to use the system's default time zone
rather than binding the default time zone to UTC+8. This approach
ensures that the application will behave correctly in different
environments and regions.

**For countries that observe DST, this might require extra attention.**
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow approved these changes

@JNSimba JNSimba JNSimba approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.x dev/3.0.1-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CalvinKirs @doris-robot @JNSimba @morrySnow @dataroaring