[fix](mtmv) Fix rewrite wrongly when sync and async materialized view name is same #37311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 39894 ms |
morrySnow
reviewed
Jul 4, 2024
| @@ -72,7 +72,8 @@ Plan doGenerateScanPlan(CascadesContext cascadesContext) { | |||
| @Override | |||
| List<String> getMaterializationQualifier() { | |||
| return ImmutableList.of(olapTable.getDatabase().getCatalog().getName(), | |||
| ClusterNamespace.getNameFromFullName(olapTable.getDatabase().getFullName()), indexName); | |||
| ClusterNamespace.getNameFromFullName(olapTable.getDatabase().getFullName()), | |||
| olapTable.getName(), indexName); | |||
TPC-DS: Total hot run time: 168493 ms |
ClickBench: Total hot run time: 31.3 s |
|
run buildall |
TPC-H: Total hot run time: 39844 ms |
TPC-DS: Total hot run time: 171834 ms |
morrySnow
approved these changes
Jul 5, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
ClickBench: Total hot run time: 31.24 s |
starocean999
approved these changes
Jul 8, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
… name is same (#37311) ## Proposed changes This is brought by #33699 `AbstractMaterializedViewRule#isMaterializationValid` check would fail when sync and async materialized view name is same, because the Materialization valid check result is cached by name。this will cause the async materialized view check fail wrongly. This fix this by make sync materialized view name unique in every place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is brought by #33699
AbstractMaterializedViewRule#isMaterializationValidcheck would fail when sync and async materialized view name is same, because the Materialization valid check result is cached by name。this will cause the async materialized view check fail wrongly. This fix this by make sync materialized view name unique in every place.