Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore](backup) Fix the db name of the restored view #37412

Merged
merged 3 commits into from
Jul 17, 2024
Merged

[chore](backup) Fix the db name of the restored view #37412

merged 3 commits into from
Jul 17, 2024

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Jul 8, 2024

Previously, during restore, the database name in the CREATE VIEW statement was not modified, causing the restored view to be unviewable with the SHOW VIEW command. This PR retains the original cluster's database name in the BackupMeta and manually replaces it with the new cluster's database name in the CREATE VIEW statement during restore.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@w41ter
Copy link
Contributor Author

w41ter commented Jul 8, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39908 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8097fd4d775a4707d79f9a71fb946b59747cdf6b, data reload: false

------ Round 1 ----------------------------------
q1	17630	4266	4238	4238
q2	2012	193	184	184
q3	10464	1184	1151	1151
q4	10193	821	800	800
q5	7584	2634	2650	2634
q6	222	140	142	140
q7	944	589	602	589
q8	9227	2051	2086	2051
q9	9055	6463	6475	6463
q10	8955	3707	3620	3620
q11	459	242	239	239
q12	418	238	232	232
q13	17770	2986	2997	2986
q14	265	226	242	226
q15	529	487	491	487
q16	485	378	367	367
q17	957	653	625	625
q18	7929	7503	7451	7451
q19	4212	1487	1530	1487
q20	654	329	323	323
q21	4925	3271	3986	3271
q22	395	344	354	344
Total cold run time: 115284 ms
Total hot run time: 39908 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4349	4254	4215	4215
q2	383	263	274	263
q3	2991	2737	2926	2737
q4	2000	1715	1694	1694
q5	5583	5574	5467	5467
q6	242	137	133	133
q7	2192	1849	1877	1849
q8	3257	3412	3388	3388
q9	9070	9171	9336	9171
q10	4040	3945	3647	3647
q11	603	506	484	484
q12	847	668	629	629
q13	16412	3128	3130	3128
q14	302	279	280	279
q15	526	498	489	489
q16	512	448	452	448
q17	1817	1497	1549	1497
q18	8101	7879	7909	7879
q19	2900	1463	1484	1463
q20	2243	1886	1843	1843
q21	5141	5002	4725	4725
q22	685	576	591	576
Total cold run time: 74196 ms
Total hot run time: 56004 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173564 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8097fd4d775a4707d79f9a71fb946b59747cdf6b, data reload: false

query1	915	372	376	372
query2	6456	2498	2375	2375
query3	6642	218	212	212
query4	28371	17597	17163	17163
query5	3674	488	476	476
query6	258	181	169	169
query7	4602	301	297	297
query8	320	297	297	297
query9	8564	2350	2335	2335
query10	565	320	272	272
query11	11057	10040	10003	10003
query12	127	94	84	84
query13	1646	381	384	381
query14	10171	7755	7683	7683
query15	252	192	187	187
query16	7287	312	316	312
query17	1727	571	540	540
query18	1718	287	286	286
query19	195	158	156	156
query20	89	84	84	84
query21	213	133	128	128
query22	4357	4187	3925	3925
query23	33773	33691	33383	33383
query24	11013	2898	2925	2898
query25	611	444	417	417
query26	728	169	161	161
query27	2363	326	329	326
query28	6092	2109	2123	2109
query29	927	652	639	639
query30	264	162	156	156
query31	956	781	766	766
query32	102	60	59	59
query33	737	326	313	313
query34	896	514	504	504
query35	770	650	647	647
query36	1138	981	949	949
query37	141	83	81	81
query38	2949	2850	2911	2850
query39	885	813	832	813
query40	209	128	126	126
query41	58	53	53	53
query42	119	99	100	99
query43	611	567	555	555
query44	1197	734	741	734
query45	193	167	165	165
query46	1088	817	703	703
query47	1814	1755	1760	1755
query48	383	306	327	306
query49	838	414	416	414
query50	758	390	388	388
query51	6959	6854	6753	6753
query52	104	89	97	89
query53	363	298	299	298
query54	875	445	441	441
query55	75	74	72	72
query56	284	270	283	270
query57	1114	1035	1048	1035
query58	243	239	242	239
query59	3446	3273	3249	3249
query60	319	278	269	269
query61	99	97	95	95
query62	600	432	442	432
query63	322	296	286	286
query64	9477	2159	1629	1629
query65	3160	3064	3209	3064
query66	765	324	332	324
query67	15626	14864	14829	14829
query68	8444	550	554	550
query69	781	455	358	358
query70	1212	1109	1124	1109
query71	528	285	280	280
query72	8886	5366	5449	5366
query73	1700	328	326	326
query74	5918	5576	5513	5513
query75	5178	2698	2652	2652
query76	4808	998	974	974
query77	784	313	321	313
query78	9488	8949	8893	8893
query79	8527	514	522	514
query80	1043	482	471	471
query81	594	216	263	216
query82	487	110	102	102
query83	339	170	168	168
query84	279	87	92	87
query85	927	319	306	306
query86	360	280	313	280
query87	3311	3113	3087	3087
query88	4338	2471	2486	2471
query89	532	382	380	380
query90	2068	193	190	190
query91	132	106	104	104
query92	61	48	49	48
query93	6704	507	501	501
query94	1356	213	212	212
query95	419	336	320	320
query96	610	268	270	268
query97	3162	2995	2981	2981
query98	216	195	192	192
query99	1205	858	852	852
Total cold run time: 299047 ms
Total hot run time: 173564 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.91 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8097fd4d775a4707d79f9a71fb946b59747cdf6b, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.04	0.05
query4	1.68	0.07	0.07
query5	0.51	0.53	0.51
query6	1.16	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.55	0.50	0.50
query10	0.54	0.55	0.54
query11	0.15	0.11	0.12
query12	0.15	0.13	0.12
query13	0.58	0.60	0.58
query14	0.77	0.79	0.75
query15	0.85	0.81	0.82
query16	0.38	0.36	0.37
query17	0.98	1.05	1.04
query18	0.24	0.26	0.26
query19	1.85	1.82	1.77
query20	0.02	0.01	0.01
query21	15.39	0.76	0.67
query22	4.32	8.58	1.13
query23	18.33	1.37	1.27
query24	2.07	0.22	0.21
query25	0.15	0.09	0.08
query26	0.29	0.20	0.20
query27	0.46	0.22	0.22
query28	13.27	1.01	0.99
query29	12.61	3.26	3.24
query30	0.26	0.08	0.06
query31	2.84	0.38	0.38
query32	3.29	0.48	0.47
query33	2.90	2.87	2.96
query34	17.17	4.33	4.40
query35	4.44	4.44	4.43
query36	0.65	0.49	0.47
query37	0.17	0.16	0.16
query38	0.15	0.14	0.15
query39	0.05	0.04	0.03
query40	0.15	0.12	0.12
query41	0.09	0.04	0.04
query42	0.05	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.96 s
Total hot run time: 29.91 s

dataroaring
dataroaring requested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a regression test case.

gavinchou
gavinchou previously approved these changes Jul 14, 2024
View reviewed changes
@w41ter
[chore](backup) Fix the db name of the restored view
8e416b9 
Previously, during restore, the database name in the CREATE VIEW statement was
not modified, causing the restored view to be unviewable with the SHOW VIEW
command. This PR retains the original cluster's database name in the BackupMeta
and manually replaces it with the new cluster's database name in the CREATE VIEW
statement during restore.
@w41ter w41ter force-pushed the fix_show_restored_view branch from 8097fd4 to 60c1984 Compare July 15, 2024 11:11
@w41ter w41ter force-pushed the fix_show_restored_view branch from 60c1984 to e589c2c Compare July 15, 2024 11:31
@w41ter
Copy link
Contributor Author

w41ter commented Jul 15, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40153 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e589c2c67237408853c5f22cd1a02f32c5c78fbf, data reload: false

------ Round 1 ----------------------------------
q1	17954	4628	4446	4446
q2	2294	192	186	186
q3	10479	1254	1127	1127
q4	10201	757	719	719
q5	7540	2707	2688	2688
q6	223	139	139	139
q7	960	598	597	597
q8	9211	2083	2112	2083
q9	8922	6597	6636	6597
q10	8873	3823	3799	3799
q11	462	247	235	235
q12	392	220	216	216
q13	17928	2989	2974	2974
q14	283	234	248	234
q15	533	473	495	473
q16	479	396	385	385
q17	996	700	742	700
q18	8274	7478	7509	7478
q19	2880	1419	1339	1339
q20	700	324	317	317
q21	4955	3159	3144	3144
q22	341	281	277	277
Total cold run time: 114880 ms
Total hot run time: 40153 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4386	4307	4293	4293
q2	373	276	265	265
q3	3032	2801	2726	2726
q4	1886	1594	1608	1594
q5	5320	5327	5331	5327
q6	223	130	133	130
q7	2140	1726	1689	1689
q8	3192	3344	3277	3277
q9	8440	8425	8371	8371
q10	3884	3654	3711	3654
q11	586	491	478	478
q12	763	627	587	587
q13	17540	2986	2965	2965
q14	312	282	268	268
q15	515	482	478	478
q16	467	431	435	431
q17	1822	1494	1453	1453
q18	7865	7599	7388	7388
q19	1935	1646	1574	1574
q20	1966	1838	1784	1784
q21	5012	4721	4867	4721
q22	611	504	508	504
Total cold run time: 72270 ms
Total hot run time: 53957 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172927 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e589c2c67237408853c5f22cd1a02f32c5c78fbf, data reload: false

query1	921	366	368	366
query2	6457	1907	1821	1821
query3	6663	207	214	207
query4	28633	17443	17371	17371
query5	4166	470	463	463
query6	278	169	154	154
query7	4576	297	272	272
query8	245	194	186	186
query9	8594	2374	2352	2352
query10	441	278	281	278
query11	12616	10055	10093	10055
query12	141	83	81	81
query13	1649	374	360	360
query14	10136	7623	8089	7623
query15	229	166	169	166
query16	8115	322	320	320
query17	1789	564	542	542
query18	2089	280	282	280
query19	204	158	154	154
query20	90	82	84	82
query21	207	127	126	126
query22	4482	4132	4020	4020
query23	33690	33210	33174	33174
query24	12087	2962	2947	2947
query25	691	384	386	384
query26	1763	151	149	149
query27	2775	276	275	275
query28	7357	1960	1962	1960
query29	1062	649	647	647
query30	291	152	150	150
query31	1012	738	773	738
query32	97	53	56	53
query33	780	317	302	302
query34	915	496	479	479
query35	710	603	582	582
query36	1100	930	916	916
query37	288	80	83	80
query38	2886	2766	2711	2711
query39	858	810	833	810
query40	287	123	122	122
query41	51	48	46	46
query42	120	96	101	96
query43	523	451	460	451
query44	1256	724	725	724
query45	190	164	162	162
query46	1100	783	717	717
query47	1850	1810	1809	1809
query48	367	291	303	291
query49	1204	419	420	419
query50	787	398	401	398
query51	6825	6824	6846	6824
query52	104	93	91	91
query53	354	284	298	284
query54	1047	450	455	450
query55	77	76	75	75
query56	310	291	307	291
query57	1154	1060	1070	1060
query58	259	261	256	256
query59	2956	2625	2723	2625
query60	315	280	268	268
query61	93	94	91	91
query62	832	673	641	641
query63	320	284	278	278
query64	10440	2206	1680	1680
query65	3145	3103	3084	3084
query66	1365	342	332	332
query67	15858	15134	14896	14896
query68	6639	534	538	534
query69	701	504	362	362
query70	1227	1109	1083	1083
query71	506	275	289	275
query72	8963	5537	5688	5537
query73	806	318	323	318
query74	6212	5694	5655	5655
query75	4724	2682	2726	2682
query76	4873	949	949	949
query77	838	297	295	295
query78	9647	9054	9069	9054
query79	7896	518	507	507
query80	1063	464	454	454
query81	589	214	218	214
query82	1202	137	128	128
query83	332	167	165	165
query84	282	85	86	85
query85	1452	306	336	306
query86	448	324	294	294
query87	3387	3110	3116	3110
query88	4929	2437	2420	2420
query89	538	378	376	376
query90	1970	190	189	189
query91	127	100	99	99
query92	59	50	49	49
query93	6171	499	495	495
query94	1254	213	207	207
query95	409	307	310	307
query96	624	277	267	267
query97	3212	3058	3007	3007
query98	212	203	197	197
query99	1575	1250	1210	1210
Total cold run time: 307139 ms
Total hot run time: 172927 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.75 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e589c2c67237408853c5f22cd1a02f32c5c78fbf, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.07	0.06
query5	0.49	0.48	0.48
query6	1.13	0.73	0.73
query7	0.02	0.02	0.01
query8	0.05	0.05	0.05
query9	0.56	0.50	0.50
query10	0.53	0.54	0.54
query11	0.14	0.12	0.11
query12	0.14	0.12	0.12
query13	0.58	0.58	0.58
query14	0.75	0.76	0.78
query15	0.85	0.81	0.81
query16	0.37	0.37	0.37
query17	0.97	1.04	1.02
query18	0.23	0.22	0.21
query19	1.79	1.73	1.74
query20	0.01	0.00	0.01
query21	15.41	0.74	0.67
query22	4.48	6.64	2.10
query23	18.29	1.42	1.25
query24	2.10	0.23	0.21
query25	0.15	0.09	0.08
query26	0.29	0.20	0.21
query27	0.46	0.22	0.22
query28	13.32	1.00	1.01
query29	12.64	3.26	3.31
query30	0.26	0.06	0.05
query31	2.88	0.38	0.38
query32	3.27	0.48	0.47
query33	2.89	2.92	2.85
query34	17.01	4.34	4.33
query35	4.42	4.43	4.45
query36	0.65	0.46	0.49
query37	0.20	0.16	0.16
query38	0.16	0.15	0.15
query39	0.04	0.03	0.03
query40	0.15	0.12	0.13
query41	0.10	0.04	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.91 s
Total hot run time: 30.75 s

@w41ter
Copy link
Contributor Author

w41ter commented Jul 16, 2024

run buildall

@w41ter w41ter requested review from dataroaring and gavinchou July 16, 2024 06:45
@doris-robot
Copy link

TPC-H: Total hot run time: 40202 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f90c857298d66d3f3e25166911a2362961889c43, data reload: false

------ Round 1 ----------------------------------
q1	17858	4381	4311	4311
q2	2002	193	186	186
q3	10451	1217	1107	1107
q4	10186	878	840	840
q5	8636	2694	2664	2664
q6	217	137	135	135
q7	958	598	604	598
q8	9229	2066	2097	2066
q9	9118	6689	6686	6686
q10	9028	3966	4035	3966
q11	484	250	242	242
q12	403	230	222	222
q13	17952	2963	2987	2963
q14	276	238	253	238
q15	524	493	494	493
q16	516	395	383	383
q17	994	683	670	670
q18	8587	7412	7350	7350
q19	7970	1313	1484	1313
q20	672	331	306	306
q21	4808	3243	3178	3178
q22	350	294	285	285
Total cold run time: 121219 ms
Total hot run time: 40202 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4379	4251	4215	4215
q2	373	265	263	263
q3	3155	2957	2873	2873
q4	2000	1768	1702	1702
q5	5559	5498	5591	5498
q6	224	137	134	134
q7	2234	1838	1855	1838
q8	3285	3438	3377	3377
q9	8778	8963	8749	8749
q10	4020	3844	3900	3844
q11	599	525	501	501
q12	807	660	634	634
q13	16293	3122	3137	3122
q14	305	296	285	285
q15	523	488	487	487
q16	483	424	420	420
q17	1791	1545	1509	1509
q18	8097	7956	7896	7896
q19	1722	1445	1709	1445
q20	2526	1873	1907	1873
q21	4937	4663	4875	4663
q22	602	499	499	499
Total cold run time: 72692 ms
Total hot run time: 55827 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174076 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f90c857298d66d3f3e25166911a2362961889c43, data reload: false

query1	918	365	360	360
query2	6388	1922	1845	1845
query3	6644	210	218	210
query4	27967	17422	17517	17422
query5	3705	473	491	473
query6	274	177	170	170
query7	4586	295	290	290
query8	254	199	192	192
query9	8627	2470	2457	2457
query10	424	271	261	261
query11	10647	10075	10143	10075
query12	111	85	83	83
query13	1640	352	356	352
query14	9263	7554	7487	7487
query15	225	173	169	169
query16	7815	313	318	313
query17	1660	524	525	524
query18	1947	274	269	269
query19	192	148	144	144
query20	85	81	82	81
query21	205	133	121	121
query22	4368	4315	4042	4042
query23	33967	33717	34112	33717
query24	9960	2943	2902	2902
query25	583	390	382	382
query26	704	159	157	157
query27	2190	281	282	281
query28	6159	2097	2085	2085
query29	884	649	643	643
query30	258	149	151	149
query31	992	771	761	761
query32	103	55	53	53
query33	651	296	282	282
query34	889	487	511	487
query35	672	578	571	571
query36	1134	990	996	990
query37	151	86	84	84
query38	3020	2880	2855	2855
query39	895	869	843	843
query40	219	127	123	123
query41	50	46	49	46
query42	112	104	103	103
query43	517	483	478	478
query44	1090	743	725	725
query45	202	168	160	160
query46	1089	750	713	713
query47	1866	1798	1802	1798
query48	388	291	295	291
query49	843	416	417	416
query50	781	393	402	393
query51	6867	6842	6767	6767
query52	100	96	93	93
query53	357	285	290	285
query54	893	450	450	450
query55	74	75	73	73
query56	301	278	277	277
query57	1120	1077	1030	1030
query58	260	264	264	264
query59	2883	2762	2798	2762
query60	321	292	296	292
query61	115	112	111	111
query62	772	660	635	635
query63	318	282	288	282
query64	9198	2285	1761	1761
query65	3203	3112	3102	3102
query66	698	330	339	330
query67	15527	14975	14884	14884
query68	6024	541	544	541
query69	730	443	356	356
query70	1211	1124	1160	1124
query71	445	279	274	274
query72	8671	6071	5248	5248
query73	790	324	327	324
query74	6175	5712	5629	5629
query75	4362	2653	2697	2653
query76	3587	956	965	956
query77	755	304	296	296
query78	11369	12084	9321	9321
query79	9487	531	519	519
query80	1559	470	467	467
query81	592	220	217	217
query82	294	129	130	129
query83	343	163	157	157
query84	276	84	87	84
query85	729	309	289	289
query86	429	303	271	271
query87	3429	3139	3106	3106
query88	5660	2529	2475	2475
query89	458	380	379	379
query90	2457	187	185	185
query91	125	100	99	99
query92	62	49	48	48
query93	1491	498	491	491
query94	1495	210	206	206
query95	400	308	309	308
query96	607	283	275	275
query97	3192	2995	2990	2990
query98	217	201	200	200
query99	1525	1270	1233	1233
Total cold run time: 290267 ms
Total hot run time: 174076 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.77 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f90c857298d66d3f3e25166911a2362961889c43, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.08	0.08
query5	0.49	0.48	0.49
query6	1.13	0.73	0.72
query7	0.02	0.02	0.02
query8	0.06	0.04	0.04
query9	0.54	0.49	0.49
query10	0.54	0.53	0.54
query11	0.15	0.11	0.10
query12	0.15	0.12	0.13
query13	0.59	0.58	0.59
query14	0.75	0.78	0.77
query15	0.84	0.81	0.81
query16	0.35	0.36	0.35
query17	0.97	1.03	1.00
query18	0.23	0.22	0.21
query19	1.92	1.79	1.80
query20	0.02	0.01	0.01
query21	15.39	0.75	0.66
query22	4.36	6.59	1.91
query23	18.31	1.40	1.29
query24	2.04	0.25	0.24
query25	0.14	0.08	0.09
query26	0.29	0.20	0.20
query27	0.45	0.23	0.22
query28	13.23	1.01	0.99
query29	12.57	3.38	3.38
query30	0.25	0.06	0.06
query31	2.86	0.38	0.40
query32	3.27	0.47	0.48
query33	2.95	2.93	2.94
query34	17.17	4.40	4.31
query35	4.50	4.40	4.42
query36	0.65	0.47	0.46
query37	0.18	0.16	0.15
query38	0.16	0.15	0.15
query39	0.04	0.04	0.03
query40	0.14	0.11	0.12
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.04	0.03	0.04
Total cold run time: 109.91 s
Total hot run time: 30.77 s

dataroaring
dataroaring approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@gavinchou gavinchou merged commit 9c76e61 into apache:master Jul 17, 2024
27 of 29 checks passed
@w41ter w41ter deleted the fix_show_restored_view branch July 17, 2024 11:28
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
@w41ter @dataroaring
[chore](backup) Fix the db name of the restored view (#37412)
7a9809d 
Previously, during restore, the database name in the CREATE VIEW
statement was not modified, causing the restored view to be unviewable
with the SHOW VIEW command. This PR retains the original cluster's
database name in the BackupMeta and manually replaces it with the new
cluster's database name in the CREATE VIEW statement during restore.
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Jul 18, 2024
@w41ter
[chore](backup) Fix the db name of the restored view
78e78a8 
Cherry-pick apache#37412

Previously, during restore, the database name in the CREATE VIEW
statement was not modified, causing the restored view to be unviewable
with the SHOW VIEW command. This PR retains the original cluster's
database name in the BackupMeta and manually replaces it with the new
cluster's database name in the CREATE VIEW statement during restore.
@w41ter w41ter mentioned this pull request Jul 18, 2024
Merged
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Jul 18, 2024
@w41ter
[chore](backup) Fix the db name of the restored view
2344082 
Cherry-pick apache#37412

Previously, during restore, the database name in the CREATE VIEW
statement was not modified, causing the restored view to be unviewable
with the SHOW VIEW command. This PR retains the original cluster's
database name in the BackupMeta and manually replaces it with the new
cluster's database name in the CREATE VIEW statement during restore.
@w41ter w41ter mentioned this pull request Jul 18, 2024
Merged
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Jul 18, 2024
@w41ter
[chore](backup) Fix the db name of the restored view
ec7dac1 
Cherry-pick apache#37412

Previously, during restore, the database name in the CREATE VIEW
statement was not modified, causing the restored view to be unviewable
with the SHOW VIEW command. This PR retains the original cluster's
database name in the BackupMeta and manually replaces it with the new
cluster's database name in the CREATE VIEW statement during restore.
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Jul 18, 2024
@w41ter
[chore](backup) Fix the db name of the restored view
d6828a8 
Cherry-pick apache#37412

Previously, during restore, the database name in the CREATE VIEW
statement was not modified, causing the restored view to be unviewable
with the SHOW VIEW command. This PR retains the original cluster's
database name in the BackupMeta and manually replaces it with the new
cluster's database name in the CREATE VIEW statement during restore.
dataroaring pushed a commit that referenced this pull request Jul 18, 2024
@w41ter
[chore](backup) Fix the db name of the restored view (#38075)
2b8c6a0 
Cherry-pick #37412

Previously, during restore, the database name in the CREATE VIEW
statement was not modified, causing the restored view to be unviewable
with the SHOW VIEW command. This PR retains the original cluster's
database name in the BackupMeta and manually replaces it with the new
cluster's database name in the CREATE VIEW statement during restore.
@w41ter w41ter removed the dev/2.1.x label Jul 29, 2024
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@w41ter
[chore](backup) Fix the db name of the restored view (apache#38075)
a521e26 
Cherry-pick apache#37412

Previously, during restore, the database name in the CREATE VIEW
statement was not modified, causing the restored view to be unviewable
with the SHOW VIEW command. This PR retains the original cluster's
database name in the BackupMeta and manually replaces it with the new
cluster's database name in the CREATE VIEW statement during restore.
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Aug 23, 2024
@w41ter
[fix](backup) Read db name from BackupJobInfo
4e396d9 
PR apache#37412 read the db name from BackupMeta, but it is not compatible,
since BackupMeta is not serialized to json.
@w41ter w41ter mentioned this pull request Aug 23, 2024
Merged
dataroaring pushed a commit that referenced this pull request Aug 24, 2024
@w41ter
[fix](backup) Read db name from BackupJobInfo (#39855)
96a0f8d 
PR #37412 read the db name from BackupMeta, but it is not compatible,
since BackupMeta is not serialized to json.
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Aug 26, 2024
@w41ter
[chore](backup) Fix the db name of the restored view
8ba8cc3 
Cherry-pick apache#37412, apache#39855

Previously, during restore, the database name in the CREATE VIEW
statement was not modified, causing the restored view to be unviewable
with the SHOW VIEW command. This PR retains the original cluster's
database name in the BackupMeta and manually replaces it with the new
cluster's database name in the CREATE VIEW statement during restore.
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Aug 26, 2024
@w41ter
[fix](backup) Read db name from BackupJobInfo (apache#39855)
99b4665 
PR apache#37412 read the db name from BackupMeta, but it is not compatible,
since BackupMeta is not serialized to json.
w41ter added a commit that referenced this pull request Aug 26, 2024
@w41ter
[chore](backup) Fix the db name of the restored view (#38072)
e21d2b8 
Cherry-pick #37412, #39855

Previously, during restore, the database name in the CREATE VIEW
statement was not modified, causing the restored view to be unviewable
with the SHOW VIEW command. This PR retains the original cluster's
database name in the BackupMeta and manually replaces it with the new
cluster's database name in the CREATE VIEW statement during restore.
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Sep 5, 2024
@w41ter
[fix](backup) Read db name from BackupJobInfo (apache#39855)
c17679b 
PR apache#37412 read the db name from BackupMeta, but it is not compatible,
since BackupMeta is not serialized to json.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@gavinchou gavinchou gavinchou approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.14-merged dev/2.1.6-merged dev/3.0.1-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@w41ter @doris-robot @gavinchou @dataroaring