[opt](MultiCast) Avoid copying while holding a lock #37462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39491 ms |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40198 ms |
|
run performance |
TPC-H: Total hot run time: 39591 ms |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40561 ms |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39372 ms |
TPC-DS: Total hot run time: 173064 ms |
ClickBench: Total hot run time: 30.37 s |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40251 ms |
TPC-DS: Total hot run time: 172148 ms |
ClickBench: Total hot run time: 30.55 s |
|
run p0 |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
ClickBench: Total hot run time: 31.46 s |
|
run buildall |
TPC-H: Total hot run time: 40394 ms |
TPC-DS: Total hot run time: 173064 ms |
ClickBench: Total hot run time: 31.14 s |
HappenLee
reviewed
Jul 12, 2024
|
|
||
| void MultiCastDataStreamer::_wait_copy_block(vectorized::Block* block, int& un_finish_copy) { | ||
| std::unique_lock l(_mutex); | ||
| _cv.wait(l, [&]() { return un_finish_copy == 0; }); |
There was a problem hiding this comment.
danger will notify different queue last
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Gabriel39
approved these changes
Jul 15, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jul 17, 2024
Previously, copying was done while holding a lock; Now, get block while holding the lock and then copy
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
Previously, copying was done while holding a lock; Now, get block while holding the lock and then copy
HappenLee
pushed a commit
that referenced
this pull request
Jul 29, 2024
pick #37462 The difference is quite large, so it can't be directly picked.
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
pick apache#37462 The difference is quite large, so it can't be directly picked.
Mryange
added a commit
to Mryange/doris
that referenced
this pull request
Aug 23, 2024
Previously, copying was done while holding a lock; Now, get block while holding the lock and then copy
yiguolei
pushed a commit
that referenced
this pull request
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Previously, copying was done while holding a lock;
Now, get block while holding the lock and then copy