[fix](publish) Fix publish failed because because "task" is null #37531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 40033 ms |
TPC-DS: Total hot run time: 172346 ms |
ClickBench: Total hot run time: 30.61 s |
yujun777
reviewed
Jul 10, 2024
| @@ -822,7 +822,7 @@ public String getErrMsg() { | |||
| public void pruneAfterVisible() { | |||
| publishVersionTasks.clear(); | |||
| tableIdToTabletDeltaRows.clear(); | |||
| // TODO if subTransactionStates can be cleared? | |||
| involvedBackends.clear(); | |||
There was a problem hiding this comment.
add @SerializedName to involvedBackends ?
|
PR approved by anyone and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jul 17, 2024
…che#37531) ## Proposed changes ``` 2024-07-08 00:43:27,149 ERROR (PUBLISH_VERSION|33) [PublishVersionDaemon.runAfterCatalogReady():73] errors while publish version to all backends java.lang.NullPointerException: Cannot invoke "org.apache.doris.task.PublishVersionTask.isFinished()" because "task" is null at org.apache.doris.transaction.PublishVersionDaemon.lambda$tryFinishTxn$0(PublishVersionDaemon.java:163) ~[doris-fe.jar:1.2-SNAPSHOT] at java.util.HashMap.forEach(HashMap.java:1421) ~[?:?] at org.apache.doris.transaction.PublishVersionDaemon.tryFinishTxn(PublishVersionDaemon.java:160) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.transaction.PublishVersionDaemon.publishVersion(PublishVersionDaemon.java:96) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.transaction.PublishVersionDaemon.runAfterCatalogReady(PublishVersionDaemon.java:70) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.common.util.MasterDaemon.runOneCycle(MasterDaemon.java:58) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.common.util.Daemon.run(Daemon.java:116) ~[doris-fe.jar:1.2-SNAPSHOT] ``` 1. When try finish one txn, catch the exception to make the failed txn does not block the other txns. 2. In the original way, when commit txn, add a <be_id, null publish task> to publish tasks, and then when publish txn, reset the null publish task to a new publish task. This pr modify it to when commit txn, record the involved be ids, and then when publish txn, generate the publish tasks to all involved bes. 3. There is also a bug of `tableIdToTabletDeltaRows` in transaction state, it records all ready txn infos, because the variable scope is out of `for (TransactionState transactionState : readyTransactionStates)`
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
) ## Proposed changes ``` 2024-07-08 00:43:27,149 ERROR (PUBLISH_VERSION|33) [PublishVersionDaemon.runAfterCatalogReady():73] errors while publish version to all backends java.lang.NullPointerException: Cannot invoke "org.apache.doris.task.PublishVersionTask.isFinished()" because "task" is null at org.apache.doris.transaction.PublishVersionDaemon.lambda$tryFinishTxn$0(PublishVersionDaemon.java:163) ~[doris-fe.jar:1.2-SNAPSHOT] at java.util.HashMap.forEach(HashMap.java:1421) ~[?:?] at org.apache.doris.transaction.PublishVersionDaemon.tryFinishTxn(PublishVersionDaemon.java:160) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.transaction.PublishVersionDaemon.publishVersion(PublishVersionDaemon.java:96) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.transaction.PublishVersionDaemon.runAfterCatalogReady(PublishVersionDaemon.java:70) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.common.util.MasterDaemon.runOneCycle(MasterDaemon.java:58) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.common.util.Daemon.run(Daemon.java:116) ~[doris-fe.jar:1.2-SNAPSHOT] ``` 1. When try finish one txn, catch the exception to make the failed txn does not block the other txns. 2. In the original way, when commit txn, add a <be_id, null publish task> to publish tasks, and then when publish txn, reset the null publish task to a new publish task. This pr modify it to when commit txn, record the involved be ids, and then when publish txn, generate the publish tasks to all involved bes. 3. There is also a bug of `tableIdToTabletDeltaRows` in transaction state, it records all ready txn infos, because the variable scope is out of `for (TransactionState transactionState : readyTransactionStates)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This pr modify it to when commit txn, record the involved be ids, and then when publish txn, generate the publish tasks to all involved bes.
tableIdToTabletDeltaRowsin transaction state, it records all ready txn infos, because the variable scope is out offor (TransactionState transactionState : readyTransactionStates)