Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature](Recycler) Retry object storage request when meeting 429 http error code #37680

Merged
merged 4 commits into from
Jul 14, 2024

Conversation

ByteYue
Copy link
Contributor

@ByteYue ByteYue commented Jul 11, 2024

Proposed changes

When encountering 429 http code, the client sdk would not do retry by default. This pr makes the client retry max_s3_client_retry times.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@ByteYue
Copy link
Contributor Author

ByteYue commented Jul 11, 2024

run buildall

@ByteYue
Copy link
Contributor Author

ByteYue commented Jul 11, 2024

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring previously approved these changes Jul 13, 2024
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 13, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 13, 2024
@ByteYue
Copy link
Contributor Author

ByteYue commented Jul 13, 2024

run buildall

@ByteYue ByteYue requested a review from dataroaring July 13, 2024 15:54
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 13, 2024
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit cf3c3e2 into apache:master Jul 14, 2024
28 of 30 checks passed
seawinde pushed a commit to seawinde/doris that referenced this pull request Jul 17, 2024
…p error code (apache#37680)

When encountering 429 http code, the client sdk would not do retry by
default. This pr makes the client retry `max_s3_client_retry` times.
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
…p error code (#37680)

When encountering 429 http code, the client sdk would not do retry by
default. This pr makes the client retry `max_s3_client_retry` times.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.1-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants