Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](stacktrace) Add conf enable_stacktrace #37713

Merged
merged 10 commits into from
Jul 16, 2024
Merged

[fix](stacktrace) Add conf enable_stacktrace #37713

merged 10 commits into from
Jul 16, 2024

Conversation

xinyiZzz
Copy link
Contributor

enable_stacktrace if false, turn off all stacktrace

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@xinyiZzz
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xinyiZzz
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xinyiZzz
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40024 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cfe3e3c4214a9e14b7716d85b9f6638e76f2e005, data reload: false

------ Round 1 ----------------------------------
q1	18175	4817	4460	4460
q2	2021	194	191	191
q3	10448	1192	1095	1095
q4	10195	788	801	788
q5	7600	2698	2697	2697
q6	221	139	137	137
q7	969	594	598	594
q8	9328	2108	2086	2086
q9	9013	6577	6564	6564
q10	8756	3821	3804	3804
q11	467	241	242	241
q12	406	228	223	223
q13	18815	2966	2972	2966
q14	299	232	230	230
q15	525	487	485	485
q16	474	396	391	391
q17	982	741	643	643
q18	8212	7517	7341	7341
q19	5035	1446	1335	1335
q20	705	330	322	322
q21	4914	3151	4114	3151
q22	352	280	290	280
Total cold run time: 117912 ms
Total hot run time: 40024 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4366	4251	4250	4250
q2	374	269	264	264
q3	3019	2759	2767	2759
q4	1912	1567	1663	1567
q5	5302	5327	5346	5327
q6	222	133	134	133
q7	2119	1752	1700	1700
q8	3198	3334	3321	3321
q9	8437	8353	8411	8353
q10	3882	3731	3667	3667
q11	591	485	472	472
q12	780	597	579	579
q13	16787	2989	2969	2969
q14	307	288	286	286
q15	512	474	485	474
q16	476	416	424	416
q17	1784	1450	1484	1450
q18	7663	7497	7379	7379
q19	2623	1515	1656	1515
q20	2004	1787	1787	1787
q21	4862	4680	4749	4680
q22	547	485	491	485
Total cold run time: 71767 ms
Total hot run time: 53833 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173055 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cfe3e3c4214a9e14b7716d85b9f6638e76f2e005, data reload: false

query1	912	372	361	361
query2	6449	1863	1850	1850
query3	6649	217	226	217
query4	25856	17492	17455	17455
query5	4195	491	488	488
query6	285	188	173	173
query7	4601	306	297	297
query8	247	203	199	199
query9	8700	2418	2404	2404
query10	437	311	279	279
query11	11547	10260	10054	10054
query12	132	84	83	83
query13	1702	373	371	371
query14	10423	7677	7576	7576
query15	231	171	166	166
query16	7692	322	305	305
query17	1802	552	523	523
query18	1950	276	270	270
query19	211	146	146	146
query20	91	82	81	81
query21	211	124	123	123
query22	4434	4176	4074	4074
query23	33835	33249	33175	33175
query24	11891	2896	2777	2777
query25	661	374	369	369
query26	1700	159	156	156
query27	2922	304	278	278
query28	7613	1989	1984	1984
query29	1042	659	618	618
query30	286	148	148	148
query31	971	765	761	761
query32	89	56	55	55
query33	776	314	292	292
query34	928	504	494	494
query35	692	575	582	575
query36	1071	919	897	897
query37	173	79	78	78
query38	2922	2771	2789	2771
query39	847	794	811	794
query40	267	119	118	118
query41	47	49	44	44
query42	119	95	104	95
query43	499	468	470	468
query44	1248	756	741	741
query45	190	162	158	158
query46	1090	736	736	736
query47	1848	1755	1757	1755
query48	369	332	308	308
query49	1176	416	414	414
query50	792	402	411	402
query51	6926	6758	6783	6758
query52	108	94	93	93
query53	363	298	298	298
query54	1010	457	454	454
query55	78	79	71	71
query56	277	265	278	265
query57	1134	1058	1082	1058
query58	261	245	248	245
query59	2767	2525	2551	2525
query60	295	290	284	284
query61	94	96	95	95
query62	843	647	692	647
query63	332	295	286	286
query64	10508	2191	1608	1608
query65	3211	3114	3132	3114
query66	1381	333	331	331
query67	15584	15036	14894	14894
query68	4583	558	546	546
query69	479	337	347	337
query70	1178	1080	1116	1080
query71	391	285	277	277
query72	7755	5592	5852	5592
query73	752	333	333	333
query74	5948	5566	5517	5517
query75	3381	2727	2702	2702
query76	2486	983	912	912
query77	453	317	321	317
query78	11051	9153	9432	9153
query79	2760	529	540	529
query80	1429	507	480	480
query81	580	230	221	221
query82	681	141	137	137
query83	327	168	173	168
query84	280	85	88	85
query85	1384	331	293	293
query86	486	321	290	290
query87	3303	3107	3128	3107
query88	4031	2472	2464	2464
query89	485	410	382	382
query90	1917	201	200	200
query91	130	116	105	105
query92	65	50	54	50
query93	3568	523	525	523
query94	1269	220	228	220
query95	490	329	327	327
query96	610	276	279	276
query97	3216	3001	3068	3001
query98	218	201	194	194
query99	1618	1266	1255	1255
Total cold run time: 287297 ms
Total hot run time: 173055 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.63 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cfe3e3c4214a9e14b7716d85b9f6638e76f2e005, data reload: false

query1	0.04	0.03	0.03
query2	0.09	0.04	0.04
query3	0.23	0.06	0.06
query4	1.67	0.08	0.08
query5	0.49	0.48	0.48
query6	1.14	0.72	0.74
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.57	0.49	0.48
query10	0.53	0.53	0.55
query11	0.14	0.11	0.12
query12	0.15	0.13	0.12
query13	0.59	0.58	0.58
query14	0.78	0.78	0.78
query15	0.86	0.82	0.80
query16	0.37	0.38	0.37
query17	1.04	1.00	1.03
query18	0.23	0.22	0.22
query19	1.84	1.67	1.76
query20	0.01	0.02	0.01
query21	15.56	0.74	0.65
query22	4.66	6.54	1.87
query23	18.18	1.31	1.18
query24	2.14	0.22	0.23
query25	0.16	0.09	0.09
query26	0.29	0.20	0.20
query27	0.45	0.22	0.23
query28	13.24	1.01	1.00
query29	12.62	3.40	3.40
query30	0.25	0.06	0.06
query31	2.87	0.39	0.38
query32	3.27	0.46	0.47
query33	2.88	2.89	2.92
query34	16.92	4.40	4.37
query35	4.51	4.44	4.43
query36	0.66	0.49	0.48
query37	0.19	0.15	0.16
query38	0.16	0.15	0.15
query39	0.04	0.03	0.03
query40	0.15	0.13	0.13
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.25 s
Total hot run time: 30.63 s

yiguolei
yiguolei previously approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@xinyiZzz
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40067 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6d08a6179816cd45f6bb321f6754766283e8f74d, data reload: false

------ Round 1 ----------------------------------
q1	17619	4587	4287	4287
q2	2029	198	201	198
q3	10423	1173	1115	1115
q4	10221	839	817	817
q5	7566	2703	2805	2703
q6	222	137	140	137
q7	963	598	608	598
q8	9217	2088	2113	2088
q9	8933	6569	6538	6538
q10	8883	3823	3836	3823
q11	471	235	235	235
q12	406	224	219	219
q13	18028	3000	2994	2994
q14	280	229	236	229
q15	515	485	499	485
q16	508	397	378	378
q17	993	603	658	603
q18	8112	7615	7421	7421
q19	6546	1498	1389	1389
q20	754	338	326	326
q21	4953	3204	3279	3204
q22	353	280	280	280
Total cold run time: 117995 ms
Total hot run time: 40067 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4424	4260	4360	4260
q2	375	274	272	272
q3	3057	2963	2976	2963
q4	2035	1649	1776	1649
q5	5633	5581	5527	5527
q6	227	140	143	140
q7	2270	1882	1818	1818
q8	3308	3422	3456	3422
q9	8844	8806	8849	8806
q10	4158	3810	3820	3810
q11	621	533	506	506
q12	808	635	623	623
q13	16081	3166	3160	3160
q14	311	291	292	291
q15	529	491	486	486
q16	493	438	438	438
q17	1826	1537	1522	1522
q18	8114	8139	7850	7850
q19	1778	1625	1659	1625
q20	2879	1913	1850	1850
q21	5107	5074	4727	4727
q22	609	511	509	509
Total cold run time: 73487 ms
Total hot run time: 56254 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173872 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6d08a6179816cd45f6bb321f6754766283e8f74d, data reload: false

query1	926	379	370	370
query2	6438	1919	1873	1873
query3	6645	218	224	218
query4	22984	17492	17278	17278
query5	3660	479	491	479
query6	273	180	164	164
query7	4597	295	292	292
query8	242	206	195	195
query9	8516	2399	2377	2377
query10	427	292	279	279
query11	10517	9905	10107	9905
query12	127	84	89	84
query13	1670	384	373	373
query14	10142	6990	7489	6990
query15	219	174	170	170
query16	7087	325	318	318
query17	1345	563	530	530
query18	1219	271	272	271
query19	210	149	150	149
query20	90	79	80	79
query21	212	123	122	122
query22	4319	4087	4168	4087
query23	34004	34556	33879	33879
query24	10980	2957	2860	2860
query25	540	397	384	384
query26	688	154	149	149
query27	2220	281	279	279
query28	6244	2048	2061	2048
query29	858	654	631	631
query30	259	159	159	159
query31	982	746	749	746
query32	103	57	82	57
query33	657	298	284	284
query34	897	508	508	508
query35	679	588	611	588
query36	1134	986	990	986
query37	152	84	89	84
query38	2953	2831	2833	2831
query39	893	866	855	855
query40	201	121	127	121
query41	47	52	48	48
query42	111	104	101	101
query43	513	461	478	461
query44	1093	739	746	739
query45	200	164	163	163
query46	1077	721	745	721
query47	1832	1782	1771	1771
query48	367	302	311	302
query49	832	438	414	414
query50	787	393	394	393
query51	6892	6908	6782	6782
query52	104	91	96	91
query53	354	287	281	281
query54	886	451	443	443
query55	77	74	77	74
query56	279	260	283	260
query57	1116	1043	1033	1033
query58	250	257	249	249
query59	2977	2709	2750	2709
query60	329	278	285	278
query61	114	96	93	93
query62	798	639	674	639
query63	313	284	286	284
query64	9141	2259	1679	1679
query65	3207	3112	3108	3108
query66	792	321	330	321
query67	15551	15449	15049	15049
query68	5257	552	563	552
query69	619	442	347	347
query70	1106	1080	1150	1080
query71	464	289	275	275
query72	7192	5804	6066	5804
query73	781	326	331	326
query74	6214	5665	5695	5665
query75	3529	2720	2718	2718
query76	3390	966	957	957
query77	640	306	312	306
query78	10469	9059	8931	8931
query79	3203	534	524	524
query80	2101	480	485	480
query81	585	225	223	223
query82	1372	137	136	136
query83	337	174	177	174
query84	281	87	85	85
query85	1447	402	301	301
query86	464	320	317	317
query87	3267	3148	3102	3102
query88	4473	2471	2478	2471
query89	481	386	382	382
query90	1762	199	198	198
query91	129	107	103	103
query92	59	51	50	50
query93	4372	516	508	508
query94	1096	218	218	218
query95	417	324	323	323
query96	617	294	284	284
query97	3205	3012	3034	3012
query98	216	199	195	195
query99	1758	1298	1287	1287
Total cold run time: 277651 ms
Total hot run time: 173872 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.84 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6d08a6179816cd45f6bb321f6754766283e8f74d, data reload: false

query1	0.05	0.03	0.03
query2	0.08	0.03	0.03
query3	0.22	0.05	0.05
query4	1.66	0.09	0.10
query5	0.50	0.49	0.50
query6	1.14	0.73	0.73
query7	0.02	0.02	0.01
query8	0.05	0.03	0.04
query9	0.55	0.49	0.49
query10	0.55	0.55	0.55
query11	0.15	0.11	0.12
query12	0.14	0.13	0.12
query13	0.59	0.60	0.58
query14	0.76	0.77	0.77
query15	0.85	0.81	0.81
query16	0.35	0.37	0.36
query17	1.05	0.96	1.05
query18	0.24	0.23	0.23
query19	1.77	1.71	1.75
query20	0.01	0.01	0.01
query21	15.41	0.74	0.65
query22	4.41	6.94	2.11
query23	18.30	1.33	1.28
query24	2.10	0.23	0.21
query25	0.15	0.08	0.09
query26	0.29	0.21	0.21
query27	0.45	0.23	0.23
query28	13.37	1.01	1.00
query29	12.61	3.25	3.25
query30	0.25	0.06	0.06
query31	2.86	0.39	0.38
query32	3.27	0.48	0.49
query33	2.89	2.91	2.94
query34	17.17	4.34	4.38
query35	4.46	4.44	4.45
query36	0.66	0.47	0.50
query37	0.19	0.16	0.16
query38	0.15	0.15	0.16
query39	0.04	0.03	0.03
query40	0.15	0.13	0.12
query41	0.09	0.05	0.04
query42	0.06	0.05	0.06
query43	0.04	0.03	0.04
Total cold run time: 110.1 s
Total hot run time: 30.84 s

@xinyiZzz xinyiZzz force-pushed the 20240712_fix_stack branch from 6d08a61 to 1a47d71 Compare July 15, 2024 07:33
@xinyiZzz
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39977 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1a47d7125a09c139fdd9253c2e6110b1ed28ea33, data reload: false

------ Round 1 ----------------------------------
q1	17996	4497	4404	4404
q2	2477	198	190	190
q3	11526	1183	1063	1063
q4	10512	801	904	801
q5	7598	2685	2644	2644
q6	225	145	141	141
q7	974	606	613	606
q8	9312	2077	2115	2077
q9	8659	6564	6554	6554
q10	8631	3753	3765	3753
q11	454	243	249	243
q12	394	225	230	225
q13	18914	2969	3023	2969
q14	269	227	235	227
q15	535	479	484	479
q16	478	390	381	381
q17	959	624	625	624
q18	8010	7465	7400	7400
q19	8293	1432	1477	1432
q20	719	316	329	316
q21	4949	3169	3185	3169
q22	349	292	279	279
Total cold run time: 122233 ms
Total hot run time: 39977 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4370	4231	4216	4216
q2	369	270	255	255
q3	3031	2764	2719	2719
q4	1914	1588	1574	1574
q5	5267	5360	5320	5320
q6	219	153	129	129
q7	2151	1706	1720	1706
q8	3178	3339	3337	3337
q9	8414	8329	8365	8329
q10	3899	3638	3615	3615
q11	572	496	499	496
q12	769	619	613	613
q13	16377	2969	3005	2969
q14	305	283	267	267
q15	518	479	487	479
q16	467	422	440	422
q17	1779	1504	1461	1461
q18	7615	7362	7250	7250
q19	1662	1537	1464	1464
q20	1977	1774	1786	1774
q21	4945	4756	4691	4691
q22	572	494	510	494
Total cold run time: 70370 ms
Total hot run time: 53580 ms

@xinyiZzz
Copy link
Contributor Author

run buildall

@xinyiZzz
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39935 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 748014a64f7efe7c05db552e25fa49f97fe12da4, data reload: false

------ Round 1 ----------------------------------
q1	18017	4387	4336	4336
q2	2354	189	186	186
q3	10463	1212	1192	1192
q4	10192	798	823	798
q5	7523	2662	2669	2662
q6	221	140	137	137
q7	964	591	592	591
q8	9211	2057	2061	2057
q9	8754	6583	6524	6524
q10	8710	3768	3776	3768
q11	481	237	244	237
q12	394	218	221	218
q13	17774	2987	3008	2987
q14	274	235	234	234
q15	543	487	493	487
q16	472	394	375	375
q17	964	676	700	676
q18	8418	7612	7390	7390
q19	9092	1335	1344	1335
q20	708	319	322	319
q21	4981	3142	3144	3142
q22	346	293	284	284
Total cold run time: 120856 ms
Total hot run time: 39935 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4347	4243	4205	4205
q2	375	268	261	261
q3	2984	2784	2736	2736
q4	1903	1688	1626	1626
q5	5287	5316	5331	5316
q6	220	130	131	130
q7	2130	1682	1636	1636
q8	3174	3340	3299	3299
q9	8425	8395	8382	8382
q10	3864	3697	3687	3687
q11	593	492	479	479
q12	802	609	580	580
q13	17386	2957	3009	2957
q14	303	278	277	277
q15	518	487	476	476
q16	456	412	416	412
q17	1764	1469	1478	1469
q18	7660	7468	7674	7468
q19	3646	1610	1488	1488
q20	2025	1795	1755	1755
q21	4900	4777	4794	4777
q22	582	518	555	518
Total cold run time: 73344 ms
Total hot run time: 53934 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172944 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 748014a64f7efe7c05db552e25fa49f97fe12da4, data reload: false

query1	912	371	359	359
query2	6778	1857	1872	1857
query3	6668	217	226	217
query4	28230	17248	17385	17248
query5	4243	484	481	481
query6	273	164	165	164
query7	4590	310	284	284
query8	238	198	195	195
query9	8406	2391	2372	2372
query10	440	288	267	267
query11	11736	10006	10007	10006
query12	136	84	84	84
query13	1641	376	377	376
query14	10389	7786	8103	7786
query15	224	165	169	165
query16	7820	323	321	321
query17	1797	585	536	536
query18	1873	291	290	290
query19	198	156	158	156
query20	92	81	89	81
query21	208	133	131	131
query22	4320	4206	3998	3998
query23	33795	33083	33115	33083
query24	12032	2888	2902	2888
query25	667	388	393	388
query26	1791	158	150	150
query27	2652	275	275	275
query28	6998	2003	2022	2003
query29	1077	653	623	623
query30	293	148	149	148
query31	964	740	754	740
query32	96	57	60	57
query33	798	315	305	305
query34	953	497	491	491
query35	712	646	589	589
query36	1074	921	943	921
query37	256	84	82	82
query38	2865	2736	2734	2734
query39	844	830	809	809
query40	290	122	126	122
query41	48	46	47	46
query42	124	99	103	99
query43	502	472	444	444
query44	1197	780	756	756
query45	195	167	161	161
query46	1092	751	731	731
query47	1850	1779	1779	1779
query48	370	292	296	292
query49	1216	420	425	420
query50	780	390	385	385
query51	6898	6823	6887	6823
query52	102	96	89	89
query53	359	288	289	288
query54	1068	468	456	456
query55	78	75	76	75
query56	306	281	280	280
query57	1166	1087	1060	1060
query58	271	259	255	255
query59	2975	2606	2531	2531
query60	310	268	268	268
query61	97	94	95	94
query62	829	633	645	633
query63	323	294	283	283
query64	10493	2174	1681	1681
query65	3173	3090	3109	3090
query66	1350	335	326	326
query67	15693	15061	14931	14931
query68	9011	568	568	568
query69	762	461	356	356
query70	1451	1167	1076	1076
query71	516	272	278	272
query72	8583	5494	5641	5494
query73	2243	333	330	330
query74	6255	5648	5653	5648
query75	5232	2678	2739	2678
query76	5428	1085	898	898
query77	802	343	308	308
query78	9739	9089	8953	8953
query79	9355	530	527	527
query80	1019	501	488	488
query81	585	236	226	226
query82	300	131	133	131
query83	327	163	167	163
query84	273	82	89	82
query85	998	302	290	290
query86	344	379	328	328
query87	3343	3172	3094	3094
query88	5031	2459	2493	2459
query89	511	384	391	384
query90	2063	192	201	192
query91	130	99	104	99
query92	61	47	51	47
query93	6204	536	525	525
query94	1378	210	209	209
query95	408	319	308	308
query96	624	271	272	271
query97	3176	3012	3059	3012
query98	213	199	197	197
query99	1621	1283	1273	1273
Total cold run time: 310220 ms
Total hot run time: 172944 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.81 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 748014a64f7efe7c05db552e25fa49f97fe12da4, data reload: false

query1	0.05	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.04
query4	1.68	0.06	0.07
query5	0.50	0.48	0.50
query6	1.13	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.05	0.04
query9	0.55	0.51	0.50
query10	0.55	0.55	0.53
query11	0.15	0.11	0.12
query12	0.14	0.12	0.13
query13	0.59	0.59	0.58
query14	0.76	0.78	0.77
query15	0.85	0.80	0.82
query16	0.37	0.37	0.37
query17	1.03	1.03	1.03
query18	0.22	0.22	0.22
query19	1.84	1.76	1.83
query20	0.01	0.01	0.01
query21	15.45	0.78	0.68
query22	3.97	5.52	3.00
query23	18.28	1.32	1.20
query24	2.18	0.22	0.22
query25	0.14	0.09	0.09
query26	0.30	0.21	0.20
query27	0.45	0.23	0.23
query28	13.18	1.02	0.99
query29	12.63	3.29	3.29
query30	0.25	0.06	0.05
query31	2.89	0.38	0.39
query32	3.26	0.46	0.46
query33	2.87	2.92	2.91
query34	17.22	4.40	4.38
query35	4.42	4.48	4.46
query36	0.65	0.46	0.49
query37	0.19	0.17	0.15
query38	0.15	0.15	0.15
query39	0.04	0.03	0.04
query40	0.15	0.12	0.13
query41	0.09	0.05	0.05
query42	0.06	0.05	0.04
query43	0.05	0.04	0.04
Total cold run time: 109.67 s
Total hot run time: 31.81 s

@xinyiZzz
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40053 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 97c8a0c5e96d395bb9411b1a8f904b7f1ad24ff6, data reload: false

------ Round 1 ----------------------------------
q1	17613	5049	4287	4287
q2	2027	193	189	189
q3	10451	1229	1128	1128
q4	10188	819	783	783
q5	7551	2694	2656	2656
q6	223	136	138	136
q7	961	605	596	596
q8	9213	2077	2089	2077
q9	8728	6584	6604	6584
q10	8693	3817	3820	3817
q11	447	238	233	233
q12	418	238	221	221
q13	18676	2962	3007	2962
q14	286	226	234	226
q15	519	491	495	491
q16	496	390	387	387
q17	991	669	640	640
q18	8135	7540	7388	7388
q19	6326	1434	1536	1434
q20	767	334	332	332
q21	4955	3191	3226	3191
q22	347	295	298	295
Total cold run time: 118011 ms
Total hot run time: 40053 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4355	4259	4271	4259
q2	373	255	268	255
q3	3048	2984	2926	2926
q4	2016	1657	1713	1657
q5	5588	5578	5461	5461
q6	226	133	137	133
q7	2230	1861	1839	1839
q8	3267	3459	3432	3432
q9	8803	8847	8901	8847
q10	4089	3826	3775	3775
q11	610	515	519	515
q12	844	644	614	614
q13	17255	3194	3145	3145
q14	323	277	304	277
q15	527	494	493	493
q16	491	427	439	427
q17	1801	1527	1503	1503
q18	8183	7856	7716	7716
q19	1812	1465	1589	1465
q20	2901	1886	1846	1846
q21	4977	4851	4800	4800
q22	596	521	491	491
Total cold run time: 74315 ms
Total hot run time: 55876 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173615 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 97c8a0c5e96d395bb9411b1a8f904b7f1ad24ff6, data reload: false

query1	909	376	376	376
query2	6457	1907	1918	1907
query3	6635	207	212	207
query4	28321	17827	17297	17297
query5	3653	485	489	485
query6	264	181	168	168
query7	4578	306	295	295
query8	254	203	197	197
query9	8587	2445	2425	2425
query10	430	284	266	266
query11	11553	10089	10044	10044
query12	109	88	86	86
query13	1631	380	362	362
query14	10261	7723	7174	7174
query15	222	163	169	163
query16	7630	312	303	303
query17	1794	542	516	516
query18	1674	280	266	266
query19	209	147	165	147
query20	92	82	99	82
query21	209	129	121	121
query22	4354	4212	4107	4107
query23	33901	33717	33679	33679
query24	10875	2973	2858	2858
query25	628	384	383	383
query26	699	151	155	151
query27	2204	270	279	270
query28	6189	2114	2119	2114
query29	914	654	627	627
query30	254	156	163	156
query31	978	787	765	765
query32	95	55	59	55
query33	704	352	282	282
query34	903	493	504	493
query35	695	579	559	559
query36	1155	958	995	958
query37	143	85	88	85
query38	3044	2939	2863	2863
query39	891	873	836	836
query40	212	127	133	127
query41	47	44	45	44
query42	110	103	101	101
query43	513	484	464	464
query44	1169	732	743	732
query45	198	161	157	157
query46	1101	753	723	723
query47	1890	1778	1800	1778
query48	372	293	290	290
query49	833	419	445	419
query50	784	393	400	393
query51	6844	6834	6718	6718
query52	108	92	98	92
query53	356	287	284	284
query54	849	451	443	443
query55	78	72	74	72
query56	280	270	268	268
query57	1133	1060	1058	1058
query58	252	241	245	241
query59	2899	2759	2694	2694
query60	298	273	270	270
query61	97	91	91	91
query62	820	648	654	648
query63	319	287	284	284
query64	9198	2184	7444	2184
query65	3149	3105	3094	3094
query66	764	336	325	325
query67	15508	15116	14947	14947
query68	5458	550	544	544
query69	661	499	348	348
query70	1194	1111	1162	1111
query71	445	280	270	270
query72	7522	5669	5388	5388
query73	759	324	324	324
query74	6179	5640	5676	5640
query75	3518	2660	2714	2660
query76	3154	936	1012	936
query77	635	310	310	310
query78	10586	8881	8964	8881
query79	3492	521	526	521
query80	1950	474	468	468
query81	588	219	224	219
query82	1192	139	132	132
query83	382	169	174	169
query84	274	85	94	85
query85	1363	315	295	295
query86	470	299	301	299
query87	3300	3110	3085	3085
query88	4629	2389	2402	2389
query89	484	387	387	387
query90	1748	189	189	189
query91	127	97	103	97
query92	69	50	47	47
query93	4326	515	513	513
query94	1154	214	212	212
query95	403	318	330	318
query96	602	273	268	268
query97	3207	3058	2990	2990
query98	222	205	190	190
query99	1689	1261	1282	1261
Total cold run time: 286061 ms
Total hot run time: 173615 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.88 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 97c8a0c5e96d395bb9411b1a8f904b7f1ad24ff6, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.06	0.05
query4	1.67	0.09	0.09
query5	0.51	0.50	0.50
query6	1.14	0.73	0.72
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.56	0.50	0.50
query10	0.54	0.54	0.56
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.59	0.59	0.57
query14	0.76	0.78	0.79
query15	0.85	0.80	0.81
query16	0.36	0.36	0.37
query17	0.97	1.02	1.01
query18	0.22	0.22	0.21
query19	1.83	1.78	1.67
query20	0.01	0.01	0.01
query21	15.50	0.75	0.66
query22	4.61	7.36	2.03
query23	18.31	1.45	1.33
query24	2.08	0.23	0.22
query25	0.14	0.08	0.09
query26	0.30	0.21	0.21
query27	0.46	0.24	0.23
query28	13.32	1.01	1.01
query29	12.61	3.36	3.34
query30	0.25	0.05	0.06
query31	2.87	0.40	0.39
query32	3.27	0.47	0.49
query33	2.91	2.90	2.94
query34	17.01	4.34	4.33
query35	4.43	4.42	4.45
query36	0.66	0.49	0.47
query37	0.18	0.15	0.16
query38	0.16	0.15	0.15
query39	0.05	0.03	0.04
query40	0.16	0.12	0.12
query41	0.09	0.05	0.05
query42	0.06	0.04	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.19 s
Total hot run time: 30.88 s

@xinyiZzz
Copy link
Contributor Author

run buildall

1 similar comment
@yiguolei
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40145 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3451ed16bd62ff6a707795d7dd8a192d57828ba6, data reload: false

------ Round 1 ----------------------------------
q1	17624	4282	4366	4282
q2	2008	194	192	192
q3	10455	1200	1065	1065
q4	10192	786	878	786
q5	7559	2687	2645	2645
q6	222	135	136	135
q7	953	596	588	588
q8	9226	2051	2086	2051
q9	8626	6585	6594	6585
q10	8951	3831	3840	3831
q11	442	245	242	242
q12	398	233	226	226
q13	18085	3035	3012	3012
q14	283	237	232	232
q15	524	486	490	486
q16	497	386	382	382
q17	957	700	683	683
q18	8096	7552	7386	7386
q19	7439	1467	1379	1379
q20	661	335	331	331
q21	4914	3336	3348	3336
q22	356	290	293	290
Total cold run time: 118468 ms
Total hot run time: 40145 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4473	4312	4379	4312
q2	388	265	282	265
q3	3207	3072	3172	3072
q4	2050	1794	1811	1794
q5	5785	5712	5637	5637
q6	253	146	141	141
q7	2393	1948	1898	1898
q8	3221	3476	3403	3403
q9	8806	8826	8757	8757
q10	4158	3737	3909	3737
q11	592	513	506	506
q12	805	669	656	656
q13	17073	3135	3164	3135
q14	310	282	291	282
q15	535	486	505	486
q16	493	431	435	431
q17	1821	1504	1507	1504
q18	8157	8121	7813	7813
q19	1768	1614	1613	1613
q20	2986	1851	1842	1842
q21	8694	4633	4887	4633
q22	599	512	498	498
Total cold run time: 78567 ms
Total hot run time: 56415 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174158 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3451ed16bd62ff6a707795d7dd8a192d57828ba6, data reload: false

query1	920	373	360	360
query2	6404	1944	1925	1925
query3	6642	208	217	208
query4	28345	17521	17277	17277
query5	3611	482	479	479
query6	258	176	164	164
query7	4574	297	282	282
query8	238	215	190	190
query9	8402	2463	2446	2446
query10	449	287	281	281
query11	10250	10159	10171	10159
query12	116	87	91	87
query13	1649	371	374	371
query14	10163	7814	7839	7814
query15	240	168	172	168
query16	7730	326	322	322
query17	1775	552	546	546
query18	1893	281	281	281
query19	200	158	152	152
query20	94	83	82	82
query21	214	130	128	128
query22	4183	4017	4051	4017
query23	33681	33412	33556	33412
query24	10740	2949	2907	2907
query25	622	413	426	413
query26	711	158	165	158
query27	2176	285	279	279
query28	6330	2119	2112	2112
query29	935	675	659	659
query30	249	163	154	154
query31	1006	782	747	747
query32	100	60	57	57
query33	673	330	322	322
query34	872	497	497	497
query35	681	606	629	606
query36	1154	978	986	978
query37	153	82	79	79
query38	2973	2867	2986	2867
query39	896	807	823	807
query40	209	119	126	119
query41	43	42	41	41
query42	118	96	96	96
query43	519	481	483	481
query44	1066	734	734	734
query45	200	161	161	161
query46	1076	726	721	721
query47	1846	1760	1758	1758
query48	387	291	295	291
query49	819	408	418	408
query50	782	385	405	385
query51	6951	6865	6893	6865
query52	112	96	94	94
query53	353	283	282	282
query54	893	450	444	444
query55	79	74	74	74
query56	271	263	262	262
query57	1127	1055	1087	1055
query58	259	258	242	242
query59	2959	2668	2729	2668
query60	309	287	303	287
query61	93	93	95	93
query62	793	666	645	645
query63	319	289	286	286
query64	9136	2168	1697	1697
query65	3165	3113	3093	3093
query66	729	326	336	326
query67	15689	14898	14883	14883
query68	8512	562	574	562
query69	753	431	341	341
query70	1358	1091	1040	1040
query71	535	277	285	277
query72	8605	5899	5669	5669
query73	2258	325	320	320
query74	6117	5627	5678	5627
query75	5041	2700	2682	2682
query76	5101	1023	923	923
query77	768	302	307	302
query78	10354	9063	8982	8982
query79	8177	545	526	526
query80	2504	474	474	474
query81	582	218	223	218
query82	593	141	136	136
query83	281	169	175	169
query84	274	84	92	84
query85	1270	303	346	303
query86	391	295	306	295
query87	3286	3126	3122	3122
query88	4498	2354	2356	2354
query89	539	397	390	390
query90	2018	202	193	193
query91	129	100	104	100
query92	66	50	52	50
query93	6195	525	520	520
query94	1296	217	216	216
query95	411	321	327	321
query96	623	276	268	268
query97	3152	2993	2980	2980
query98	226	213	203	203
query99	1533	1227	1298	1227
Total cold run time: 300050 ms
Total hot run time: 174158 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.76 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3451ed16bd62ff6a707795d7dd8a192d57828ba6, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.22	0.05	0.05
query4	1.67	0.07	0.07
query5	0.50	0.48	0.49
query6	1.14	0.73	0.72
query7	0.02	0.01	0.02
query8	0.06	0.04	0.04
query9	0.54	0.49	0.49
query10	0.53	0.53	0.54
query11	0.15	0.11	0.11
query12	0.14	0.13	0.13
query13	0.58	0.59	0.59
query14	0.78	0.76	0.79
query15	0.87	0.81	0.81
query16	0.36	0.36	0.36
query17	1.04	1.00	1.00
query18	0.23	0.22	0.22
query19	1.75	1.73	1.84
query20	0.02	0.01	0.01
query21	15.38	0.75	0.66
query22	4.62	7.13	1.84
query23	18.29	1.30	1.34
query24	2.12	0.23	0.22
query25	0.16	0.09	0.08
query26	0.30	0.21	0.21
query27	0.46	0.23	0.23
query28	13.23	1.03	0.99
query29	12.63	3.33	3.32
query30	0.26	0.06	0.05
query31	2.91	0.39	0.39
query32	3.25	0.48	0.48
query33	2.89	2.95	2.90
query34	17.11	4.36	4.38
query35	4.44	4.52	4.50
query36	0.63	0.45	0.46
query37	0.19	0.16	0.16
query38	0.15	0.15	0.14
query39	0.04	0.04	0.04
query40	0.15	0.13	0.13
query41	0.09	0.05	0.05
query42	0.06	0.04	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.12 s
Total hot run time: 30.76 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

jacktengg
jacktengg reviewed Jul 16, 2024
View reviewed changes
be/src/vec/common/allocator.cpp
#ifndef ENABLE_STACKTRACE
LOG(INFO) << stack_trace_st.to_string();
#endif
if (!doris::config::enable_stacktrace) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be if (doris::config::enable_stacktrace) ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is if (!doris::config::enable_stacktrace)
u can see before it was #ifndef ENABLE_STACKTRACE

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

执行到这里说明触发了概率性AllocateFailed，为了确保这里有且仅有一个堆栈，加了一个check，如果编译代码的时候不打堆栈，那这里手动获取堆栈打印到日志里。

@yiguolei yiguolei merged commit a741cd3 into apache:master Jul 16, 2024
33 of 37 checks passed
seawinde pushed a commit to seawinde/doris that referenced this pull request Jul 17, 2024
@xinyiZzz @seawinde
[fix](stacktrace) Add conf enable_stacktrace (apache#37713)
d0fb104 
`enable_stacktrace` if false, turn off all stacktrace
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
@xinyiZzz @dataroaring
[fix](stacktrace) Add conf enable_stacktrace (#37713)
cff9a98 
`enable_stacktrace` if false, turn off all stacktrace
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiang-hhhh zhiqiang-hhhh zhiqiang-hhhh approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

@jacktengg jacktengg jacktengg left review comments

@yiguolei yiguolei yiguolei approved these changes

@Gabriel39 Gabriel39 Gabriel39 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.1-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@xinyiZzz @doris-robot @yiguolei @jacktengg @Gabriel39 @zhiqiang-hhhh @gavinchou @dataroaring