-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature](inverted index) multi_match function add #37722
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
return Status::OK(); | ||
} | ||
|
||
Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function 'eval_inverted_index' exceeds recommended size/complexity thresholds [readability-function-size]
Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context,
^
Additional context
be/src/vec/functions/function_multi_match.cpp:94: 85 lines including whitespace and comments (threshold 80)
Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context,
^
|
||
#pragma once | ||
|
||
#include <boost/algorithm/string/split.hpp> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: 'boost/algorithm/string/split.hpp' file not found [clang-diagnostic-error]
#include <boost/algorithm/string/split.hpp>
^
run buildall |
TPC-H: Total hot run time: 39750 ms
|
TPC-DS: Total hot run time: 174312 ms
|
ClickBench: Total hot run time: 31.17 s
|
run buildall |
TPC-H: Total hot run time: 40212 ms
|
TPC-DS: Total hot run time: 174442 ms
|
ClickBench: Total hot run time: 30.71 s
|
7087e1b
to
b45cfd3
Compare
run buildall |
TPC-H: Total hot run time: 39945 ms
|
TPC-DS: Total hot run time: 172760 ms
|
ClickBench: Total hot run time: 30.9 s
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
return Status::OK(); | ||
} | ||
|
||
Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function 'eval_inverted_index' exceeds recommended size/complexity thresholds [readability-function-size]
Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context,
^
Additional context
be/src/vec/functions/function_multi_match.cpp:94: 86 lines including whitespace and comments (threshold 80)
Status FunctionMultiMatch::eval_inverted_index(FunctionContext* context,
^
TPC-H: Total hot run time: 39971 ms
|
TPC-DS: Total hot run time: 173229 ms
|
ClickBench: Total hot run time: 30.54 s
|
run buildall |
TPC-H: Total hot run time: 40355 ms
|
TPC-DS: Total hot run time: 174180 ms
|
ClickBench: Total hot run time: 31.13 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
1. select * from tbl where multi_match(c1, 'c2, c3, c4', 'phrase_prefix', 'xxx'); 2. multi_match performs a match_phrase_prefix query on the columns specified in the first and second parameters. The value to be searched is specified in the fourth parameter.
1. select * from tbl where multi_match(c1, 'c2, c3, c4', 'phrase_prefix', 'xxx'); 2. multi_match performs a match_phrase_prefix query on the columns specified in the first and second parameters. The value to be searched is specified in the fourth parameter.
## Proposed changes 1. select * from tbl where multi_match(c1, 'c2, c3, c4', 'phrase_prefix', 'xxx'); 2. multi_match performs a match_phrase_prefix query on the columns specified in the first and second parameters. The value to be searched is specified in the fourth parameter.
1. select * from tbl where multi_match(c1, 'c2, c3, c4', 'phrase_prefix', 'xxx'); 2. multi_match performs a match_phrase_prefix query on the columns specified in the first and second parameters. The value to be searched is specified in the fourth parameter.
1. select * from tbl where multi_match(c1, 'c2, c3, c4', 'phrase_prefix', 'xxx'); 2. multi_match performs a match_phrase_prefix query on the columns specified in the first and second parameters. The value to be searched is specified in the fourth parameter.
Proposed changes