-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](publish) Catch exception in genPublishTask to make one failed txn does not block the other txns #37724
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 39592 ms
|
TPC-DS: Total hot run time: 174134 ms
|
ClickBench: Total hot run time: 30.66 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need update
fe/fe-core/src/main/java/org/apache/doris/transaction/PublishVersionDaemon.java
Outdated
Show resolved
Hide resolved
run buildall |
TPC-H: Total hot run time: 40112 ms
|
TPC-DS: Total hot run time: 173445 ms
|
ClickBench: Total hot run time: 30.71 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
…xn does not block the other txns (#37724) ## Proposed changes If any exception(such as NullPointerException) is thrown in `genPublishTask` when publish, the publish for all txns will fail. This pr catch the exception to make the failed txn does not block other txns.
…led txn does not block the other txns (apache#37724)
…led txn does not block the other txns (apache#37724)
…led txn does not block the other txns (apache#37724) (apache#38044) Pick apache#37724
Proposed changes
If any exception(such as NullPointerException) is thrown in
genPublishTask
when publish, the publish for all txns will fail.This pr catch the exception to make the failed txn does not block other txns.