Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](delete) Delete job should retry for failure that is not DELETE_INVALID_XXX #37834

Merged
merged 4 commits into from
Jul 17, 2024
Merged

[opt](delete) Delete job should retry for failure that is not DELETE_INVALID_XXX #37834

merged 4 commits into from
Jul 17, 2024

Conversation

bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Jul 15, 2024 •
edited
Loading

Proposed changes

fix #37363, delete job should fail and abort for DELETE_INVALID_CONDITION/DELETE_INVALID_PARAMETERS and retry for other failures.

branch-2.1 pick: #38032

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 15, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39716 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4c2d565222309ec820d5d89750eb776008ce2502, data reload: false

------ Round 1 ----------------------------------
q1	6480	4418	4280	4280
q2	1765	189	184	184
q3	4643	1101	1134	1101
q4	4017	817	691	691
q5	2808	2727	2672	2672
q6	287	160	152	152
q7	1023	608	595	595
q8	9237	2069	2059	2059
q9	9736	6556	6579	6556
q10	8811	3764	3741	3741
q11	456	246	236	236
q12	427	232	220	220
q13	17751	2982	2967	2967
q14	283	233	241	233
q15	533	502	489	489
q16	475	386	378	378
q17	957	622	703	622
q18	8003	7414	7494	7414
q19	1610	1385	1437	1385
q20	637	320	319	319
q21	4897	3146	3191	3146
q22	347	283	276	276
Total cold run time: 85183 ms
Total hot run time: 39716 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4377	4242	4217	4217
q2	373	263	273	263
q3	3004	2834	2692	2692
q4	1845	1569	1595	1569
q5	5274	5305	5294	5294
q6	225	128	128	128
q7	2108	1679	1706	1679
q8	3206	3347	3306	3306
q9	8395	8341	8348	8341
q10	3843	3692	3667	3667
q11	579	479	478	478
q12	786	600	602	600
q13	16442	2965	2985	2965
q14	289	267	263	263
q15	527	472	486	472
q16	457	403	408	403
q17	1755	1436	1450	1436
q18	7659	7419	7361	7361
q19	1647	1445	1595	1445
q20	2010	1849	1774	1774
q21	4931	4633	4711	4633
q22	548	516	505	505
Total cold run time: 70280 ms
Total hot run time: 53491 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172457 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4c2d565222309ec820d5d89750eb776008ce2502, data reload: false

query1	921	366	375	366
query2	6461	1896	1900	1896
query3	6657	203	216	203
query4	24871	17669	17191	17191
query5	4172	479	470	470
query6	250	164	160	160
query7	4603	277	284	277
query8	245	192	204	192
query9	8507	2351	2321	2321
query10	441	288	277	277
query11	12016	10116	10094	10094
query12	135	86	82	82
query13	1658	374	372	372
query14	10146	7617	7620	7617
query15	217	170	166	166
query16	7872	325	320	320
query17	1797	563	544	544
query18	1896	286	288	286
query19	201	159	153	153
query20	92	84	85	84
query21	212	125	124	124
query22	4282	4150	4080	4080
query23	33780	33008	33056	33008
query24	11960	2933	2829	2829
query25	674	401	394	394
query26	1763	146	147	146
query27	2981	271	272	271
query28	7609	1958	1951	1951
query29	1077	634	624	624
query30	282	154	151	151
query31	984	740	758	740
query32	98	57	56	56
query33	795	310	311	310
query34	952	476	477	476
query35	702	593	582	582
query36	1086	899	894	894
query37	278	82	89	82
query38	2881	2800	2784	2784
query39	852	817	807	807
query40	280	126	124	124
query41	50	46	49	46
query42	131	99	105	99
query43	505	476	472	472
query44	1154	744	718	718
query45	190	160	162	160
query46	1078	742	704	704
query47	1852	1751	1809	1751
query48	368	294	297	294
query49	1218	418	424	418
query50	780	397	393	393
query51	6994	6767	6700	6700
query52	100	94	96	94
query53	357	302	290	290
query54	1063	454	452	452
query55	77	75	76	75
query56	318	297	299	297
query57	1185	1060	1082	1060
query58	272	258	370	258
query59	2913	2844	2888	2844
query60	345	273	277	273
query61	100	95	94	94
query62	830	647	669	647
query63	319	283	290	283
query64	10436	2227	1628	1628
query65	3169	3109	3095	3095
query66	1355	335	327	327
query67	15693	15056	14928	14928
query68	8996	538	532	532
query69	748	486	365	365
query70	1382	1107	1050	1050
query71	549	272	305	272
query72	8487	5385	5302	5302
query73	2246	315	319	315
query74	6170	5672	5635	5635
query75	5481	2669	2682	2669
query76	5372	983	966	966
query77	795	303	305	303
query78	9767	9022	9989	9022
query79	7926	510	515	510
query80	1104	522	465	465
query81	577	220	214	214
query82	290	135	130	130
query83	322	162	165	162
query84	276	87	88	87
query85	1020	312	298	298
query86	365	309	318	309
query87	3376	3108	3146	3108
query88	4540	2469	2425	2425
query89	520	395	385	385
query90	2114	194	187	187
query91	128	102	102	102
query92	62	50	50	50
query93	4588	484	483	483
query94	1458	217	215	215
query95	404	312	317	312
query96	609	275	267	267
query97	3204	3004	3013	3004
query98	220	203	194	194
query99	1530	1215	1221	1215
Total cold run time: 304164 ms
Total hot run time: 172457 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.61 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4c2d565222309ec820d5d89750eb776008ce2502, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.66	0.09	0.08
query5	0.49	0.50	0.49
query6	1.15	0.74	0.73
query7	0.02	0.02	0.01
query8	0.06	0.04	0.05
query9	0.55	0.49	0.50
query10	0.54	0.54	0.54
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.59	0.57	0.58
query14	0.76	0.77	0.76
query15	0.84	0.82	0.81
query16	0.34	0.36	0.36
query17	0.99	1.03	0.97
query18	0.22	0.21	0.21
query19	1.80	1.75	1.70
query20	0.01	0.00	0.01
query21	15.40	0.72	0.64
query22	4.54	6.82	1.94
query23	18.33	1.38	1.34
query24	2.17	0.24	0.22
query25	0.17	0.10	0.08
query26	0.29	0.21	0.21
query27	0.44	0.23	0.23
query28	13.24	1.01	1.00
query29	12.59	3.30	3.24
query30	0.25	0.06	0.05
query31	2.87	0.39	0.37
query32	3.32	0.48	0.47
query33	2.91	2.92	2.91
query34	17.04	4.40	4.36
query35	4.45	4.41	4.43
query36	0.65	0.46	0.49
query37	0.19	0.16	0.16
query38	0.16	0.14	0.16
query39	0.04	0.03	0.03
query40	0.15	0.12	0.13
query41	0.10	0.05	0.04
query42	0.06	0.04	0.05
query43	0.04	0.04	0.05
Total cold run time: 110.05 s
Total hot run time: 30.61 s

zhannngchen
zhannngchen previously approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 15, 2024

run external

dataroaring
dataroaring previously approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobhan1 bobhan1 dismissed stale reviews from dataroaring and zhannngchen via 3d05c64 July 16, 2024 02:35
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 16, 2024
@bobhan1 bobhan1 force-pushed the delete-from-should-retry-for-lock-failed branch from 3d05c64 to be8a182 Compare July 16, 2024 02:39
@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 16, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1 bobhan1 requested a review from zhannngchen July 16, 2024 02:41
@bobhan1 bobhan1 force-pushed the delete-from-should-retry-for-lock-failed branch from be8a182 to 27a8702 Compare July 16, 2024 02:42
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 16, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40061 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 27a870281d1bfb2b60c5ab44d772df3d8e05d887, data reload: false

------ Round 1 ----------------------------------
q1	17883	5123	4384	4384
q2	3035	212	195	195
q3	11731	1191	1083	1083
q4	10411	795	875	795
q5	7612	2752	2824	2752
q6	223	140	144	140
q7	970	606	604	604
q8	9209	2069	2079	2069
q9	8571	6563	6583	6563
q10	8654	3757	3804	3757
q11	453	247	240	240
q12	403	237	228	228
q13	17954	3016	2960	2960
q14	288	234	236	234
q15	537	487	499	487
q16	491	397	390	390
q17	966	639	641	639
q18	8055	7555	7474	7474
q19	3589	1374	1320	1320
q20	667	333	330	330
q21	4836	3125	3237	3125
q22	355	296	292	292
Total cold run time: 116893 ms
Total hot run time: 40061 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4352	4224	4248	4224
q2	382	262	274	262
q3	3006	2812	2828	2812
q4	1881	1604	1639	1604
q5	5307	5307	5348	5307
q6	216	136	140	136
q7	2065	1681	1683	1681
q8	3191	3328	3278	3278
q9	8384	8391	8384	8384
q10	3909	3664	3730	3664
q11	582	487	487	487
q12	788	596	605	596
q13	17093	2982	2999	2982
q14	305	284	262	262
q15	527	482	483	482
q16	473	430	419	419
q17	1770	1509	1474	1474
q18	7734	7499	7228	7228
q19	1687	1470	1537	1470
q20	1986	1821	1794	1794
q21	4859	4719	4748	4719
q22	591	487	534	487
Total cold run time: 71088 ms
Total hot run time: 53752 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172335 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 27a870281d1bfb2b60c5ab44d772df3d8e05d887, data reload: false

query1	922	378	367	367
query2	6463	1864	1798	1798
query3	6661	207	219	207
query4	26107	17625	17238	17238
query5	4213	487	493	487
query6	272	182	168	168
query7	4595	295	298	295
query8	243	219	197	197
query9	8436	2447	2414	2414
query10	468	283	293	283
query11	10523	10024	10023	10023
query12	128	86	86	86
query13	1636	381	363	363
query14	10278	7651	7838	7651
query15	220	165	169	165
query16	7958	332	323	323
query17	1787	561	536	536
query18	1952	294	279	279
query19	203	151	153	151
query20	95	84	85	84
query21	205	132	131	131
query22	4248	3939	4035	3939
query23	33914	33143	33101	33101
query24	12144	2863	2865	2863
query25	662	382	395	382
query26	1758	155	151	151
query27	2883	276	277	276
query28	7682	2032	2022	2022
query29	1061	643	639	639
query30	284	149	157	149
query31	961	763	746	746
query32	98	55	57	55
query33	784	323	309	309
query34	944	480	493	480
query35	708	583	589	583
query36	1085	935	937	935
query37	289	80	82	80
query38	2865	2793	2722	2722
query39	864	791	838	791
query40	280	127	122	122
query41	44	49	46	46
query42	122	96	100	96
query43	495	464	447	447
query44	1227	743	728	728
query45	197	165	162	162
query46	1081	764	727	727
query47	1824	1748	1756	1748
query48	366	310	301	301
query49	1204	432	424	424
query50	786	400	398	398
query51	6868	6762	6731	6731
query52	107	89	97	89
query53	366	307	299	299
query54	1010	460	454	454
query55	76	77	78	77
query56	304	289	301	289
query57	1202	1063	1051	1051
query58	261	353	259	259
query59	2750	2660	2645	2645
query60	320	267	274	267
query61	97	93	92	92
query62	849	653	653	653
query63	328	297	301	297
query64	10516	2221	1687	1687
query65	3219	3148	3091	3091
query66	1346	335	345	335
query67	15824	14970	14912	14912
query68	8776	567	574	567
query69	719	451	349	349
query70	1202	1041	1100	1041
query71	532	270	279	270
query72	8802	5401	5776	5401
query73	1601	335	329	329
query74	6140	5594	5585	5585
query75	5160	2716	2703	2703
query76	5147	974	888	888
query77	795	308	301	301
query78	9687	8905	9604	8905
query79	9903	520	527	520
query80	1080	502	475	475
query81	580	218	222	218
query82	780	136	134	134
query83	331	165	168	165
query84	272	86	89	86
query85	1349	314	300	300
query86	402	289	301	289
query87	3289	3135	3084	3084
query88	4350	2372	2382	2372
query89	541	374	376	374
query90	2077	193	190	190
query91	129	99	101	99
query92	63	49	50	49
query93	7225	516	509	509
query94	1355	219	207	207
query95	399	313	313	313
query96	609	279	267	267
query97	3219	2991	3019	2991
query98	230	211	198	198
query99	1636	1324	1260	1260
Total cold run time: 308048 ms
Total hot run time: 172335 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.15 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 27a870281d1bfb2b60c5ab44d772df3d8e05d887, data reload: false

query1	0.05	0.03	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.67	0.07	0.07
query5	0.48	0.47	0.50
query6	1.15	0.73	0.72
query7	0.02	0.02	0.02
query8	0.06	0.04	0.04
query9	0.55	0.49	0.49
query10	0.55	0.53	0.54
query11	0.15	0.12	0.11
query12	0.15	0.13	0.13
query13	0.59	0.60	0.58
query14	0.75	0.78	0.78
query15	0.86	0.83	0.82
query16	0.36	0.35	0.36
query17	0.99	0.97	0.98
query18	0.23	0.22	0.24
query19	1.85	1.71	1.71
query20	0.01	0.01	0.01
query21	15.41	0.74	0.65
query22	4.36	6.53	2.38
query23	18.28	1.31	1.32
query24	2.04	0.27	0.22
query25	0.16	0.08	0.09
query26	0.29	0.22	0.21
query27	0.45	0.24	0.23
query28	13.28	1.02	1.01
query29	12.59	3.33	3.35
query30	0.26	0.06	0.06
query31	2.86	0.39	0.40
query32	3.27	0.49	0.48
query33	2.89	2.89	2.94
query34	16.88	4.33	4.36
query35	4.42	4.44	4.40
query36	0.66	0.47	0.47
query37	0.19	0.16	0.16
query38	0.16	0.15	0.14
query39	0.04	0.04	0.03
query40	0.15	0.13	0.12
query41	0.09	0.05	0.04
query42	0.05	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.59 s
Total hot run time: 31.15 s

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40129 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3ffbf3ab4988e4f19d50294ce8ab2199288447b1, data reload: false

------ Round 1 ----------------------------------
q1	17850	4478	4456	4456
q2	2642	226	205	205
q3	10956	1208	1115	1115
q4	10687	834	822	822
q5	7659	2745	2696	2696
q6	229	144	142	142
q7	991	628	609	609
q8	10167	2071	2099	2071
q9	8925	6564	6519	6519
q10	8687	3779	3774	3774
q11	465	244	251	244
q12	394	234	230	230
q13	17771	2995	3010	2995
q14	279	238	244	238
q15	535	481	497	481
q16	486	385	381	381
q17	969	681	652	652
q18	8120	7511	7398	7398
q19	7454	1279	1362	1279
q20	698	329	338	329
q21	4989	3201	3331	3201
q22	359	306	292	292
Total cold run time: 121312 ms
Total hot run time: 40129 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4423	4285	4328	4285
q2	372	254	265	254
q3	3044	2759	2782	2759
q4	1913	1632	1583	1583
q5	5316	5362	5362	5362
q6	225	136	137	136
q7	2118	1752	1734	1734
q8	3218	3343	3341	3341
q9	8422	8392	8377	8377
q10	3955	3742	3733	3733
q11	585	496	483	483
q12	817	589	593	589
q13	17685	3001	3001	3001
q14	305	275	269	269
q15	531	481	480	480
q16	506	410	427	410
q17	1783	1506	1482	1482
q18	7602	7656	7418	7418
q19	1680	1411	1516	1411
q20	2001	1777	1796	1777
q21	4870	4775	4843	4775
q22	627	508	513	508
Total cold run time: 71998 ms
Total hot run time: 54167 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173079 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3ffbf3ab4988e4f19d50294ce8ab2199288447b1, data reload: false

query1	921	396	363	363
query2	6456	1827	1811	1811
query3	6667	208	220	208
query4	23884	17187	17372	17187
query5	4186	507	494	494
query6	269	194	170	170
query7	4596	296	283	283
query8	230	188	193	188
query9	8472	2427	2400	2400
query10	433	301	285	285
query11	11835	10065	10010	10010
query12	137	98	82	82
query13	1638	379	374	374
query14	10537	8117	7934	7934
query15	237	169	176	169
query16	7839	315	325	315
query17	1815	553	545	545
query18	1372	281	285	281
query19	207	160	159	159
query20	92	87	87	87
query21	211	134	125	125
query22	4445	4108	4037	4037
query23	33910	33122	33407	33122
query24	11151	2882	2896	2882
query25	631	397	397	397
query26	1222	153	153	153
query27	2771	276	279	276
query28	7054	2023	2008	2008
query29	909	655	637	637
query30	287	162	156	156
query31	957	749	741	741
query32	100	58	59	58
query33	784	320	317	317
query34	909	490	492	490
query35	730	583	598	583
query36	1081	977	965	965
query37	154	83	82	82
query38	2875	2774	2770	2770
query39	855	815	832	815
query40	275	124	130	124
query41	51	48	49	48
query42	125	102	105	102
query43	513	479	468	468
query44	1282	752	740	740
query45	196	166	165	165
query46	1088	789	754	754
query47	1851	1752	1779	1752
query48	383	301	407	301
query49	1052	425	418	418
query50	781	419	406	406
query51	6933	6837	6799	6799
query52	105	96	93	93
query53	367	293	301	293
query54	923	457	445	445
query55	77	74	76	74
query56	292	269	274	269
query57	1149	1033	1047	1033
query58	250	256	268	256
query59	2954	2690	2480	2480
query60	316	276	277	276
query61	99	93	110	93
query62	830	663	661	661
query63	329	294	295	294
query64	9613	2234	1737	1737
query65	3176	3141	3119	3119
query66	922	342	339	339
query67	15637	14957	14862	14862
query68	5468	546	546	546
query69	731	462	332	332
query70	1193	1179	1155	1155
query71	474	300	282	282
query72	8486	5390	6027	5390
query73	787	327	321	321
query74	6090	5758	5673	5673
query75	4631	2705	2683	2683
query76	3935	955	973	955
query77	767	328	310	310
query78	9752	8943	8921	8921
query79	3656	519	526	519
query80	2456	482	475	475
query81	594	220	225	220
query82	1329	131	133	131
query83	302	162	166	162
query84	271	97	83	83
query85	1655	301	291	291
query86	476	340	315	315
query87	3312	3197	3096	3096
query88	4522	2365	2380	2365
query89	504	409	390	390
query90	1941	193	193	193
query91	130	99	102	99
query92	67	50	47	47
query93	5255	499	504	499
query94	1319	205	213	205
query95	389	320	319	319
query96	614	269	272	269
query97	3189	3010	3038	3010
query98	224	200	235	200
query99	1739	1290	1263	1263
Total cold run time: 290686 ms
Total hot run time: 173079 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.87 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3ffbf3ab4988e4f19d50294ce8ab2199288447b1, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.07	0.07
query5	0.48	0.49	0.49
query6	1.14	0.73	0.73
query7	0.02	0.01	0.01
query8	0.05	0.05	0.05
query9	0.56	0.50	0.51
query10	0.56	0.55	0.56
query11	0.14	0.11	0.11
query12	0.15	0.12	0.13
query13	0.59	0.58	0.59
query14	0.77	0.79	0.80
query15	0.84	0.81	0.82
query16	0.37	0.36	0.39
query17	1.01	0.95	0.95
query18	0.23	0.21	0.21
query19	1.87	1.83	1.82
query20	0.01	0.01	0.01
query21	15.39	0.76	0.66
query22	3.32	8.72	1.93
query23	18.30	1.36	1.41
query24	1.99	0.24	0.21
query25	0.16	0.09	0.09
query26	0.29	0.22	0.21
query27	0.45	0.23	0.23
query28	13.37	1.04	0.99
query29	12.64	3.29	3.32
query30	0.26	0.06	0.06
query31	2.86	0.40	0.38
query32	3.29	0.48	0.47
query33	2.91	2.90	2.85
query34	16.86	4.37	4.36
query35	4.47	4.42	4.40
query36	0.64	0.49	0.50
query37	0.18	0.16	0.16
query38	0.15	0.15	0.15
query39	0.05	0.04	0.03
query40	0.16	0.13	0.12
query41	0.10	0.06	0.06
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 108.76 s
Total hot run time: 30.87 s

@bobhan1 bobhan1 requested a review from dataroaring July 16, 2024 13:53
@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 16, 2024

run cloud_p0

2 similar comments
@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 16, 2024

run cloud_p0

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 17, 2024

run cloud_p0

@bobhan1 bobhan1 changed the title [opt](delete) Delete job should retry if encounter TRY_LOCK_FAILED status [opt](delete) Delete job should retry for failure that is not DELETE_INVALID_XXX Jul 17, 2024
dataroaring
dataroaring approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit 15a6f84 into apache:master Jul 17, 2024
27 of 30 checks passed
This was referenced Jul 17, 2024
Merged
Merged
dataroaring pushed a commit that referenced this pull request Jul 18, 2024
@bobhan1
[branch-2.1] Picks "[opt](delete) Delete job should retry for failure…
c30c1d2 
… that is not DELETE_INVALID_XXX #37834" (#38032)

## Proposed changes

picks #37834 and
#38043
dataroaring pushed a commit that referenced this pull request Jul 18, 2024
@bobhan1
[Fix](beut) Fix TestDeleteConditionHandler beut (#38043)
c094339 
introduced in #37834
dataroaring pushed a commit that referenced this pull request Jul 19, 2024
@bobhan1 @dataroaring
[opt](delete) Delete job should retry for failure that is not `DELETE…
50ea3f6 
…_INVALID_XXX` (#37834)

## Proposed changes

fix #37363, delete job should fail
and abort for DELETE_INVALID_CONDITION/DELETE_INVALID_PARAMETERS and
retry for other failures.
dataroaring pushed a commit that referenced this pull request Jul 19, 2024
@bobhan1 @dataroaring
[Fix](beut) Fix TestDeleteConditionHandler beut (#38043)
4bc800f 
introduced in #37834
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
@bobhan1 bobhan1 mentioned this pull request Aug 28, 2024
Merged
dataroaring pushed a commit that referenced this pull request Aug 28, 2024
@bobhan1
[branch-2.0](delete) Fix delete job timeout when executing `delete fr…
4114178 
…om ...` (#40028)

## Proposed changes

picks #37363,
#37834,
#38043
@xiaokang xiaokang mentioned this pull request Sep 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@luwei16 luwei16 luwei16 approved these changes

@zhannngchen zhannngchen Awaiting requested review from zhannngchen

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.15-merged dev/2.1.5-merged dev/3.0.1-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bobhan1 @doris-robot @luwei16 @zhannngchen @dataroaring