[fix](inverted index) Error parsing NULL_LITERAL #37842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
airborne12
reviewed
Jul 15, 2024
| @@ -2811,7 +2812,8 @@ void SegmentIterator::_calculate_pred_in_remaining_conjunct_root( | |||
| } else if (_is_literal_node(node_type)) { | |||
| auto v_literal_expr = static_cast<const doris::vectorized::VLiteral*>(expr.get()); | |||
| _column_predicate_info->query_values.insert(v_literal_expr->value()); | |||
| } else { | |||
| } else if (node_type == TExprNodeType::BINARY_PRED || node_type == TExprNodeType::MATCH_PRED || | |||
There was a problem hiding this comment.
Remember to refactor in order to unify all the code to the same behavior.
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 39508 ms |
TPC-DS: Total hot run time: 172727 ms |
ClickBench: Total hot run time: 31.19 s |
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jul 17, 2024
## Proposed changes 1. NULL_LITERAL and other LITERAL will enter the else process incorrectly 2. SELECT * FROM table_name WHERE column_name NOT IN (1, 2, NULL); The NOT IN operator returns an empty result set when the collection contains NULL.
zzzxl1993
added a commit
to zzzxl1993/doris
that referenced
this pull request
Jul 21, 2024
1. NULL_LITERAL and other LITERAL will enter the else process incorrectly 2. SELECT * FROM table_name WHERE column_name NOT IN (1, 2, NULL); The NOT IN operator returns an empty result set when the collection contains NULL.
zzzxl1993
added a commit
to zzzxl1993/doris
that referenced
this pull request
Jul 21, 2024
## Proposed changes 1. NULL_LITERAL and other LITERAL will enter the else process incorrectly 2. SELECT * FROM table_name WHERE column_name NOT IN (1, 2, NULL); The NOT IN operator returns an empty result set when the collection contains NULL.
yiguolei
pushed a commit
that referenced
this pull request
Jul 25, 2024
zzzxl1993
added a commit
to zzzxl1993/doris
that referenced
this pull request
Aug 1, 2024
1. NULL_LITERAL and other LITERAL will enter the else process incorrectly 2. SELECT * FROM table_name WHERE column_name NOT IN (1, 2, NULL); The NOT IN operator returns an empty result set when the collection contains NULL.
xiaokang
pushed a commit
that referenced
this pull request
Aug 1, 2024
xiaokang
pushed a commit
that referenced
this pull request
Aug 2, 2024
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes