Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](inverted index) Corrected the issue of no_index_match failure caused by empty data. #37947

Merged
merged 1 commit into from
Jul 17, 2024
Merged

[fix](inverted index) Corrected the issue of no_index_match failure caused by empty data. #37947

merged 1 commit into from
Jul 17, 2024

Conversation

zzzxl1993
Copy link
Contributor

Proposed changes

  1. Empty data caused no_index match_phrase_prefix to fail.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zzzxl1993
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

xiaokang
xiaokang approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 39848 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 16da2f84d046a05027e00a17883cfc71773496ae, data reload: false

------ Round 1 ----------------------------------
q1	18013	4481	4448	4448
q2	2172	187	185	185
q3	10455	1155	992	992
q4	10190	871	794	794
q5	7538	2694	2668	2668
q6	225	142	136	136
q7	952	597	591	591
q8	9226	2058	2089	2058
q9	8653	6528	6488	6488
q10	8685	3807	3814	3807
q11	469	236	235	235
q12	395	224	214	214
q13	18098	2955	2971	2955
q14	272	228	234	228
q15	532	476	494	476
q16	482	387	384	384
q17	952	683	694	683
q18	8199	7399	7410	7399
q19	6961	1466	1397	1397
q20	679	325	323	323
q21	4919	3103	3212	3103
q22	353	288	284	284
Total cold run time: 118420 ms
Total hot run time: 39848 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4377	4313	4249	4249
q2	367	263	269	263
q3	2999	2754	2711	2711
q4	1856	1563	1574	1563
q5	5283	5296	5315	5296
q6	220	133	132	132
q7	2115	1744	1715	1715
q8	3183	3297	3281	3281
q9	8382	8386	8376	8376
q10	3904	3676	3693	3676
q11	588	490	493	490
q12	782	624	592	592
q13	17486	2973	2981	2973
q14	308	281	271	271
q15	530	473	472	472
q16	471	419	428	419
q17	1785	1497	1448	1448
q18	7648	7480	7280	7280
q19	1667	1547	1334	1334
q20	2012	1789	1769	1769
q21	4945	4690	4741	4690
q22	571	498	534	498
Total cold run time: 71479 ms
Total hot run time: 53498 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173143 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 16da2f84d046a05027e00a17883cfc71773496ae, data reload: false

query1	913	368	369	368
query2	6460	1933	1878	1878
query3	6662	215	223	215
query4	28601	17505	17375	17375
query5	4251	483	477	477
query6	286	192	165	165
query7	4599	296	284	284
query8	247	207	203	203
query9	8530	2389	2384	2384
query10	444	295	280	280
query11	11149	10088	10204	10088
query12	132	84	87	84
query13	1646	370	371	370
query14	10645	7718	8711	7718
query15	246	169	168	168
query16	7406	327	327	327
query17	1793	572	544	544
query18	1292	279	282	279
query19	207	161	158	158
query20	95	82	85	82
query21	204	134	129	129
query22	4590	4252	4079	4079
query23	34471	33154	33238	33154
query24	11896	2896	2882	2882
query25	671	394	392	392
query26	1721	150	151	150
query27	2569	276	269	269
query28	7165	2008	2008	2008
query29	949	650	622	622
query30	292	151	153	151
query31	977	743	741	741
query32	99	57	56	56
query33	797	312	315	312
query34	904	484	482	482
query35	698	604	605	604
query36	1138	937	919	919
query37	157	81	79	79
query38	2846	2742	2784	2742
query39	872	805	832	805
query40	274	127	124	124
query41	53	47	48	47
query42	125	100	108	100
query43	505	487	479	479
query44	1238	742	730	730
query45	196	162	160	160
query46	1089	719	695	695
query47	1854	1766	1774	1766
query48	373	298	290	290
query49	1123	430	425	425
query50	784	393	401	393
query51	6912	6808	6863	6808
query52	113	99	93	93
query53	374	302	301	301
query54	959	455	455	455
query55	76	76	75	75
query56	327	289	297	289
query57	1140	1089	1049	1049
query58	263	260	397	260
query59	2883	2578	2641	2578
query60	314	272	283	272
query61	99	100	95	95
query62	783	600	679	600
query63	322	299	316	299
query64	10652	2262	1706	1706
query65	3192	3096	3363	3096
query66	1081	345	345	345
query67	15684	14951	14908	14908
query68	8377	553	551	551
query69	744	447	353	353
query70	1172	1067	1141	1067
query71	537	281	271	271
query72	9241	6090	5217	5217
query73	831	326	330	326
query74	6472	5700	5714	5700
query75	5120	2710	2700	2700
query76	4861	969	929	929
query77	788	321	310	310
query78	9718	9035	10011	9035
query79	8460	543	523	523
query80	2378	489	488	488
query81	592	230	224	224
query82	695	139	132	132
query83	295	167	175	167
query84	274	85	85	85
query85	1453	316	302	302
query86	401	312	302	302
query87	3388	3122	3175	3122
query88	5078	2362	2377	2362
query89	533	385	387	385
query90	2158	197	197	197
query91	131	102	102	102
query92	65	49	50	49
query93	5759	511	506	506
query94	1481	222	215	215
query95	410	313	319	313
query96	619	272	274	272
query97	3236	3014	3004	3004
query98	215	204	205	204
query99	1668	1269	1286	1269
Total cold run time: 308558 ms
Total hot run time: 173143 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.13 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 16da2f84d046a05027e00a17883cfc71773496ae, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.04	0.05
query4	1.68	0.07	0.06
query5	0.51	0.47	0.51
query6	1.13	0.74	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.55	0.49	0.50
query10	0.53	0.55	0.55
query11	0.14	0.11	0.11
query12	0.14	0.12	0.13
query13	0.59	0.59	0.58
query14	0.76	0.78	0.77
query15	0.86	0.82	0.81
query16	0.36	0.35	0.36
query17	0.97	0.94	0.99
query18	0.22	0.23	0.22
query19	1.88	1.84	1.70
query20	0.01	0.01	0.02
query21	15.39	0.74	0.66
query22	4.04	6.82	2.41
query23	18.29	1.39	1.34
query24	2.07	0.25	0.23
query25	0.17	0.08	0.08
query26	0.29	0.22	0.21
query27	0.45	0.24	0.23
query28	13.14	1.04	1.00
query29	12.63	3.34	3.31
query30	0.27	0.07	0.05
query31	2.86	0.40	0.40
query32	3.25	0.48	0.46
query33	2.89	2.87	2.92
query34	17.10	4.35	4.41
query35	4.41	4.41	4.43
query36	0.64	0.47	0.47
query37	0.18	0.16	0.17
query38	0.16	0.14	0.16
query39	0.05	0.03	0.04
query40	0.15	0.12	0.12
query41	0.09	0.04	0.04
query42	0.06	0.05	0.05
query43	0.05	0.04	0.05
Total cold run time: 109.37 s
Total hot run time: 31.13 s

airborne12
airborne12 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qidaye qidaye merged commit a572a19 into apache:master Jul 17, 2024
27 of 30 checks passed
This was referenced Jul 17, 2024
Merged
Merged
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
@zzzxl1993 @dataroaring
[fix](inverted index) Corrected the issue of no_index_match failure c…
fb001e2 
…aused by empty data. (#37947)

1. Empty data caused no_index match_phrase_prefix to fail.
xiaokang pushed a commit that referenced this pull request Jul 18, 2024
@zzzxl1993
[fix](inverted index) Corrected the issue of no_index_match failure c…
0e248e3 
…aused by empty data #37947 (#38002)
xiaokang pushed a commit that referenced this pull request Jul 18, 2024
@zzzxl1993
[fix](inverted index) Corrected the issue of no_index_match failure c…
e41896c 
…aused by empty data #37947 (#38004)
xiaokang pushed a commit that referenced this pull request Jul 18, 2024
@zzzxl1993
[opt](inverted index) set support_phrase default true if parser is set …
3a1c8e7 
…#37947 (#38029)
@xiaokang xiaokang added the doing label Jul 24, 2024
@xiaokang xiaokang removed the doing label Jul 29, 2024
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@zzzxl1993
[fix](inverted index) Corrected the issue of no_index_match failure c…
6c77691 
…aused by empty data apache#37947 (apache#38004)
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@zzzxl1993
[opt](inverted index) set support_phrase default true if parser is set …
6be814e 
…apache#37947 (apache#38029)
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Nov 12, 2024
@zzzxl1993 @gavinchou
[fix](inverted index) Corrected the issue of no_index_match failure c…
6dc33b5 
…aused by empty data. (apache#37947)

1. Empty data caused no_index match_phrase_prefix to fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airborne12 airborne12 airborne12 approved these changes

@xiaokang xiaokang xiaokang approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.14-merged dev/2.1.5-merged dev/3.0.1-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zzzxl1993 @doris-robot @xiaokang @airborne12 @qidaye @dataroaring