Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](nereids) refine left semi/anti cost under short-cut opt #37951

Merged
merged 1 commit into from
Jul 19, 2024
Merged

[opt](nereids) refine left semi/anti cost under short-cut opt #37951

merged 1 commit into from
Jul 19, 2024

Conversation

xzj7019
Copy link
Contributor

@xzj7019 xzj7019 commented Jul 16, 2024 •
edited
Loading

Refine left semi/anti cost computing under short-cut opt, for the case whose semi/anti join has the small left side and big right side, which original solution can't support. This pr reduce the left style cost by reduce the right side cost and improve the possibility of choosing left style joins.

Pass the performance test on tpch/tpcds/usercase.

previous work: #37060

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@xzj7019
Copy link
Contributor Author

xzj7019 commented Jul 16, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 42902 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ae631cd38cf82726822f1d4cb05dcaa7121060bb, data reload: false

------ Round 1 ----------------------------------
q1	17623	4319	4310	4310
q2	2019	187	184	184
q3	10443	1253	1115	1115
q4	11053	3261	3461	3261
q5	8226	2685	2675	2675
q6	218	136	140	136
q7	956	587	602	587
q8	9419	2072	2076	2072
q9	10158	6526	6510	6510
q10	8826	3753	3754	3753
q11	448	232	230	230
q12	424	231	233	231
q13	17769	2947	2964	2947
q14	292	229	233	229
q15	522	477	495	477
q16	483	418	376	376
q17	953	672	697	672
q18	7792	7410	7337	7337
q19	3418	1472	1260	1260
q20	710	338	340	338
q21	5013	3212	3937	3212
q22	1087	990	1007	990
Total cold run time: 117852 ms
Total hot run time: 42902 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4334	4254	4326	4254
q2	382	284	285	284
q3	3162	2929	2963	2929
q4	2962	2574	2606	2574
q5	5469	5521	5581	5521
q6	223	137	138	137
q7	2225	1935	1861	1861
q8	3244	3395	3416	3395
q9	8837	8765	8625	8625
q10	4029	3905	3935	3905
q11	610	499	501	499
q12	812	674	630	630
q13	17187	3187	3127	3127
q14	301	281	282	281
q15	540	487	481	481
q16	491	451	448	448
q17	1813	1553	1510	1510
q18	8002	7885	7937	7885
q19	1709	1658	1561	1561
q20	2174	1876	1873	1873
q21	4864	4861	4852	4852
q22	1222	1017	1018	1017
Total cold run time: 74592 ms
Total hot run time: 57649 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184991 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ae631cd38cf82726822f1d4cb05dcaa7121060bb, data reload: false

query1	921	385	367	367
query2	6362	1897	1803	1803
query3	6634	211	219	211
query4	28069	17444	17327	17327
query5	3615	500	501	500
query6	272	170	167	167
query7	4578	299	301	299
query8	257	206	205	205
query9	8558	2386	2379	2379
query10	420	331	336	331
query11	10692	10008	9940	9940
query12	118	86	86	86
query13	1661	375	373	373
query14	10333	7836	7777	7777
query15	224	170	166	166
query16	7712	319	339	319
query17	1898	570	550	550
query18	1960	284	283	283
query19	202	162	159	159
query20	97	85	84	84
query21	214	152	138	138
query22	4369	4015	3976	3976
query23	34273	34109	33828	33828
query24	10771	2917	2941	2917
query25	648	430	448	430
query26	1064	160	159	159
query27	2378	293	296	293
query28	6370	2100	2062	2062
query29	904	670	667	667
query30	250	155	159	155
query31	976	775	764	764
query32	103	59	62	59
query33	782	370	349	349
query34	896	519	513	513
query35	866	770	785	770
query36	1163	985	985	985
query37	153	84	91	84
query38	3055	2869	2867	2867
query39	893	841	830	830
query40	207	213	121	121
query41	46	45	47	45
query42	126	101	100	100
query43	522	472	475	472
query44	1228	722	723	722
query45	188	161	163	161
query46	1091	735	743	735
query47	1847	1739	1770	1739
query48	366	294	295	294
query49	826	428	432	428
query50	772	387	407	387
query51	6903	6790	6788	6788
query52	101	87	93	87
query53	367	305	295	295
query54	948	442	449	442
query55	75	72	74	72
query56	297	270	274	270
query57	1127	1045	1039	1039
query58	258	262	266	262
query59	2947	2750	2696	2696
query60	305	268	281	268
query61	98	94	94	94
query62	811	646	635	635
query63	337	298	292	292
query64	9582	2241	1659	1659
query65	3181	3130	3141	3130
query66	780	333	326	326
query67	15743	14801	15007	14801
query68	8487	556	557	556
query69	510	327	368	327
query70	1406	1145	1167	1145
query71	534	282	285	282
query72	8980	5434	6209	5434
query73	2154	330	327	327
query74	6204	5734	5610	5610
query75	4905	2700	2736	2700
query76	4906	963	909	909
query77	804	314	313	313
query78	10443	13465	10548	10548
query79	7087	535	523	523
query80	854	480	482	480
query81	582	222	223	222
query82	297	128	134	128
query83	332	165	165	165
query84	275	86	84	84
query85	724	377	295	295
query86	356	304	324	304
query87	3325	3104	3109	3104
query88	3597	2364	2374	2364
query89	489	397	393	393
query90	2172	199	195	195
query91	130	102	101	101
query92	62	50	51	50
query93	1054	505	505	505
query94	1315	217	217	217
query95	11425	14425	9484	9484
query96	11776	274	269	269
query97	4832	2964	3053	2964
query98	359	197	192	192
query99	2031	1269	1287	1269
Total cold run time: 318197 ms
Total hot run time: 184991 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.05 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ae631cd38cf82726822f1d4cb05dcaa7121060bb, data reload: false

query1	0.03	0.03	0.03
query2	0.09	0.04	0.04
query3	0.22	0.06	0.05
query4	1.67	0.10	0.08
query5	0.50	0.49	0.50
query6	1.14	0.75	0.72
query7	0.02	0.02	0.01
query8	0.05	0.05	0.04
query9	0.55	0.49	0.49
query10	0.54	0.55	0.55
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.59	0.59	0.59
query14	0.77	0.76	0.79
query15	0.86	0.81	0.81
query16	0.36	0.36	0.37
query17	1.04	1.05	1.03
query18	0.22	0.22	0.22
query19	1.88	1.80	1.73
query20	0.01	0.01	0.01
query21	15.38	0.75	0.67
query22	4.13	7.34	2.26
query23	18.33	1.35	1.24
query24	2.10	0.24	0.21
query25	0.15	0.08	0.09
query26	0.31	0.22	0.20
query27	0.45	0.23	0.23
query28	13.34	1.01	0.99
query29	12.61	3.38	3.37
query30	0.25	0.06	0.05
query31	2.87	0.38	0.40
query32	3.29	0.47	0.47
query33	2.87	2.93	2.92
query34	17.30	4.30	4.39
query35	4.40	4.51	4.38
query36	0.64	0.49	0.47
query37	0.19	0.16	0.16
query38	0.16	0.15	0.15
query39	0.04	0.03	0.03
query40	0.14	0.12	0.12
query41	0.09	0.05	0.04
query42	0.05	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.97 s
Total hot run time: 31.05 s

@morrySnow
Copy link
Contributor

run feut

@xzj7019 xzj7019 marked this pull request as draft July 18, 2024 08:47
@xzj7019 xzj7019 force-pushed the refine_semi_cost branch from ae631cd to ff8e61f Compare July 18, 2024 12:46
@xzj7019 xzj7019 marked this pull request as ready for review July 18, 2024 12:47
@xzj7019 xzj7019 force-pushed the refine_semi_cost branch from ff8e61f to a37c88d Compare July 18, 2024 12:48
@xzj7019
Copy link
Contributor Author

xzj7019 commented Jul 18, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39718 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a37c88dc5eab36da5771dea45b7400b00bba7a67, data reload: false

------ Round 1 ----------------------------------
q1	17609	4438	4280	4280
q2	2014	194	185	185
q3	10457	1211	1060	1060
q4	10214	877	751	751
q5	7547	2685	2678	2678
q6	222	138	135	135
q7	960	597	602	597
q8	9222	2080	2075	2075
q9	8610	6582	6532	6532
q10	8890	3756	3728	3728
q11	454	246	250	246
q12	445	224	230	224
q13	18798	2943	2975	2943
q14	288	240	238	238
q15	523	473	494	473
q16	499	383	375	375
q17	955	678	680	678
q18	8065	7393	7413	7393
q19	7837	1379	1471	1379
q20	704	326	316	316
q21	4848	3150	3892	3150
q22	343	282	282	282
Total cold run time: 119504 ms
Total hot run time: 39718 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4405	4279	4238	4238
q2	380	278	266	266
q3	3057	2875	2934	2875
q4	1945	1812	1735	1735
q5	5536	5580	5577	5577
q6	234	138	139	138
q7	2298	1908	1852	1852
q8	3344	3462	3448	3448
q9	8714	8937	8713	8713
q10	4029	3862	3773	3773
q11	634	510	517	510
q12	824	638	640	638
q13	16969	3145	3174	3145
q14	312	272	285	272
q15	536	485	494	485
q16	477	426	439	426
q17	1800	1512	1519	1512
q18	8149	8065	7936	7936
q19	1806	1689	1585	1585
q20	2989	1885	1869	1869
q21	9573	4645	4792	4645
q22	606	525	510	510
Total cold run time: 78617 ms
Total hot run time: 56148 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174761 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a37c88dc5eab36da5771dea45b7400b00bba7a67, data reload: false

query1	917	379	364	364
query2	6377	1944	1879	1879
query3	6648	213	215	213
query4	27317	17725	17278	17278
query5	3763	475	503	475
query6	271	188	167	167
query7	4577	319	289	289
query8	252	198	193	193
query9	8732	2508	2510	2508
query10	444	285	280	280
query11	12008	10125	10014	10014
query12	114	88	83	83
query13	1648	383	376	376
query14	10175	7795	7696	7696
query15	222	169	166	166
query16	7703	271	272	271
query17	1702	540	529	529
query18	1897	278	267	267
query19	190	150	146	146
query20	86	80	80	80
query21	207	129	129	129
query22	4321	4106	3979	3979
query23	34047	33918	33652	33652
query24	10791	2911	2902	2902
query25	601	400	379	379
query26	711	148	146	146
query27	2396	277	286	277
query28	6239	2116	2116	2116
query29	893	628	643	628
query30	264	151	157	151
query31	978	747	777	747
query32	97	59	56	56
query33	663	299	294	294
query34	893	514	496	496
query35	661	564	580	564
query36	1130	985	962	962
query37	145	87	83	83
query38	2985	2873	2848	2848
query39	925	822	841	822
query40	206	120	119	119
query41	43	42	43	42
query42	118	104	97	97
query43	534	481	489	481
query44	1073	741	721	721
query45	190	158	163	158
query46	1097	719	721	719
query47	1880	1748	1791	1748
query48	364	295	297	295
query49	836	403	414	403
query50	775	389	389	389
query51	6991	6759	6742	6742
query52	104	92	90	90
query53	355	292	285	285
query54	896	452	448	448
query55	73	73	75	73
query56	289	261	281	261
query57	1161	1031	1045	1031
query58	245	241	249	241
query59	2794	2748	2701	2701
query60	296	314	279	279
query61	98	94	93	93
query62	790	647	612	612
query63	323	283	284	283
query64	9197	2201	1683	1683
query65	3174	3094	3145	3094
query66	762	323	323	323
query67	15380	15153	14817	14817
query68	5196	545	542	542
query69	636	499	378	378
query70	1194	1139	1169	1139
query71	441	292	278	278
query72	8490	5813	5966	5813
query73	766	330	325	325
query74	6100	5759	5650	5650
query75	3501	2733	2662	2662
query76	3104	964	1060	964
query77	624	301	306	301
query78	10440	9840	9845	9840
query79	2415	527	522	522
query80	933	485	466	466
query81	567	219	217	217
query82	1437	129	136	129
query83	257	161	158	158
query84	230	88	85	85
query85	1336	317	295	295
query86	460	332	322	322
query87	3279	3082	3089	3082
query88	4103	2452	2443	2443
query89	455	381	379	379
query90	1710	192	189	189
query91	129	99	101	99
query92	63	48	48	48
query93	2288	519	520	519
query94	1040	199	190	190
query95	405	332	317	317
query96	604	276	277	276
query97	3185	3012	2987	2987
query98	214	281	192	192
query99	1631	1221	1263	1221
Total cold run time: 281267 ms
Total hot run time: 174761 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.23 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a37c88dc5eab36da5771dea45b7400b00bba7a67, data reload: false

query1	0.04	0.04	0.03
query2	0.09	0.04	0.04
query3	0.22	0.04	0.04
query4	1.69	0.08	0.08
query5	0.50	0.49	0.51
query6	1.17	0.72	0.72
query7	0.02	0.02	0.01
query8	0.05	0.05	0.04
query9	0.56	0.47	0.51
query10	0.55	0.52	0.54
query11	0.15	0.12	0.12
query12	0.15	0.12	0.12
query13	0.59	0.57	0.57
query14	0.77	0.75	0.77
query15	0.85	0.80	0.81
query16	0.37	0.37	0.37
query17	0.97	1.03	1.02
query18	0.22	0.21	0.21
query19	1.84	1.83	1.69
query20	0.01	0.01	0.01
query21	15.38	0.76	0.66
query22	4.58	7.64	1.54
query23	18.29	1.30	1.29
query24	2.11	0.23	0.22
query25	0.17	0.09	0.09
query26	0.30	0.21	0.20
query27	0.45	0.23	0.24
query28	13.35	1.00	1.00
query29	12.57	3.27	3.27
query30	0.25	0.06	0.06
query31	2.88	0.39	0.39
query32	3.28	0.49	0.46
query33	2.87	2.98	2.92
query34	16.86	4.33	4.37
query35	4.42	4.42	4.47
query36	0.65	0.49	0.47
query37	0.19	0.16	0.16
query38	0.16	0.15	0.15
query39	0.04	0.04	0.03
query40	0.15	0.12	0.12
query41	0.08	0.04	0.05
query42	0.06	0.04	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.95 s
Total hot run time: 30.23 s

@xzj7019 xzj7019 force-pushed the refine_semi_cost branch from a37c88d to 3a2d785 Compare July 19, 2024 02:58
@xzj7019
Copy link
Contributor Author

xzj7019 commented Jul 19, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39875 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3a2d785033bf43f91ec38169363ec2eaea6ae5f3, data reload: false

------ Round 1 ----------------------------------
q1	17615	4356	4251	4251
q2	2009	193	184	184
q3	10451	1196	1148	1148
q4	10192	793	840	793
q5	7552	2686	2648	2648
q6	221	139	138	138
q7	953	594	606	594
q8	9213	2072	2051	2051
q9	8753	6551	6540	6540
q10	8890	3808	3789	3789
q11	455	236	242	236
q12	428	226	222	222
q13	17819	3057	2980	2980
q14	268	228	245	228
q15	531	488	484	484
q16	516	377	378	377
q17	969	646	647	646
q18	8124	7446	7357	7357
q19	6069	1361	1382	1361
q20	676	349	356	349
q21	4943	3215	3331	3215
q22	360	285	284	284
Total cold run time: 117007 ms
Total hot run time: 39875 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4332	4293	4205	4205
q2	379	272	269	269
q3	3051	2836	2870	2836
q4	2017	1753	1739	1739
q5	5642	5519	5488	5488
q6	223	137	131	131
q7	2151	1861	1848	1848
q8	3307	3412	3449	3412
q9	8809	8866	8923	8866
q10	4091	3796	3831	3796
q11	613	519	524	519
q12	836	639	663	639
q13	16029	3175	3187	3175
q14	325	295	287	287
q15	546	498	490	490
q16	513	445	445	445
q17	1840	1522	1501	1501
q18	8240	7957	7854	7854
q19	1721	1604	1472	1472
q20	2063	1855	1891	1855
q21	9026	4873	4758	4758
q22	625	524	543	524
Total cold run time: 76379 ms
Total hot run time: 56109 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173459 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3a2d785033bf43f91ec38169363ec2eaea6ae5f3, data reload: false

query1	914	366	369	366
query2	6443	1833	1826	1826
query3	6653	207	212	207
query4	28017	17356	17204	17204
query5	3766	466	473	466
query6	270	167	184	167
query7	4592	279	277	277
query8	241	186	190	186
query9	8545	2468	2433	2433
query10	437	298	282	282
query11	10777	10039	10057	10039
query12	120	86	85	85
query13	1646	380	366	366
query14	10217	7837	7037	7037
query15	232	167	170	167
query16	7734	476	479	476
query17	1590	568	534	534
query18	1716	281	278	278
query19	201	155	162	155
query20	94	86	86	86
query21	216	139	124	124
query22	4453	4011	3957	3957
query23	33929	33817	33740	33740
query24	11091	3016	2990	2990
query25	648	412	411	411
query26	1206	158	153	153
query27	2946	295	345	295
query28	7419	2070	2042	2042
query29	874	637	632	632
query30	260	157	150	150
query31	959	756	763	756
query32	95	54	55	54
query33	745	333	324	324
query34	919	491	507	491
query35	886	777	768	768
query36	1161	996	971	971
query37	146	83	82	82
query38	2964	2820	2919	2820
query39	872	797	851	797
query40	210	123	121	121
query41	44	41	42	41
query42	114	95	102	95
query43	482	470	458	458
query44	1191	730	730	730
query45	196	163	159	159
query46	1095	718	734	718
query47	1865	1767	1775	1767
query48	372	290	302	290
query49	857	413	413	413
query50	777	381	382	381
query51	6944	6841	6832	6832
query52	99	92	87	87
query53	353	297	288	288
query54	886	445	447	445
query55	75	72	75	72
query56	284	285	262	262
query57	1159	1038	1049	1038
query58	243	253	256	253
query59	2795	2523	2579	2523
query60	297	265	263	263
query61	96	95	94	94
query62	786	628	648	628
query63	316	291	292	291
query64	9452	2229	1630	1630
query65	3320	3146	3109	3109
query66	771	331	321	321
query67	15525	15104	15032	15032
query68	6097	541	540	540
query69	644	439	360	360
query70	1221	1155	1127	1127
query71	465	284	278	278
query72	7729	5490	5251	5251
query73	782	323	321	321
query74	6132	5716	5701	5701
query75	3749	2731	2757	2731
query76	3776	894	938	894
query77	667	311	305	305
query78	9988	8994	9001	8994
query79	4635	544	540	540
query80	2033	488	485	485
query81	576	225	223	223
query82	807	139	142	139
query83	229	175	172	172
query84	284	85	94	85
query85	1495	319	299	299
query86	441	339	302	302
query87	3289	3074	3106	3074
query88	4300	2391	2468	2391
query89	523	408	409	408
query90	1963	200	197	197
query91	133	100	100	100
query92	61	53	51	51
query93	4826	535	518	518
query94	1263	304	298	298
query95	415	322	321	321
query96	612	281	274	274
query97	3221	3050	3045	3045
query98	223	202	194	194
query99	1556	1306	1306	1306
Total cold run time: 290733 ms
Total hot run time: 173459 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.39 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3a2d785033bf43f91ec38169363ec2eaea6ae5f3, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.04	0.04
query3	0.22	0.06	0.06
query4	1.66	0.08	0.08
query5	0.50	0.49	0.48
query6	1.13	0.72	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.05
query9	0.55	0.49	0.50
query10	0.54	0.54	0.54
query11	0.15	0.11	0.12
query12	0.14	0.12	0.12
query13	0.59	0.59	0.58
query14	0.75	0.77	0.77
query15	0.85	0.81	0.82
query16	0.35	0.37	0.34
query17	0.98	1.04	1.00
query18	0.23	0.22	0.22
query19	1.80	1.74	1.81
query20	0.01	0.01	0.02
query21	15.42	0.76	0.67
query22	3.86	7.89	1.56
query23	18.28	1.46	1.25
query24	2.11	0.24	0.21
query25	0.15	0.09	0.09
query26	0.30	0.22	0.21
query27	0.46	0.24	0.23
query28	13.23	1.02	1.00
query29	12.60	3.41	3.40
query30	0.26	0.06	0.05
query31	2.89	0.39	0.38
query32	3.26	0.49	0.48
query33	2.91	2.92	2.96
query34	17.36	4.33	4.29
query35	4.41	4.40	4.43
query36	0.65	0.47	0.47
query37	0.18	0.15	0.16
query38	0.15	0.15	0.15
query39	0.04	0.04	0.03
query40	0.15	0.12	0.12
query41	0.09	0.04	0.05
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.49 s
Total hot run time: 30.39 s

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit e2bdb95 into apache:master Jul 19, 2024
28 of 30 checks passed
@xzj7019 xzj7019 mentioned this pull request Jul 19, 2024
Closed
@924060929 924060929 mentioned this pull request Jul 19, 2024
Merged
924060929 added a commit that referenced this pull request Jul 19, 2024
@924060929
[fix](test) fix test which conflict between #37219 and #37951 (#38157)
6eb3eac 
fix test which conflict between #37219 and #37951
dataroaring pushed a commit that referenced this pull request Jul 22, 2024
@xzj7019 @dataroaring
[opt](nereids) refine left semi/anti cost under short-cut opt (#37951)
18a69df 
Refine left semi/anti cost computing under short-cut opt, for the case
whose semi/anti join has the small left side and big right side, which
original solution can't support. This pr reduce the left style cost by
reduce the right side cost and improve the possibility of choosing left
style joins.

Pass the performance test on tpch/tpcds/usercase.

previous work: #37060
dataroaring pushed a commit that referenced this pull request Jul 22, 2024
@924060929 @dataroaring
[fix](test) fix test which conflict between #37219 and #37951 (#38157)
a1d3328 
fix test which conflict between #37219 and #37951
@LiBinfeng-01 LiBinfeng-01 mentioned this pull request Jul 22, 2024
Merged
englefly pushed a commit that referenced this pull request Jul 23, 2024
@LiBinfeng-01
[fix](cases) fix regression test (#38197)
efdfdcc 
regression test broken because of pr influence each other:
#37951 and #38081
dataroaring pushed a commit that referenced this pull request Jul 24, 2024
@LiBinfeng-01 @dataroaring
[fix](cases) fix regression test (#38197)
32216cd 
regression test broken because of pr influence each other:
#37951 and #38081
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
@xzj7019 xzj7019 mentioned this pull request Aug 20, 2024
Merged
yiguolei pushed a commit that referenced this pull request Aug 23, 2024
@xzj7019
[opt](nereids) refine left semi/anti cost under short-cut opt (#39636)
424ad23 
## Proposed changes

pick from #37951

---------

Co-authored-by: xiongzhongjian <xiongzhongjian@selectdb.com>
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow approved these changes

@englefly englefly englefly approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.1-merged p0_b reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xzj7019 @doris-robot @morrySnow @englefly @yiguolei @dataroaring