Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](function) fix coredump for MULTI_MATCH_ANY #37959

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

zclllyybb
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

fix BE crash. now get:

mysql> select MULTI_MATCH_ANY(cast('aaaaa' as STRING), cast(['aaaaa', '12345!@#$%^&*()_', '', '中文测试', '123', 'abs ss 123'] as ARRAY < STRING > ));
ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.8)[INVALID_ARGUMENT][E33] Compile regexp expression failed. got Embedded start anchors not supported.. some expressions may be illegal

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zclllyybb
Copy link
Contributor Author

run buildall

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/vec/functions/regexps.h Show resolved Hide resolved
@doris-robot
Copy link

TPC-H: Total hot run time: 40224 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cf0c7d2bf6f53d742bf02609015213409ea8649d, data reload: false

------ Round 1 ----------------------------------
q1	17624	4497	4316	4316
q2	2028	198	187	187
q3	10458	1245	1093	1093
q4	10190	775	884	775
q5	7528	2779	2706	2706
q6	229	138	140	138
q7	966	600	603	600
q8	9222	2096	2136	2096
q9	8653	6572	6595	6572
q10	8920	3785	3794	3785
q11	455	238	255	238
q12	397	232	228	228
q13	17946	3068	3017	3017
q14	275	242	238	238
q15	546	475	502	475
q16	503	387	386	386
q17	965	666	696	666
q18	8264	7586	7517	7517
q19	9044	1371	1451	1371
q20	744	325	340	325
q21	4822	3248	3218	3218
q22	355	283	277	277
Total cold run time: 120134 ms
Total hot run time: 40224 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4441	4273	4221	4221
q2	378	265	268	265
q3	3154	2958	2964	2958
q4	2065	1728	1702	1702
q5	5553	5488	5572	5488
q6	231	134	135	134
q7	2275	1885	1812	1812
q8	3310	3444	3429	3429
q9	8790	8951	8785	8785
q10	4066	3873	3909	3873
q11	601	502	502	502
q12	789	632	642	632
q13	17322	3151	3244	3151
q14	318	295	279	279
q15	536	509	501	501
q16	492	418	444	418
q17	1834	1559	1507	1507
q18	7989	7900	7845	7845
q19	1783	1677	1583	1583
q20	2159	1856	1882	1856
q21	5122	4780	4864	4780
q22	575	544	512	512
Total cold run time: 73783 ms
Total hot run time: 56233 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174415 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cf0c7d2bf6f53d742bf02609015213409ea8649d, data reload: false

query1	922	378	374	374
query2	6425	1957	1868	1868
query3	6592	214	221	214
query4	28521	17747	17160	17160
query5	3775	510	487	487
query6	262	188	185	185
query7	4589	296	285	285
query8	248	193	184	184
query9	8529	2399	2378	2378
query10	457	283	268	268
query11	12736	10020	10183	10020
query12	114	93	84	84
query13	1627	377	353	353
query14	10335	7905	7670	7670
query15	211	169	190	169
query16	7705	327	315	315
query17	1593	557	522	522
query18	1812	276	282	276
query19	201	151	149	149
query20	86	82	87	82
query21	208	127	123	123
query22	4231	4192	4123	4123
query23	34381	33907	33932	33907
query24	11148	2940	2970	2940
query25	650	421	428	421
query26	1427	160	155	155
query27	2964	307	291	291
query28	7541	2066	2081	2066
query29	996	678	691	678
query30	263	173	158	158
query31	970	759	784	759
query32	101	60	56	56
query33	746	314	300	300
query34	999	505	510	505
query35	715	587	592	587
query36	1174	1013	985	985
query37	162	84	87	84
query38	2969	2862	2843	2843
query39	919	836	816	816
query40	268	126	122	122
query41	51	45	45	45
query42	130	104	105	104
query43	510	476	476	476
query44	1209	738	719	719
query45	202	162	165	162
query46	1092	749	724	724
query47	1854	1771	1806	1771
query48	365	289	287	287
query49	850	416	421	416
query50	780	396	401	396
query51	6974	6941	6846	6846
query52	102	95	94	94
query53	360	291	295	291
query54	888	500	444	444
query55	77	76	74	74
query56	291	268	287	268
query57	1134	1041	1042	1041
query58	261	247	253	247
query59	3044	2601	2578	2578
query60	307	281	299	281
query61	99	96	99	96
query62	798	645	654	645
query63	317	292	295	292
query64	10456	2245	1680	1680
query65	3200	3155	3121	3121
query66	1043	327	334	327
query67	15440	15309	15071	15071
query68	6180	546	541	541
query69	639	419	373	373
query70	1210	1099	1171	1099
query71	452	281	277	277
query72	7264	6130	5413	5413
query73	787	335	331	331
query74	6287	5729	5663	5663
query75	3604	2706	2710	2706
query76	3368	1018	920	920
query77	666	328	312	312
query78	11398	10428	9071	9071
query79	6603	531	526	526
query80	980	509	500	500
query81	571	221	222	221
query82	488	146	140	140
query83	202	177	176	176
query84	269	87	94	87
query85	1022	314	314	314
query86	457	317	283	283
query87	3316	3098	3145	3098
query88	4684	2386	2384	2384
query89	479	391	394	391
query90	1868	192	194	192
query91	134	103	102	102
query92	63	50	52	50
query93	3456	517	501	501
query94	1204	209	230	209
query95	411	318	322	318
query96	619	282	273	273
query97	3204	3046	3030	3030
query98	229	205	193	193
query99	1676	1270	1263	1263
Total cold run time: 295196 ms
Total hot run time: 174415 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.51 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cf0c7d2bf6f53d742bf02609015213409ea8649d, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.04	0.04
query3	0.22	0.04	0.05
query4	1.68	0.07	0.06
query5	0.49	0.48	0.48
query6	1.14	0.73	0.72
query7	0.02	0.02	0.01
query8	0.05	0.04	0.05
query9	0.56	0.48	0.49
query10	0.54	0.55	0.54
query11	0.17	0.11	0.11
query12	0.15	0.12	0.12
query13	0.60	0.59	0.59
query14	0.77	0.76	0.78
query15	0.86	0.81	0.82
query16	0.37	0.36	0.37
query17	1.05	1.04	1.04
query18	0.23	0.23	0.23
query19	1.89	1.80	1.67
query20	0.01	0.01	0.01
query21	15.39	0.74	0.64
query22	3.91	6.32	2.82
query23	18.30	1.36	1.31
query24	2.07	0.23	0.23
query25	0.16	0.08	0.08
query26	0.30	0.21	0.22
query27	0.46	0.23	0.23
query28	13.35	1.04	1.01
query29	12.68	3.33	3.29
query30	0.25	0.07	0.05
query31	2.86	0.39	0.39
query32	3.26	0.50	0.47
query33	2.91	2.84	2.98
query34	16.62	4.36	4.36
query35	4.45	4.40	4.38
query36	0.66	0.47	0.46
query37	0.19	0.15	0.15
query38	0.15	0.15	0.14
query39	0.04	0.04	0.04
query40	0.16	0.12	0.12
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.28 s
Total hot run time: 31.51 s

Copy link
Contributor

PR approved by anyone and no changes requested.

@zclllyybb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40281 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 08cc487e6c16364d4432d9e504c853fd0470ba53, data reload: false

------ Round 1 ----------------------------------
q1	17813	4506	4416	4416
q2	2646	196	190	190
q3	10913	1223	1145	1145
q4	11014	878	917	878
q5	7892	2660	2659	2659
q6	229	142	137	137
q7	990	612	615	612
q8	9323	2096	2106	2096
q9	8605	6541	6561	6541
q10	8648	3794	3766	3766
q11	471	257	236	236
q12	398	230	222	222
q13	17884	2988	2962	2962
q14	282	230	235	230
q15	526	482	496	482
q16	497	375	381	375
q17	956	651	688	651
q18	8179	7514	7437	7437
q19	5706	1421	1423	1421
q20	678	321	321	321
q21	4944	3216	3284	3216
q22	346	297	288	288
Total cold run time: 118940 ms
Total hot run time: 40281 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4376	4247	4215	4215
q2	371	275	273	273
q3	3045	2753	2864	2753
q4	1975	1707	1728	1707
q5	5587	5564	5555	5555
q6	232	134	129	129
q7	2212	1864	1862	1862
q8	3303	3311	3343	3311
q9	8764	8754	8734	8734
q10	4080	3835	3888	3835
q11	609	487	484	484
q12	813	634	668	634
q13	17573	2983	3079	2983
q14	322	301	277	277
q15	529	480	496	480
q16	478	428	450	428
q17	1841	1524	1507	1507
q18	8014	7529	7349	7349
q19	1687	1587	1465	1465
q20	2184	1782	1785	1782
q21	10784	4563	4538	4538
q22	570	529	505	505
Total cold run time: 79349 ms
Total hot run time: 54806 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172353 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 08cc487e6c16364d4432d9e504c853fd0470ba53, data reload: false

query1	918	374	365	365
query2	6439	1943	1867	1867
query3	6670	203	218	203
query4	28730	17398	17300	17300
query5	4203	502	474	474
query6	268	168	169	168
query7	4592	292	287	287
query8	236	205	197	197
query9	8519	2509	2486	2486
query10	447	281	277	277
query11	10615	10159	10058	10058
query12	136	83	81	81
query13	1649	378	370	370
query14	10336	7305	7741	7305
query15	222	165	163	163
query16	7758	337	329	329
query17	1745	555	544	544
query18	1822	283	285	283
query19	196	163	159	159
query20	88	85	84	84
query21	212	131	129	129
query22	4381	4036	3992	3992
query23	33986	33070	33457	33070
query24	11824	2955	2877	2877
query25	670	389	397	389
query26	1784	152	151	151
query27	2958	274	281	274
query28	7151	2040	2031	2031
query29	1113	634	621	621
query30	287	150	148	148
query31	959	752	761	752
query32	97	54	56	54
query33	767	323	304	304
query34	922	486	489	486
query35	705	589	594	589
query36	1138	951	930	930
query37	275	85	84	84
query38	2864	2739	2708	2708
query39	920	807	836	807
query40	281	125	127	125
query41	50	49	48	48
query42	115	99	104	99
query43	522	489	478	478
query44	1204	730	736	730
query45	193	166	162	162
query46	1125	767	748	748
query47	1819	1749	1795	1749
query48	375	302	295	295
query49	1204	420	426	420
query50	790	400	405	400
query51	6884	6837	6806	6806
query52	106	99	90	90
query53	376	293	290	290
query54	910	468	468	468
query55	80	73	77	73
query56	308	299	293	293
query57	1184	1051	1019	1019
query58	266	268	386	268
query59	2881	2736	2705	2705
query60	305	282	268	268
query61	95	93	107	93
query62	832	624	618	618
query63	321	304	286	286
query64	10516	2210	1650	1650
query65	3207	3096	3092	3092
query66	1327	334	335	334
query67	15600	14955	14800	14800
query68	9283	563	566	563
query69	710	414	340	340
query70	1313	1026	1141	1026
query71	555	284	278	278
query72	8149	5425	5470	5425
query73	2197	329	330	329
query74	6167	5717	5579	5579
query75	5539	2678	2671	2671
query76	5311	897	865	865
query77	784	309	299	299
query78	10372	8975	8920	8920
query79	12030	537	518	518
query80	1267	485	476	476
query81	580	216	221	216
query82	516	131	131	131
query83	326	161	165	161
query84	271	87	86	86
query85	1054	304	290	290
query86	365	284	290	284
query87	3352	3184	3132	3132
query88	4500	2460	2470	2460
query89	549	391	383	383
query90	2117	191	191	191
query91	127	100	100	100
query92	63	51	51	51
query93	6786	525	519	519
query94	1414	217	214	214
query95	412	323	320	320
query96	610	274	275	274
query97	3156	3000	3017	3000
query98	224	201	200	200
query99	1582	1249	1265	1249
Total cold run time: 313159 ms
Total hot run time: 172353 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.72 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 08cc487e6c16364d4432d9e504c853fd0470ba53, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.24	0.05	0.05
query4	1.67	0.08	0.07
query5	0.50	0.47	0.50
query6	1.14	0.73	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.56	0.50	0.48
query10	0.55	0.55	0.54
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.59	0.59	0.58
query14	0.75	0.78	0.80
query15	0.86	0.80	0.81
query16	0.35	0.37	0.36
query17	1.03	1.01	1.04
query18	0.22	0.21	0.22
query19	1.91	1.79	1.84
query20	0.02	0.01	0.01
query21	15.50	0.76	0.65
query22	4.38	6.91	1.89
query23	18.29	1.34	1.31
query24	2.16	0.24	0.21
query25	0.16	0.09	0.08
query26	0.31	0.22	0.21
query27	0.46	0.23	0.23
query28	13.20	1.02	1.01
query29	12.67	3.30	3.34
query30	0.26	0.06	0.05
query31	2.84	0.38	0.38
query32	3.26	0.48	0.46
query33	2.93	2.89	2.88
query34	17.22	4.36	4.36
query35	4.42	4.45	4.46
query36	0.64	0.46	0.47
query37	0.19	0.15	0.16
query38	0.15	0.14	0.15
query39	0.04	0.04	0.03
query40	0.16	0.12	0.14
query41	0.10	0.05	0.04
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.34 s
Total hot run time: 30.72 s

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 19, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@HappenLee HappenLee merged commit d10a3dc into apache:master Jul 23, 2024
25 of 27 checks passed
zclllyybb added a commit to zclllyybb/doris that referenced this pull request Jul 24, 2024
[INVALID_ARGUMENT][E33] Compile regexp expression failed. got Embedded start anchors not supported.. some expressions may be illegal
zclllyybb added a commit to zclllyybb/doris that referenced this pull request Jul 24, 2024
[INVALID_ARGUMENT][E33] Compile regexp expression failed. got Embedded start anchors not supported.. some expressions may be illegal
dataroaring pushed a commit that referenced this pull request Jul 24, 2024
[INVALID_ARGUMENT][E33] Compile regexp expression failed. got Embedded start anchors not supported.. some expressions may be illegal
yiguolei pushed a commit that referenced this pull request Jul 25, 2024
)

pick #37959

[INVALID_ARGUMENT][E33] Compile regexp expression failed. got Embedded
start anchors not supported.. some expressions may be illegal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants