Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](profile) Task state of query profile is not set correctly #38082

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

zhiqiang-hhhh
Copy link
Contributor

Task state in connection context will only be updated after profile is updated. So task state of profile should be set to query state of coordinator.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39767 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 80939b9234c982ca43f3eca770f62232481d2b7c, data reload: false

------ Round 1 ----------------------------------
q1	18677	4483	4348	4348
q2	3223	198	192	192
q3	10979	1182	1110	1110
q4	10671	893	816	816
q5	8553	2812	2669	2669
q6	220	138	135	135
q7	959	604	606	604
q8	9208	2078	2077	2077
q9	8861	6527	6568	6527
q10	8772	3735	3752	3735
q11	461	244	239	239
q12	402	224	217	217
q13	18973	2948	2940	2940
q14	275	235	234	234
q15	539	483	495	483
q16	508	386	373	373
q17	967	734	675	675
q18	8204	7548	7396	7396
q19	5412	1335	1422	1335
q20	706	319	341	319
q21	4800	3059	3307	3059
q22	349	288	284	284
Total cold run time: 121719 ms
Total hot run time: 39767 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4394	4225	4224	4224
q2	364	274	254	254
q3	3048	2762	2735	2735
q4	1888	1620	1602	1602
q5	5297	5292	5297	5292
q6	222	132	132	132
q7	2064	1762	1697	1697
q8	3221	3345	3298	3298
q9	8409	8403	8339	8339
q10	3913	3716	3697	3697
q11	557	493	490	490
q12	796	599	618	599
q13	16286	2951	2988	2951
q14	303	267	283	267
q15	518	474	476	474
q16	479	418	416	416
q17	1755	1517	1467	1467
q18	7734	7593	7336	7336
q19	4184	1559	1637	1559
q20	1990	1782	1739	1739
q21	5031	4674	4721	4674
q22	577	482	492	482
Total cold run time: 73030 ms
Total hot run time: 53724 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173228 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 80939b9234c982ca43f3eca770f62232481d2b7c, data reload: false

query1	910	372	368	368
query2	6459	1935	1876	1876
query3	6684	206	221	206
query4	26061	17470	17396	17396
query5	4205	487	482	482
query6	275	163	162	162
query7	4596	299	286	286
query8	234	195	197	195
query9	8569	2522	2503	2503
query10	439	284	272	272
query11	10678	10009	10217	10009
query12	133	85	81	81
query13	1650	367	376	367
query14	10325	7843	7461	7461
query15	227	171	172	171
query16	7634	330	322	322
query17	1771	579	538	538
query18	1907	288	283	283
query19	197	158	155	155
query20	94	85	79	79
query21	220	127	130	127
query22	4486	4220	4120	4120
query23	34055	33189	33232	33189
query24	11901	2878	2813	2813
query25	687	394	393	393
query26	1753	153	149	149
query27	2963	275	277	275
query28	7342	2063	2051	2051
query29	1099	662	635	635
query30	286	153	150	150
query31	966	726	750	726
query32	97	53	59	53
query33	800	318	308	308
query34	936	479	510	479
query35	706	609	582	582
query36	1110	936	939	936
query37	265	88	83	83
query38	2856	2755	2777	2755
query39	873	820	810	810
query40	282	123	126	123
query41	49	47	48	47
query42	124	100	102	100
query43	506	470	475	470
query44	1186	832	737	737
query45	201	158	165	158
query46	1093	723	722	722
query47	1840	1796	1757	1757
query48	377	306	310	306
query49	1177	407	424	407
query50	777	406	402	402
query51	6819	6778	6664	6664
query52	99	92	89	89
query53	354	289	291	289
query54	1060	455	456	455
query55	74	78	73	73
query56	291	268	275	268
query57	1137	1087	1074	1074
query58	253	241	244	241
query59	2824	2595	2813	2595
query60	295	275	276	275
query61	113	95	98	95
query62	834	636	659	636
query63	326	282	283	282
query64	10487	2223	1682	1682
query65	3229	3096	3117	3096
query66	1374	326	329	326
query67	15772	15011	15068	15011
query68	4732	546	546	546
query69	696	422	356	356
query70	1191	1114	1163	1114
query71	451	278	282	278
query72	8692	5650	5656	5650
query73	757	325	326	325
query74	6068	5655	5686	5655
query75	4450	2662	2640	2640
query76	3386	920	890	890
query77	726	305	300	300
query78	10669	9058	8947	8947
query79	7436	530	530	530
query80	1148	483	480	480
query81	587	226	227	226
query82	978	139	136	136
query83	396	167	167	167
query84	280	89	84	84
query85	1559	361	301	301
query86	458	326	293	293
query87	3308	3177	3101	3101
query88	4747	2494	2455	2455
query89	501	383	379	379
query90	2027	197	201	197
query91	132	101	101	101
query92	66	49	49	49
query93	5324	520	520	520
query94	1389	215	215	215
query95	416	323	327	323
query96	615	274	274	274
query97	3240	3012	3090	3012
query98	218	196	187	187
query99	1576	1271	1274	1271
Total cold run time: 297621 ms
Total hot run time: 173228 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.95 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 80939b9234c982ca43f3eca770f62232481d2b7c, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.04	0.04
query3	0.23	0.05	0.04
query4	1.67	0.06	0.07
query5	0.50	0.49	0.49
query6	1.15	0.72	0.71
query7	0.03	0.01	0.01
query8	0.05	0.04	0.04
query9	0.55	0.49	0.48
query10	0.53	0.54	0.53
query11	0.15	0.12	0.11
query12	0.14	0.11	0.12
query13	0.60	0.58	0.58
query14	0.76	0.77	0.78
query15	0.84	0.81	0.82
query16	0.34	0.36	0.35
query17	0.95	0.96	0.95
query18	0.23	0.22	0.22
query19	1.80	1.67	1.67
query20	0.01	0.01	0.01
query21	15.39	0.78	0.65
query22	3.70	6.75	2.49
query23	18.28	1.34	1.26
query24	2.12	0.22	0.21
query25	0.16	0.09	0.09
query26	0.29	0.21	0.20
query27	0.46	0.23	0.23
query28	13.33	1.01	0.98
query29	12.58	3.40	3.31
query30	0.25	0.06	0.05
query31	2.90	0.39	0.39
query32	3.24	0.47	0.47
query33	2.89	2.98	2.88
query34	17.12	4.35	4.32
query35	4.44	4.41	4.39
query36	0.66	0.45	0.46
query37	0.18	0.16	0.15
query38	0.15	0.14	0.14
query39	0.04	0.04	0.03
query40	0.15	0.12	0.13
query41	0.09	0.06	0.05
query42	0.06	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.16 s
Total hot run time: 30.95 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 22, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HappenLee HappenLee merged commit 912a238 into apache:master Jul 23, 2024
27 of 29 checks passed
@zhiqiang-hhhh zhiqiang-hhhh deleted the fix-profile-task-state branch July 23, 2024 07:48
dataroaring pushed a commit that referenced this pull request Jul 24, 2024
Task state in connection context will only be updated after profile is
updated. So task state of profile should be set to query state of coordinator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.1-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants