Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](compatibility) fill schema and table name in protocol column def #38126

Merged
merged 1 commit into from
Jul 23, 2024
Merged

[opt](compatibility) fill schema and table name in protocol column def #38126

merged 1 commit into from
Jul 23, 2024

Conversation

morrySnow
Copy link
Contributor

according to mysql text protocol Protocol::ColumnDefinition41, should fill schema name, table name into it if column from table.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow morrySnow added the area/mysql-compatibility Issues or PRs related to the mysql compatibility label Jul 19, 2024
@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow
Copy link
Contributor Author

run performance

@doris-robot
Copy link

TPC-H: Total hot run time: 39858 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 362feb15f9bedff9f78d2ded917900b70a369933, data reload: false

------ Round 1 ----------------------------------
q1	17894	4436	4370	4370
q2	2535	195	191	191
q3	11416	1287	1091	1091
q4	10537	810	800	800
q5	7899	2745	2710	2710
q6	227	144	138	138
q7	970	638	622	622
q8	9580	2099	2042	2042
q9	8823	6532	6563	6532
q10	8730	3758	3738	3738
q11	463	230	239	230
q12	407	226	226	226
q13	17760	2980	2960	2960
q14	282	238	233	233
q15	529	468	508	468
q16	489	386	375	375
q17	971	679	657	657
q18	7996	7633	7431	7431
q19	1796	1396	1311	1311
q20	702	313	313	313
q21	4986	3142	3250	3142
q22	337	278	279	278
Total cold run time: 115329 ms
Total hot run time: 39858 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4310	4284	4261	4261
q2	378	261	274	261
q3	2960	2802	2730	2730
q4	1816	1585	1609	1585
q5	5276	5295	5307	5295
q6	216	130	131	130
q7	2106	1774	1693	1693
q8	3179	3362	3276	3276
q9	8317	8377	8357	8357
q10	3900	3696	3669	3669
q11	585	488	480	480
q12	778	605	588	588
q13	16478	2967	3010	2967
q14	301	273	285	273
q15	516	469	470	469
q16	475	413	410	410
q17	1751	1463	1445	1445
q18	7717	7519	7444	7444
q19	2570	1653	1548	1548
q20	1986	1791	1758	1758
q21	4972	4647	4765	4647
q22	582	501	476	476
Total cold run time: 71169 ms
Total hot run time: 53762 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173481 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 362feb15f9bedff9f78d2ded917900b70a369933, data reload: false

query1	912	364	367	364
query2	6451	1841	1762	1762
query3	6669	205	217	205
query4	28315	17350	17185	17185
query5	4204	487	478	478
query6	254	179	166	166
query7	4593	293	284	284
query8	240	196	191	191
query9	8537	2397	2391	2391
query10	445	281	276	276
query11	10601	10138	10125	10125
query12	132	87	83	83
query13	1635	374	370	370
query14	10233	7558	7476	7476
query15	228	165	162	162
query16	7823	522	464	464
query17	1586	576	543	543
query18	1975	284	291	284
query19	205	153	152	152
query20	89	82	81	81
query21	208	134	132	132
query22	4442	4122	4068	4068
query23	33813	33248	33119	33119
query24	12107	2915	2892	2892
query25	682	397	396	396
query26	1815	150	159	150
query27	2933	273	275	273
query28	7717	2001	1988	1988
query29	1158	648	626	626
query30	286	149	145	145
query31	943	736	742	736
query32	99	57	57	57
query33	775	341	350	341
query34	882	475	566	475
query35	847	721	695	695
query36	1104	945	939	939
query37	284	82	76	76
query38	2834	2755	2716	2716
query39	897	800	813	800
query40	280	119	119	119
query41	47	43	44	43
query42	112	97	96	96
query43	508	453	446	446
query44	1223	718	730	718
query45	196	159	157	157
query46	1083	697	719	697
query47	1861	1782	1771	1771
query48	365	282	283	282
query49	1180	413	423	413
query50	798	398	399	398
query51	6944	6972	6721	6721
query52	98	96	91	91
query53	346	289	285	285
query54	910	443	449	443
query55	76	72	73	72
query56	293	269	274	269
query57	1190	1059	1069	1059
query58	262	245	243	243
query59	2861	2580	2596	2580
query60	307	269	276	269
query61	97	97	94	94
query62	850	657	673	657
query63	321	296	288	288
query64	10421	2245	1624	1624
query65	3175	3130	3084	3084
query66	1391	338	326	326
query67	15630	15197	15000	15000
query68	6299	540	542	540
query69	654	433	374	374
query70	1212	1161	1169	1161
query71	485	282	282	282
query72	8343	5621	6030	5621
query73	787	333	331	331
query74	6125	5623	5711	5623
query75	4430	2705	2698	2698
query76	3909	858	855	855
query77	675	309	297	297
query78	11349	9690	10026	9690
query79	5107	506	529	506
query80	1245	479	476	476
query81	597	217	221	217
query82	1117	134	137	134
query83	370	173	168	168
query84	278	92	93	92
query85	889	298	294	294
query86	528	337	284	284
query87	3290	3147	3100	3100
query88	4676	2367	2404	2367
query89	494	374	381	374
query90	1969	193	201	193
query91	129	100	101	100
query92	67	48	49	48
query93	4043	511	510	510
query94	1225	265	277	265
query95	407	317	324	317
query96	612	269	270	269
query97	3173	2980	3004	2980
query98	210	196	194	194
query99	1582	1232	1210	1210
Total cold run time: 298054 ms
Total hot run time: 173481 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.62 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 362feb15f9bedff9f78d2ded917900b70a369933, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.22	0.05	0.05
query4	1.67	0.07	0.08
query5	0.48	0.48	0.48
query6	1.14	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.05	0.04
query9	0.54	0.47	0.49
query10	0.54	0.54	0.55
query11	0.16	0.12	0.12
query12	0.15	0.13	0.13
query13	0.60	0.59	0.59
query14	0.77	0.80	0.79
query15	0.87	0.82	0.82
query16	0.37	0.37	0.38
query17	0.98	0.95	1.00
query18	0.24	0.23	0.22
query19	1.85	1.75	1.82
query20	0.02	0.01	0.01
query21	15.40	0.74	0.65
query22	3.98	7.48	1.87
query23	18.27	1.47	1.28
query24	2.12	0.24	0.23
query25	0.16	0.08	0.08
query26	0.31	0.21	0.21
query27	0.45	0.23	0.23
query28	13.23	1.02	1.00
query29	12.63	3.30	3.27
query30	0.26	0.06	0.05
query31	2.88	0.39	0.39
query32	3.27	0.49	0.47
query33	2.94	2.94	2.92
query34	17.05	4.34	4.37
query35	4.45	4.36	4.40
query36	0.66	0.50	0.48
query37	0.19	0.15	0.16
query38	0.16	0.15	0.15
query39	0.04	0.03	0.03
query40	0.16	0.12	0.12
query41	0.09	0.05	0.05
query42	0.06	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.58 s
Total hot run time: 30.62 s

@morrySnow
Copy link
Contributor Author

run p0

starocean999
starocean999 previously approved these changes Jul 22, 2024
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow
[opt](compatibility) fill schema and table name in protocol column def
41a9a13 
according to mysql text protocol Protocol::ColumnDefinition41,
should fill schema name, table name into it if column from table.
@morrySnow morrySnow force-pushed the fill_field_qualifier branch from 362feb1 to 41a9a13 Compare July 22, 2024 10:28
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 22, 2024
@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40188 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 41a9a134bf0d51888667a1142a26ed63b66ad7bb, data reload: false

------ Round 1 ----------------------------------
q1	18167	4427	4364	4364
q2	2523	200	204	200
q3	11308	1207	1134	1134
q4	10353	852	800	800
q5	7712	2734	2774	2734
q6	234	140	142	140
q7	978	629	621	621
q8	9249	2070	2056	2056
q9	8698	6515	6509	6509
q10	8785	3784	3757	3757
q11	479	239	240	239
q12	397	223	229	223
q13	17772	2997	2983	2983
q14	288	238	237	237
q15	518	474	484	474
q16	494	402	371	371
q17	955	654	662	654
q18	8036	7601	7532	7532
q19	7548	1478	1460	1460
q20	700	337	328	328
q21	4918	3082	3184	3082
q22	352	291	290	290
Total cold run time: 120464 ms
Total hot run time: 40188 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4337	4241	4266	4241
q2	373	270	278	270
q3	3036	2783	2738	2738
q4	1908	1623	1639	1623
q5	5275	5292	5288	5288
q6	222	130	132	130
q7	2140	1758	1666	1666
q8	3197	3317	3271	3271
q9	8432	8400	8388	8388
q10	3945	3763	3672	3672
q11	597	478	516	478
q12	783	578	604	578
q13	16335	2959	2988	2959
q14	300	274	275	274
q15	508	466	467	466
q16	465	437	440	437
q17	1761	1494	1465	1465
q18	7484	7528	7460	7460
q19	1698	1561	1453	1453
q20	1980	1801	1787	1787
q21	4924	4766	4854	4766
q22	572	493	481	481
Total cold run time: 70272 ms
Total hot run time: 53891 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173240 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 41a9a134bf0d51888667a1142a26ed63b66ad7bb, data reload: false

query1	912	366	367	366
query2	6446	2055	1920	1920
query3	6653	211	217	211
query4	28160	17652	17398	17398
query5	4214	479	477	477
query6	269	183	198	183
query7	4599	298	307	298
query8	234	198	193	193
query9	8428	2466	2439	2439
query10	439	267	275	267
query11	12073	10151	10004	10004
query12	137	84	82	82
query13	1647	363	359	359
query14	9570	7617	7561	7561
query15	216	166	166	166
query16	7661	517	457	457
query17	1315	570	525	525
query18	1983	270	275	270
query19	197	156	151	151
query20	89	87	84	84
query21	202	125	127	125
query22	4234	3978	4071	3978
query23	33932	33081	33348	33081
query24	11235	2923	2933	2923
query25	658	372	371	371
query26	1395	151	157	151
query27	2931	267	273	267
query28	7573	1980	1960	1960
query29	968	617	609	609
query30	279	148	149	148
query31	944	737	734	734
query32	91	52	56	52
query33	774	338	328	328
query34	888	481	480	480
query35	870	786	766	766
query36	1096	947	929	929
query37	153	83	82	82
query38	2881	2752	2769	2752
query39	866	807	819	807
query40	270	122	121	121
query41	47	46	44	44
query42	116	97	102	97
query43	499	481	475	475
query44	1268	706	712	706
query45	189	162	164	162
query46	1086	709	732	709
query47	1859	1783	1772	1772
query48	371	298	294	294
query49	1093	414	410	410
query50	788	398	400	398
query51	6742	6622	6707	6622
query52	109	89	94	89
query53	355	283	293	283
query54	979	448	461	448
query55	80	79	73	73
query56	288	259	278	259
query57	1173	1050	1077	1050
query58	261	273	300	273
query59	2927	2848	2673	2673
query60	298	268	286	268
query61	95	109	94	94
query62	843	655	660	655
query63	322	290	283	283
query64	10569	2242	1689	1689
query65	3183	3110	3094	3094
query66	1406	334	347	334
query67	15323	15154	14838	14838
query68	4612	532	549	532
query69	569	403	355	355
query70	1116	1136	1110	1110
query71	397	275	292	275
query72	7100	5565	5677	5565
query73	756	324	334	324
query74	6402	5692	5640	5640
query75	3394	2712	2684	2684
query76	2492	949	909	909
query77	655	317	304	304
query78	9572	8978	8902	8902
query79	2323	530	526	526
query80	1976	494	481	481
query81	600	219	221	219
query82	840	140	149	140
query83	280	167	168	167
query84	261	96	105	96
query85	2029	391	360	360
query86	497	309	319	309
query87	3270	3112	3139	3112
query88	4361	2486	2472	2472
query89	476	389	379	379
query90	1825	203	202	202
query91	145	118	117	117
query92	66	56	53	53
query93	2723	509	502	502
query94	1254	302	276	276
query95	423	334	350	334
query96	609	277	274	274
query97	3166	2998	2995	2995
query98	224	206	203	203
query99	1705	1269	1256	1256
Total cold run time: 285869 ms
Total hot run time: 173240 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.95 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 41a9a134bf0d51888667a1142a26ed63b66ad7bb, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.69	0.07	0.07
query5	0.50	0.49	0.48
query6	1.13	0.72	0.74
query7	0.02	0.01	0.01
query8	0.06	0.05	0.04
query9	0.55	0.49	0.48
query10	0.54	0.53	0.55
query11	0.16	0.11	0.11
query12	0.14	0.12	0.13
query13	0.60	0.59	0.58
query14	0.75	0.78	0.78
query15	0.85	0.82	0.81
query16	0.36	0.36	0.36
query17	0.99	1.00	1.01
query18	0.23	0.22	0.22
query19	1.82	1.70	1.70
query20	0.01	0.01	0.01
query21	15.42	0.78	0.66
query22	3.86	7.22	2.19
query23	18.24	1.45	1.26
query24	2.21	0.22	0.21
query25	0.16	0.09	0.08
query26	0.29	0.21	0.22
query27	0.45	0.22	0.23
query28	13.20	1.03	1.00
query29	12.59	3.33	3.34
query30	0.25	0.06	0.06
query31	2.85	0.39	0.38
query32	3.29	0.48	0.47
query33	2.95	2.87	2.94
query34	17.16	4.43	4.35
query35	4.50	4.46	4.46
query36	0.65	0.46	0.47
query37	0.20	0.15	0.15
query38	0.16	0.14	0.15
query39	0.04	0.04	0.04
query40	0.14	0.12	0.12
query41	0.10	0.05	0.05
query42	0.05	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.54 s
Total hot run time: 30.95 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@morrySnow morrySnow merged commit 355ffa5 into apache:master Jul 23, 2024
28 of 30 checks passed
@morrySnow morrySnow deleted the fill_field_qualifier branch July 23, 2024 06:26
dataroaring pushed a commit that referenced this pull request Jul 24, 2024
@morrySnow @dataroaring
[opt](compatibility) fill schema and table name in protocol column def (
1625eb1 
#38126)

according to mysql text protocol Protocol::ColumnDefinition41, should
fill schema name, table name into it if column from table.
morrySnow added a commit that referenced this pull request Jul 30, 2024
@morrySnow
[opt](compatibility) fill schema and table name in protocol column def (
0d314af 
#38126)

pick from master #38126

according to mysql text protocol Protocol::ColumnDefinition41, should
fill schema name, table name into it if column from table.
@morrySnow morrySnow mentioned this pull request Jul 30, 2024
Merged
@wm1581066 wm1581066 added the usercase Important user case type label label Jul 30, 2024
morrySnow added a commit that referenced this pull request Jul 30, 2024
@morrySnow
[opt](compatibility) fill schema and table name in protocol column def (
e25eb73 
#38126) (#38522)

pick from master #38126

according to mysql text protocol Protocol::ColumnDefinition41, should
fill schema name, table name into it if column from table.
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starocean999 starocean999 starocean999 approved these changes

@924060929 924060929 924060929 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. area/mysql-compatibility Issues or PRs related to the mysql compatibility dev/2.1.6-merged dev/3.0.1-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@morrySnow @doris-robot @924060929 @starocean999 @wm1581066 @dataroaring