Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug](agg) fix collect_set function core dump without arena pool #38234

Merged
merged 1 commit into from
Jul 24, 2024
Merged

[Bug](agg) fix collect_set function core dump without arena pool #38234

merged 1 commit into from
Jul 24, 2024

Conversation

zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Jul 23, 2024 •
edited
Loading

Proposed changes

before the add_range_single_place pass nullptr as arena object,
but collect_set function need save data in arena, so will core dump without arena pool.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhangstar333
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39661 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 24bd152dc0e4e4ebe9d50b84f6c941bc36092fa3, data reload: false

------ Round 1 ----------------------------------
q1	17613	4309	4326	4309
q2	2006	193	184	184
q3	10471	1146	1081	1081
q4	10188	771	744	744
q5	7588	2722	2696	2696
q6	217	136	139	136
q7	953	594	592	592
q8	9228	2072	2084	2072
q9	8625	6524	6571	6524
q10	8807	3785	3813	3785
q11	454	237	242	237
q12	396	222	224	222
q13	17767	2997	2972	2972
q14	268	233	231	231
q15	518	478	469	469
q16	498	387	384	384
q17	964	700	609	609
q18	8024	7404	7391	7391
q19	4436	1388	1260	1260
q20	659	329	316	316
q21	4958	3167	3281	3167
q22	347	290	280	280
Total cold run time: 114985 ms
Total hot run time: 39661 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4533	4288	4235	4235
q2	384	270	256	256
q3	3042	2794	2850	2794
q4	1954	1704	1716	1704
q5	5589	5600	5578	5578
q6	224	141	133	133
q7	2245	1826	1903	1826
q8	3323	3474	3396	3396
q9	8807	8750	8908	8750
q10	4091	3879	3819	3819
q11	595	491	513	491
q12	823	661	626	626
q13	16156	3171	3187	3171
q14	318	275	287	275
q15	560	481	510	481
q16	509	453	425	425
q17	1822	1516	1499	1499
q18	8080	8014	7822	7822
q19	2139	1549	1630	1549
q20	2205	1928	1879	1879
q21	10475	4875	4876	4875
q22	596	520	508	508
Total cold run time: 78470 ms
Total hot run time: 56092 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174276 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 24bd152dc0e4e4ebe9d50b84f6c941bc36092fa3, data reload: false

query1	922	376	376	376
query2	6442	1927	1874	1874
query3	6655	210	214	210
query4	28655	17687	17354	17354
query5	3707	474	476	474
query6	257	177	173	173
query7	4588	290	286	286
query8	242	195	196	195
query9	8593	2397	2381	2381
query10	441	290	278	278
query11	11061	10288	10122	10122
query12	116	91	92	91
query13	1653	364	365	364
query14	10446	7501	8470	7501
query15	231	174	177	174
query16	7181	479	459	459
query17	1397	572	556	556
query18	1106	294	294	294
query19	198	160	160	160
query20	91	85	83	83
query21	208	128	132	128
query22	4309	4132	3997	3997
query23	34278	33910	33876	33876
query24	11275	2985	2858	2858
query25	636	410	425	410
query26	1110	163	157	157
query27	2394	275	280	275
query28	6855	2024	2029	2024
query29	916	665	646	646
query30	255	158	158	158
query31	989	790	763	763
query32	95	58	56	56
query33	775	359	341	341
query34	910	511	514	511
query35	863	790	788	788
query36	1142	994	1018	994
query37	144	79	83	79
query38	2934	2871	2840	2840
query39	905	883	858	858
query40	219	127	137	127
query41	47	47	50	47
query42	118	101	104	101
query43	507	486	473	473
query44	1212	729	714	714
query45	205	163	164	163
query46	1107	724	730	724
query47	1843	1776	1787	1776
query48	360	298	283	283
query49	849	415	420	415
query50	801	390	401	390
query51	6786	6706	6778	6706
query52	102	93	94	93
query53	358	298	296	296
query54	882	458	448	448
query55	74	71	72	71
query56	297	262	264	262
query57	1142	1056	1054	1054
query58	261	248	257	248
query59	2952	2709	2809	2709
query60	305	272	272	272
query61	100	96	116	96
query62	798	634	619	619
query63	319	291	292	291
query64	9554	2234	1684	1684
query65	3166	3167	3143	3143
query66	767	331	337	331
query67	15922	14888	14896	14888
query68	6309	540	535	535
query69	733	439	385	385
query70	1239	1127	1112	1112
query71	541	279	279	279
query72	8827	5194	5532	5194
query73	807	321	320	320
query74	6094	5680	5726	5680
query75	4735	2712	2658	2658
query76	4755	970	992	970
query77	802	307	314	307
query78	9799	9003	8995	8995
query79	6653	510	511	510
query80	1341	490	481	481
query81	566	228	227	227
query82	1368	146	139	139
query83	319	170	170	170
query84	274	85	86	85
query85	1424	316	290	290
query86	459	288	325	288
query87	3288	3093	3103	3093
query88	4978	2383	2399	2383
query89	508	386	380	380
query90	1942	200	196	196
query91	130	101	101	101
query92	65	51	48	48
query93	5671	514	489	489
query94	1242	293	282	282
query95	414	316	315	315
query96	607	269	273	269
query97	3188	3063	3059	3059
query98	233	227	216	216
query99	1507	1261	1232	1232
Total cold run time: 296846 ms
Total hot run time: 174276 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.91 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 24bd152dc0e4e4ebe9d50b84f6c941bc36092fa3, data reload: false

query1	0.04	0.04	0.03
query2	0.09	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.07	0.07
query5	0.48	0.48	0.50
query6	1.12	0.73	0.72
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.54	0.48	0.49
query10	0.55	0.54	0.56
query11	0.15	0.12	0.12
query12	0.16	0.13	0.12
query13	0.61	0.59	0.58
query14	0.78	0.79	0.77
query15	0.86	0.82	0.80
query16	0.38	0.37	0.35
query17	1.06	0.99	1.03
query18	0.22	0.21	0.21
query19	1.85	1.72	1.85
query20	0.01	0.01	0.01
query21	15.41	0.78	0.66
query22	3.72	7.76	2.09
query23	18.35	1.47	1.28
query24	2.23	0.21	0.22
query25	0.16	0.09	0.09
query26	0.29	0.22	0.21
query27	0.44	0.23	0.23
query28	13.24	1.03	1.01
query29	12.63	3.31	3.28
query30	0.25	0.06	0.06
query31	2.88	0.40	0.40
query32	3.26	0.49	0.46
query33	2.95	2.94	2.92
query34	17.20	4.38	4.40
query35	4.37	4.49	4.45
query36	0.66	0.49	0.46
query37	0.19	0.16	0.16
query38	0.16	0.15	0.14
query39	0.04	0.04	0.04
query40	0.15	0.11	0.13
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.66 s
Total hot run time: 30.91 s

HappenLee
HappenLee approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@HappenLee HappenLee merged commit c16ea41 into apache:master Jul 24, 2024
30 of 33 checks passed
zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request Jul 24, 2024
@zhangstar333
[Bug](agg) fix collect_set function core dump without arena pool (apa…
15d9adc 
…che#38234)

before the add_range_single_place pass nullptr as arena object,
but collect_set function need save data in arena, so will core dump
without arena pool.
@zhangstar333 zhangstar333 mentioned this pull request Jul 24, 2024
Merged
dataroaring pushed a commit that referenced this pull request Jul 24, 2024
@zhangstar333 @dataroaring
[Bug](agg) fix collect_set function core dump without arena pool (#38234
488e877 
)

before the add_range_single_place pass nullptr as arena object,
but collect_set function need save data in arena, so will core dump
without arena pool.
yiguolei pushed a commit that referenced this pull request Jul 25, 2024
@zhangstar333
[cherry-pick](branch-21) fix collect_set function core dump without a…
57864e8 
…rena pool (#38234) (#38307)

## Proposed changes

cherry-pick from master #38234

<!--Describe your changes.-->
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabriel39 Gabriel39 Gabriel39 approved these changes

@HappenLee HappenLee HappenLee approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.1-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zhangstar333 @doris-robot @HappenLee @Gabriel39 @yiguolei @dataroaring