Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](group commit) group commit show error url #38292

Merged
merged 1 commit into from
Jul 24, 2024
Merged

[fix](group commit) group commit show error url #38292

merged 1 commit into from
Jul 24, 2024

Conversation

mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Jul 24, 2024

Proposed changes

insert into in group commit should show error url if some rows are invalid.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jul 24, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jul 24, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40027 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1f6c62f606fbcfd0ac0e2c51986f1231765fa2d6, data reload: false

------ Round 1 ----------------------------------
q1	18679	4714	4308	4308
q2	2023	190	189	189
q3	10554	1168	1171	1168
q4	10249	885	765	765
q5	7554	2710	2644	2644
q6	229	141	140	140
q7	957	595	605	595
q8	9218	2138	2084	2084
q9	8754	6588	6577	6577
q10	8722	3837	3787	3787
q11	450	233	231	231
q12	403	222	227	222
q13	17753	2966	3012	2966
q14	268	248	241	241
q15	523	480	473	473
q16	498	386	378	378
q17	1035	724	695	695
q18	8360	7647	7373	7373
q19	7082	1391	1457	1391
q20	688	318	308	308
q21	4932	3215	3971	3215
q22	352	277	281	277
Total cold run time: 119283 ms
Total hot run time: 40027 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4422	4294	4282	4282
q2	371	259	275	259
q3	3189	2949	2955	2949
q4	1991	1756	1721	1721
q5	5576	5546	5589	5546
q6	239	135	135	135
q7	2269	1905	1915	1905
q8	3281	3441	3422	3422
q9	8822	8911	8787	8787
q10	3977	3760	3847	3760
q11	592	515	518	515
q12	837	636	647	636
q13	17046	3170	3185	3170
q14	313	300	271	271
q15	529	495	500	495
q16	483	439	436	436
q17	1824	1541	1524	1524
q18	8179	7895	7711	7711
q19	1774	1693	1636	1636
q20	2966	1888	1833	1833
q21	9602	4726	4891	4726
q22	602	509	518	509
Total cold run time: 78884 ms
Total hot run time: 56228 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174329 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1f6c62f606fbcfd0ac0e2c51986f1231765fa2d6, data reload: false

query1	914	370	363	363
query2	6394	2048	1843	1843
query3	6652	210	216	210
query4	28257	17280	17418	17280
query5	3663	482	493	482
query6	264	173	167	167
query7	4576	283	281	281
query8	240	187	190	187
query9	8393	2417	2371	2371
query10	420	290	267	267
query11	12224	10246	10087	10087
query12	121	92	83	83
query13	1634	382	370	370
query14	10250	8309	7622	7622
query15	220	170	166	166
query16	7721	424	465	424
query17	1279	537	521	521
query18	1855	273	272	272
query19	191	154	147	147
query20	87	83	89	83
query21	203	132	132	132
query22	4398	4358	4212	4212
query23	34110	33748	33753	33748
query24	11229	2909	2862	2862
query25	603	397	406	397
query26	974	155	152	152
query27	2438	274	280	274
query28	7015	2101	2081	2081
query29	864	641	622	622
query30	269	158	160	158
query31	954	759	748	748
query32	90	52	57	52
query33	741	353	331	331
query34	913	498	519	498
query35	925	769	764	764
query36	1151	989	994	989
query37	136	82	89	82
query38	2932	2779	2775	2775
query39	864	825	815	815
query40	194	117	121	117
query41	45	43	43	43
query42	109	98	98	98
query43	509	489	495	489
query44	1163	721	734	721
query45	194	162	164	162
query46	1090	755	700	700
query47	1861	1761	1795	1761
query48	364	298	297	297
query49	835	403	413	403
query50	778	384	395	384
query51	6740	6712	6688	6688
query52	107	91	95	91
query53	351	298	283	283
query54	860	445	443	443
query55	75	74	73	73
query56	291	262	294	262
query57	1133	1032	1087	1032
query58	239	240	258	240
query59	3003	2677	2896	2677
query60	309	289	275	275
query61	94	92	92	92
query62	802	643	658	643
query63	330	293	283	283
query64	9514	2197	1681	1681
query65	3189	3110	3113	3110
query66	826	325	324	324
query67	15517	15191	15083	15083
query68	4532	539	545	539
query69	526	342	340	340
query70	1192	1114	1100	1100
query71	408	281	271	271
query72	7355	5757	5673	5673
query73	756	323	321	321
query74	6230	5683	5617	5617
query75	3396	2680	2681	2680
query76	2226	951	941	941
query77	506	293	305	293
query78	9622	9101	9005	9005
query79	2482	534	522	522
query80	2525	467	470	467
query81	596	220	220	220
query82	1041	139	136	136
query83	298	164	164	164
query84	252	87	87	87
query85	1251	319	304	304
query86	457	337	272	272
query87	3258	3110	3139	3110
query88	3363	2425	2349	2349
query89	466	375	397	375
query90	1723	187	189	187
query91	131	101	103	101
query92	60	50	50	50
query93	2102	524	512	512
query94	1164	277	295	277
query95	416	318	306	306
query96	606	267	272	267
query97	3221	3079	3004	3004
query98	221	206	203	203
query99	1508	1265	1263	1263
Total cold run time: 280576 ms
Total hot run time: 174329 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.77 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1f6c62f606fbcfd0ac0e2c51986f1231765fa2d6, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.04	0.05
query4	1.68	0.07	0.07
query5	0.61	0.47	0.48
query6	1.13	0.72	0.72
query7	0.02	0.01	0.01
query8	0.06	0.04	0.04
query9	0.55	0.50	0.49
query10	0.54	0.56	0.54
query11	0.15	0.12	0.11
query12	0.14	0.11	0.13
query13	0.60	0.58	0.58
query14	0.76	0.78	0.76
query15	0.85	0.81	0.82
query16	0.35	0.35	0.37
query17	0.98	0.98	0.95
query18	0.22	0.21	0.22
query19	1.75	1.72	1.66
query20	0.01	0.01	0.01
query21	15.44	0.79	0.67
query22	3.96	7.12	2.26
query23	18.29	1.35	1.26
query24	2.16	0.23	0.22
query25	0.15	0.10	0.09
query26	0.30	0.21	0.21
query27	0.46	0.22	0.23
query28	13.26	1.02	1.00
query29	12.56	3.28	3.26
query30	0.25	0.06	0.05
query31	2.87	0.38	0.37
query32	3.29	0.48	0.48
query33	2.88	2.88	2.92
query34	17.02	4.35	4.35
query35	4.42	4.42	4.39
query36	0.65	0.46	0.48
query37	0.19	0.16	0.16
query38	0.16	0.15	0.15
query39	0.04	0.04	0.04
query40	0.16	0.12	0.12
query41	0.09	0.05	0.05
query42	0.06	0.05	0.04
query43	0.05	0.04	0.04
Total cold run time: 109.45 s
Total hot run time: 30.77 s

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jul 24, 2024

run cloud_p1

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jul 24, 2024

run p1

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jul 24, 2024

run external

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jul 24, 2024

run p0

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jul 24, 2024

run cloud_p0

dataroaring
dataroaring approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 8602a4a into apache:master Jul 24, 2024
27 of 30 checks passed
mymeiyi added a commit to mymeiyi/doris that referenced this pull request Jul 24, 2024
@mymeiyi
[fix](group commit) group commit show error url (apache#38292)
64f1f0b 
`insert into` in group commit should show error url if some rows are
invalid.
@mymeiyi mymeiyi mentioned this pull request Jul 24, 2024
Merged
dataroaring pushed a commit that referenced this pull request Jul 24, 2024
@mymeiyi @dataroaring
[fix](group commit) group commit show error url (#38292)
5762703 
## Proposed changes
 
`insert into` in group commit should show error url if some rows are
invalid.
dataroaring pushed a commit that referenced this pull request Jul 25, 2024
@mymeiyi
[fix](group commit) Pick some group commit pr (#38320)
91f0301 
Pick #38292,
#34021,
#38228, some modify of
#37260, some modify of
#37595
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.1-merged meta-change reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mymeiyi @doris-robot @Yukang-Lian @dataroaring