[fix](load) fix no error url for stream load #38325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40131 ms |
TPC-DS: Total hot run time: 172579 ms |
ClickBench: Total hot run time: 30.29 s |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39645 ms |
TPC-DS: Total hot run time: 174353 ms |
ClickBench: Total hot run time: 30.83 s |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Yukang-Lian
approved these changes
Jul 25, 2024
gavinchou
approved these changes
Jul 25, 2024
liaoxin01
added a commit
to liaoxin01/doris
that referenced
this pull request
Jul 26, 2024
Previously, it was determined whether to output an error URL based on whether num_filtered_rows was greater than 0. However, in abnormal situations, the statistics of num_filtered_rows may not be accurate, resulting in no error URL output. As long as there is data in the error log file indicating filtered rows, the URL can be returned to the client without the need to determine the number of filtered rows.
liaoxin01
added a commit
that referenced
this pull request
Jul 28, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jul 31, 2024
Previously, it was determined whether to output an error URL based on whether num_filtered_rows was greater than 0. However, in abnormal situations, the statistics of num_filtered_rows may not be accurate, resulting in no error URL output. As long as there is data in the error log file indicating filtered rows, the URL can be returned to the client without the need to determine the number of filtered rows.
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Nov 12, 2024
Previously, it was determined whether to output an error URL based on whether num_filtered_rows was greater than 0. However, in abnormal situations, the statistics of num_filtered_rows may not be accurate, resulting in no error URL output. As long as there is data in the error log file indicating filtered rows, the URL can be returned to the client without the need to determine the number of filtered rows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was determined whether to output an error URL based on whether num_filtered_rows was greater than 0. However, in abnormal situations, the statistics of num_filtered_rows may not be accurate, resulting in no error URL output. As long as there is data in the error log file indicating filtered rows, the URL can be returned to the client without the need to determine the number of filtered rows.