-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement](schema scan) Use async scanner for schema scanners #38403
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
} | ||
|
||
Status SchemaActiveQueriesScanner::_get_active_queries_block_from_fe() { | ||
void SchemaActiveQueriesScanner::_get_next_block_internal() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function '_get_next_block_internal' exceeds recommended size/complexity thresholds [readability-function-size]
void SchemaActiveQueriesScanner::_get_next_block_internal() {
^
Additional context
be/src/exec/schema_scanner/schema_active_queries_scanner.cpp:53: 97 lines including whitespace and comments (threshold 80)
void SchemaActiveQueriesScanner::_get_next_block_internal() {
^
run buildall |
1 similar comment
run buildall |
TPC-H: Total hot run time: 39114 ms
|
TPC-DS: Total hot run time: 171736 ms
|
ClickBench: Total hot run time: 31.28 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
} | ||
|
||
Status SchemaActiveQueriesScanner::_get_active_queries_block_from_fe() { | ||
void SchemaActiveQueriesScanner::_get_next_block_internal() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function '_get_next_block_internal' exceeds recommended size/complexity thresholds [readability-function-size]
void SchemaActiveQueriesScanner::_get_next_block_internal() {
^
Additional context
be/src/exec/schema_scanner/schema_active_queries_scanner.cpp:53: 98 lines including whitespace and comments (threshold 80)
void SchemaActiveQueriesScanner::_get_next_block_internal() {
^
run buildall |
TPC-H: Total hot run time: 39404 ms
|
TPC-DS: Total hot run time: 172537 ms
|
ClickBench: Total hot run time: 31.14 s
|
run buildall |
run buildall |
TPC-H: Total hot run time: 39149 ms
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
TPC-H: Total hot run time: 39602 ms
|
TPC-DS: Total hot run time: 174031 ms
|
ClickBench: Total hot run time: 30.61 s
|
run buildall |
TPC-H: Total hot run time: 41432 ms
|
TPC-DS: Total hot run time: 170005 ms
|
ClickBench: Total hot run time: 30.16 s
|
run buildall |
TPC-H: Total hot run time: 42501 ms
|
TPC-DS: Total hot run time: 169598 ms
|
ClickBench: Total hot run time: 30.03 s
|
run buildall |
TPC-H: Total hot run time: 41443 ms
|
TPC-DS: Total hot run time: 169308 ms
|
ClickBench: Total hot run time: 30.42 s
|
run buildall |
TPC-H: Total hot run time: 41837 ms
|
TPC-DS: Total hot run time: 172158 ms
|
ClickBench: Total hot run time: 30.14 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
## Proposed changes Resolve conflicts by merging apache#38436 and apache#38403 <!--Describe your changes.-->
Proposed changes
Issue Number: close #xxx