[fix](delete) Fix delete stmt on MOW table doesn't use partial update in Nereids planner #38751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 41651 ms |
TPC-DS: Total hot run time: 169621 ms |
ClickBench: Total hot run time: 29.79 s |
bobhan1
force-pushed
the
fix-nereids-delete
branch
from
0fd0c6a to
e051ed6
Compare
|
run buildall |
TPC-H: Total hot run time: 41713 ms |
TPC-DS: Total hot run time: 168394 ms |
ClickBench: Total hot run time: 29.92 s |
bobhan1
force-pushed
the
fix-nereids-delete
branch
from
e051ed6 to
9562e89
Compare
|
run buildall |
TPC-H: Total hot run time: 41534 ms |
TPC-DS: Total hot run time: 170156 ms |
ClickBench: Total hot run time: 29.82 s |
|
run p0 |
bobhan1
force-pushed
the
fix-nereids-delete
branch
from
9562e89 to
e99ea9d
Compare
|
run buildall |
TPC-H: Total hot run time: 41386 ms |
TPC-DS: Total hot run time: 168182 ms |
ClickBench: Total hot run time: 29.82 s |
|
run buildall |
TPC-H: Total hot run time: 41552 ms |
TPC-DS: Total hot run time: 169658 ms |
ClickBench: Total hot run time: 30.07 s |
bobhan1
force-pushed
the
fix-nereids-delete
branch
from
47bca2c to
52f5df3
Compare
|
run buildall |
TPC-H: Total hot run time: 41744 ms |
TPC-DS: Total hot run time: 168055 ms |
ClickBench: Total hot run time: 30.45 s |
|
run buildall |
TPC-H: Total hot run time: 41373 ms |
TPC-DS: Total hot run time: 170471 ms |
ClickBench: Total hot run time: 30.15 s |
|
run cloud_p0 |
1 similar comment
|
run cloud_p0 |
zhannngchen
reviewed
Aug 7, 2024
| @@ -134,23 +135,17 @@ suite("test_delete_on_value") { | |||
| // test mor table | |||
| sql "insert into ${tableName4} values(1,1,10);" | |||
| sql "insert into ${tableName4} values(1,1,5);" | |||
| qt_sql "select * from ${tableName4} order by x,y,z;" | |||
| sql "set skip_storage_engine_merge=true;" | |||
There was a problem hiding this comment.
Why remove these operations?
There was a problem hiding this comment.
it's case irrelevant
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
dataroaring
pushed a commit
that referenced
this pull request
Aug 9, 2024
… in Nereids planner (#38751) ## Proposed changes 1. Fix nereids planner don't use partial update for delete statement on merge-on-write table introduced in #36782 2. add `IS_PARTIAL_UPDATE: true` in `OlapTableSink.getExplainString()` 3. don't convert the delete stmt to partial update if the table has cluster key.
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Aug 14, 2024
… in Nereids planner (apache#38751) ## Proposed changes 1. Fix nereids planner don't use partial update for delete statement on merge-on-write table introduced in apache#36782 2. add `IS_PARTIAL_UPDATE: true` in `OlapTableSink.getExplainString()` 3. don't convert the delete stmt to partial update if the table has cluster key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
IS_PARTIAL_UPDATE: trueinOlapTableSink.getExplainString()branch-2.1-pick: #39214