Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Opt](cloud) Using file cache disks number to determine the size of the flush memtable thread pool #38789

Merged
merged 1 commit into from
Aug 5, 2024
Merged

[Opt](cloud) Using file cache disks number to determine the size of the flush memtable thread pool #38789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions be/src/cloud/cloud_storage_engine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
#include "cloud/cloud_warm_up_manager.h"
#include "cloud/config.h"
#include "io/cache/block_file_cache_downloader.h"
#include "io/cache/block_file_cache_factory.h"
#include "io/cache/file_cache_common.h"
#include "io/fs/file_system.h"
#include "io/fs/hdfs_file_system.h"
Expand Down Expand Up @@ -180,8 +181,8 @@ Status CloudStorageEngine::open() {
// TODO(plat1ko): DeleteBitmapTxnManager

_memtable_flush_executor = std::make_unique<MemTableFlushExecutor>();
// TODO(plat1ko): Use file cache disks number?
_memtable_flush_executor->init(1);
// Use file cache disks number
_memtable_flush_executor->init(io::FileCacheFactory::instance()->get_cache_instance_size());

_calc_delete_bitmap_executor = std::make_unique<CalcDeleteBitmapExecutor>();
_calc_delete_bitmap_executor->init();
Expand Down
Loading