Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](Nereids) fix insert into table with null literal default value #39122

Merged
merged 1 commit into from
Aug 12, 2024
Merged

[fix](Nereids) fix insert into table with null literal default value #39122

merged 1 commit into from
Aug 12, 2024

Conversation

LiBinfeng-01
Copy link
Collaborator

Problem:
when use insert with default value null, it can not be insert successfully
Solved:
when column is allow to be null, it can be null in create table with null default value

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@LiBinfeng-01
Copy link
Collaborator Author

run buildall

@github-actions github-actions bot added the doing label Aug 8, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 39850 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5101b1d1792906d51f0fac7d0a6e71f751727926, data reload: false

------ Round 1 ----------------------------------
q1	18275	4493	4410	4410
q2	2335	186	182	182
q3	11542	1152	1112	1112
q4	10743	804	708	708
q5	7536	2574	2534	2534
q6	226	139	148	139
q7	992	618	604	604
q8	9546	1918	1907	1907
q9	8583	6565	6511	6511
q10	7021	2192	2189	2189
q11	463	249	247	247
q12	400	236	229	229
q13	17777	2983	3013	2983
q14	282	240	230	230
q15	527	489	499	489
q16	489	393	377	377
q17	989	697	703	697
q18	8015	7370	7408	7370
q19	5267	1073	1052	1052
q20	667	333	328	328
q21	5357	4548	4591	4548
q22	1110	1006	1004	1004
Total cold run time: 118142 ms
Total hot run time: 39850 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4522	4291	4394	4291
q2	383	257	282	257
q3	2851	2629	2599	2599
q4	1895	1636	1624	1624
q5	5262	5268	5249	5249
q6	226	135	137	135
q7	2069	1678	1665	1665
q8	3209	3312	3341	3312
q9	8439	8388	8321	8321
q10	3397	3121	3145	3121
q11	593	511	487	487
q12	768	603	613	603
q13	17408	2957	2972	2957
q14	306	275	270	270
q15	531	487	483	483
q16	483	411	419	411
q17	1778	1474	1506	1474
q18	7589	7608	7281	7281
q19	1651	1557	1476	1476
q20	1953	1780	1766	1766
q21	5191	4952	5011	4952
q22	1048	995	978	978
Total cold run time: 71552 ms
Total hot run time: 53712 ms

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024

PR approved by anyone and no changes requested.

cambyzju
cambyzju reviewed Aug 8, 2024
View reviewed changes
regression-test/data/load_p0/insert/test_insert_default_value.out
@@ -1,8 +1,15 @@
-- This file is automatically generated. You should know what you did if you want to edit this
-- !select1 --
10 10000 10000000 92233720368547758 19223372036854775807 10.3 10.3
10 10000 10000000 92233720368547758 19223372036854775807 10.3 10.3
10 10000 10000000 92233720368547758 19223372036854775807 10.30 10.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this pr will change 10.3 to 10.30

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it is not this pr changed the result scale. the regression framework do not check precision and scale, so the test could pass even if scale has been changed

@LiBinfeng-01
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39688 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5101b1d1792906d51f0fac7d0a6e71f751727926, data reload: false

------ Round 1 ----------------------------------
q1	17871	4373	4320	4320
q2	2032	174	172	172
q3	10507	1167	1051	1051
q4	10145	764	697	697
q5	8822	2508	2540	2508
q6	233	143	144	143
q7	1021	619	603	603
q8	9370	1983	1980	1980
q9	10203	6742	6706	6706
q10	7187	2190	2189	2189
q11	464	238	248	238
q12	516	217	220	217
q13	18137	3020	3011	3011
q14	291	244	234	234
q15	532	496	495	495
q16	507	407	389	389
q17	990	683	662	662
q18	8038	7327	7348	7327
q19	1663	1081	1056	1056
q20	666	321	334	321
q21	5417	4385	4373	4373
q22	1100	996	1000	996
Total cold run time: 115712 ms
Total hot run time: 39688 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4422	4202	4252	4202
q2	357	266	262	262
q3	2815	2629	2650	2629
q4	1940	1681	1736	1681
q5	5522	5516	5527	5516
q6	221	133	129	129
q7	2121	1768	1815	1768
q8	3289	3419	3424	3419
q9	8861	8677	8851	8677
q10	3486	3272	3329	3272
q11	601	490	502	490
q12	774	613	611	611
q13	15948	3177	3168	3168
q14	311	274	295	274
q15	528	498	509	498
q16	494	460	445	445
q17	1840	1566	1512	1512
q18	8110	7922	7787	7787
q19	1725	1612	1504	1504
q20	2119	1919	1857	1857
q21	8714	5430	5389	5389
q22	1099	1001	997	997
Total cold run time: 75297 ms
Total hot run time: 56087 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 201202 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5101b1d1792906d51f0fac7d0a6e71f751727926, data reload: false

query1	906	363	351	351
query2	6438	2066	2020	2020
query3	6647	205	229	205
query4	33908	23269	22973	22973
query5	3627	492	505	492
query6	262	169	170	169
query7	4578	296	287	287
query8	244	206	197	197
query9	8833	2417	2378	2378
query10	528	437	443	437
query11	16421	15146	14812	14812
query12	131	98	94	94
query13	1639	367	358	358
query14	9430	7589	7499	7499
query15	264	217	214	214
query16	7584	492	457	457
query17	1605	546	555	546
query18	1922	278	274	274
query19	192	141	135	135
query20	119	111	112	111
query21	210	101	100	100
query22	4652	4523	4337	4337
query23	34584	33815	33945	33815
query24	9158	2696	2566	2566
query25	597	393	362	362
query26	713	153	158	153
query27	2187	281	286	281
query28	5594	2003	1988	1988
query29	821	400	399	399
query30	254	152	142	142
query31	953	749	750	749
query32	93	51	53	51
query33	592	282	265	265
query34	858	452	464	452
query35	975	781	819	781
query36	1066	929	902	902
query37	126	78	76	76
query38	4267	4176	4048	4048
query39	1405	1386	1401	1386
query40	193	111	114	111
query41	45	44	43	43
query42	115	99	99	99
query43	499	474	463	463
query44	1081	723	726	723
query45	230	206	197	197
query46	1079	721	727	721
query47	1877	1799	1810	1799
query48	372	295	284	284
query49	833	405	415	405
query50	791	402	396	396
query51	6749	6806	6717	6717
query52	97	86	88	86
query53	253	183	181	181
query54	746	439	435	435
query55	73	69	72	69
query56	262	239	249	239
query57	1172	1079	1071	1071
query58	225	236	227	227
query59	2993	2856	2691	2691
query60	311	255	262	255
query61	93	90	89	89
query62	789	653	638	638
query63	206	180	175	175
query64	9129	2333	1732	1732
query65	3180	3127	3155	3127
query66	737	321	348	321
query67	15281	14885	14757	14757
query68	4436	541	539	539
query69	400	357	363	357
query70	1176	1041	1130	1041
query71	356	271	257	257
query72	17539	16647	16423	16423
query73	759	322	320	320
query74	9194	8709	8721	8709
query75	3382	2685	2654	2654
query76	2147	1030	930	930
query77	443	294	304	294
query78	10979	9118	9542	9118
query79	2641	527	514	514
query80	2000	485	489	485
query81	588	225	215	215
query82	777	145	132	132
query83	277	149	152	149
query84	269	80	79	79
query85	1537	324	367	324
query86	471	296	298	296
query87	4790	4614	4557	4557
query88	4165	2450	2459	2450
query89	402	283	280	280
query90	1794	186	188	186
query91	116	95	93	93
query92	64	48	47	47
query93	3373	540	525	525
query94	860	293	288	288
query95	371	252	253	252
query96	609	268	274	268
query97	3227	3077	3102	3077
query98	216	193	196	193
query99	1629	1237	1245	1237
Total cold run time: 304781 ms
Total hot run time: 201202 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.68 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5101b1d1792906d51f0fac7d0a6e71f751727926, data reload: false

query1	0.05	0.04	0.04
query2	0.07	0.04	0.04
query3	0.22	0.05	0.05
query4	1.67	0.08	0.08
query5	0.50	0.47	0.49
query6	1.13	0.73	0.73
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.56	0.50	0.51
query10	0.55	0.55	0.55
query11	0.15	0.11	0.12
query12	0.15	0.12	0.12
query13	0.59	0.59	0.58
query14	0.76	0.79	0.78
query15	0.86	0.80	0.82
query16	0.37	0.38	0.37
query17	1.00	1.05	1.04
query18	0.23	0.21	0.21
query19	1.78	1.71	1.75
query20	0.01	0.02	0.01
query21	15.39	0.76	0.65
query22	4.09	7.12	2.00
query23	18.34	1.24	1.23
query24	2.09	0.22	0.22
query25	0.14	0.07	0.09
query26	0.30	0.21	0.20
query27	0.45	0.22	0.21
query28	13.24	1.02	1.00
query29	12.62	3.36	3.34
query30	0.24	0.05	0.05
query31	2.90	0.38	0.37
query32	3.29	0.48	0.46
query33	2.92	2.88	2.90
query34	17.00	4.34	4.34
query35	4.40	4.36	4.43
query36	0.64	0.47	0.48
query37	0.19	0.16	0.16
query38	0.15	0.15	0.14
query39	0.05	0.04	0.04
query40	0.15	0.13	0.13
query41	0.10	0.04	0.05
query42	0.05	0.04	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.5 s
Total hot run time: 30.68 s

@LiBinfeng-01
Copy link
Collaborator Author

run p0

@morrySnow morrySnow merged commit c47399c into apache:master Aug 12, 2024
33 of 37 checks passed
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Aug 14, 2024
@LiBinfeng-01 @wyxxxcat
[fix](Nereids) fix insert into table with null literal default value (a…
02774f6 
…pache#39122)

Problem:
when use insert with default value null, it can not be insert
successfully
Solved:
when column is allow to be null, it can be null in create table with
null default value
dataroaring pushed a commit that referenced this pull request Aug 17, 2024
@LiBinfeng-01 @dataroaring
[fix](Nereids) fix insert into table with null literal default value (#…
fc1a476 
…39122)

Problem:
when use insert with default value null, it can not be insert
successfully
Solved:
when column is allow to be null, it can be null in create table with
null default value
LiBinfeng-01 added a commit to LiBinfeng-01/doris that referenced this pull request Aug 21, 2024
@LiBinfeng-01
[fix](Nereids) fix insert into table with null literal default value (a…
3fb7457 
…pache#39122)

Problem:
when use insert with default value null, it can not be insert
successfully
Solved:
when column is allow to be null, it can be null in create table with
null default value
@LiBinfeng-01 LiBinfeng-01 mentioned this pull request Aug 21, 2024
Merged
LiBinfeng-01 added a commit to LiBinfeng-01/doris that referenced this pull request Aug 21, 2024
@LiBinfeng-01
[fix](Nereids) fix insert into table with null literal default value (a…
1c97e71 
…pache#39122)

Problem:
when use insert with default value null, it can not be insert
successfully
Solved:
when column is allow to be null, it can be null in create table with
null default value
@LiBinfeng-01 LiBinfeng-01 mentioned this pull request Aug 21, 2024
Merged
yiguolei pushed a commit that referenced this pull request Aug 22, 2024
@LiBinfeng-01
[fix](Nereids) fix insert into table with null literal default value (#…
ca9e50e 
…39122) (#39669)

cherry-pick: #39122

Problem:
when use insert with default value null, it can not be insert
successfully
Solved:
when column is allow to be null, it can be null in create table with
null default value

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
LiBinfeng-01 added a commit to LiBinfeng-01/doris that referenced this pull request Aug 23, 2024
@LiBinfeng-01
[fix](Nereids) fix insert into table with null literal default value (a…
aedcead 
…pache#39122)

Problem:
when use insert with default value null, it can not be insert
successfully
Solved:
when column is allow to be null, it can be null in create table with
null default value
LiBinfeng-01 added a commit to LiBinfeng-01/doris that referenced this pull request Aug 23, 2024
@LiBinfeng-01
[fix](Nereids) fix insert into table with null literal default value (a…
160d83b 
…pache#39122)

Problem:
when use insert with default value null, it can not be insert
successfully
Solved:
when column is allow to be null, it can be null in create table with
null default value
morrySnow pushed a commit that referenced this pull request Aug 23, 2024
@LiBinfeng-01
[fix](Nereids) fix insert into table with null literal default value (#…
e02f583 
…39122) (#39673)

cherry-pick from master #39122

Problem:
when use insert with default value null, it can not be insert
successfully
Solved:
when column is allow to be null, it can be null in create table with
null default value
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
Open
3 tasks
mongo360 pushed a commit to mongo360/doris that referenced this pull request Dec 11, 2024
@LiBinfeng-01 @Baymine
[fix](Nereids) fix insert into table with null literal default value (a…
19400eb 
…pache#39122) (apache#39673)

cherry-pick from master apache#39122

Problem:
when use insert with default value null, it can not be insert
successfully
Solved:
when column is allow to be null, it can be null in create table with
null default value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cambyzju cambyzju cambyzju left review comments

@morrySnow morrySnow morrySnow approved these changes

@feiniaofeiafei feiniaofeiafei feiniaofeiafei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.15-merged dev/2.1.6-merged dev/3.0.2-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@LiBinfeng-01 @doris-robot @cambyzju @feiniaofeiafei @morrySnow @yiguolei @dataroaring