Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](auth) Fix ResourceTypeEnum Compatibility Upgrade #39288

Merged
merged 5 commits into from
Aug 15, 2024

Conversation

deardeng
Copy link
Contributor

RuntimeLogger 2024-08-12 22:47:37,850 ERROR (replayer|88) [EditLog.loadJournal():1244] replay Operation Type 64, log id: 13752
java.lang.NullPointerException: Cannot invoke "org.apache.doris.analysis.ResourceTypeEnum.ordinal()" because the return value of "org.apache.doris.analysis.ResourcePattern.getResourceType()" is null
	at org.apache.doris.mysql.privilege.Role.<init>(Role.java:155) ~[doris-fe.jar:1.2-SNAPSHOT]
	at org.apache.doris.mysql.privilege.Auth.grantInternal(Auth.java:706) ~[doris-fe.jar:1.2-SNAPSHOT]
	at org.apache.doris.mysql.privilege.Auth.replayGrant(Auth.java:657) ~[doris-fe.jar:1.2-SNAPSHOT]
	at org.apache.doris.persist.EditLog.loadJournal(EditLog.java:466) ~[doris-fe.jar:1.2-SNAPSHOT]
	at org.apache.doris.catalog.Env.replayJournal(Env.java:2913) ~[doris-fe.jar:1.2-SNAPSHOT]
	at org.apache.doris.catalog.Env$4.runOneCycle(Env.java:2675) ~[doris-fe.jar:1.2-SNAPSHOT]
	at org.apache.doris.common.util.Daemon.run(Daemon.java:116) ~[doris-fe.jar:1.2-SNAPSHOT]

Proposed changes

Issue Number: close #xxx

```
RuntimeLogger 2024-08-12 22:47:37,850 ERROR (replayer|88) [EditLog.loadJournal():1244] replay Operation Type 64, log id: 13752
java.lang.NullPointerException: Cannot invoke "org.apache.doris.analysis.ResourceTypeEnum.ordinal()" because the return value of "org.apache.doris.analysis.ResourcePattern.getResourceType()" is null
	at org.apache.doris.mysql.privilege.Role.<init>(Role.java:155) ~[doris-fe.jar:1.2-SNAPSHOT]
	at org.apache.doris.mysql.privilege.Auth.grantInternal(Auth.java:706) ~[doris-fe.jar:1.2-SNAPSHOT]
	at org.apache.doris.mysql.privilege.Auth.replayGrant(Auth.java:657) ~[doris-fe.jar:1.2-SNAPSHOT]
	at org.apache.doris.persist.EditLog.loadJournal(EditLog.java:466) ~[doris-fe.jar:1.2-SNAPSHOT]
	at org.apache.doris.catalog.Env.replayJournal(Env.java:2913) ~[doris-fe.jar:1.2-SNAPSHOT]
	at org.apache.doris.catalog.Env$4.runOneCycle(Env.java:2675) ~[doris-fe.jar:1.2-SNAPSHOT]
	at org.apache.doris.common.util.Daemon.run(Daemon.java:116) ~[doris-fe.jar:1.2-SNAPSHOT]
```
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@deardeng
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the doing label Aug 13, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 40014 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e29fa34413bcc02cb3980b63b57b18fda745c516, data reload: false

------ Round 1 ----------------------------------
q1	17634	4369	4259	4259
q2	2021	176	177	176
q3	10517	1168	1101	1101
q4	10154	660	719	660
q5	7739	2817	2793	2793
q6	227	143	147	143
q7	955	603	598	598
q8	9322	2018	2032	2018
q9	8615	6547	6552	6547
q10	7011	2197	2143	2143
q11	459	250	247	247
q12	393	225	222	222
q13	17759	2997	2979	2979
q14	280	245	237	237
q15	522	471	464	464
q16	486	386	392	386
q17	961	681	685	681
q18	8147	7568	7469	7469
q19	6046	1112	1025	1025
q20	688	333	327	327
q21	5552	4525	4658	4525
q22	1104	1052	1014	1014
Total cold run time: 116592 ms
Total hot run time: 40014 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4437	4266	4294	4266
q2	388	277	276	276
q3	2840	2619	2609	2609
q4	1882	1585	1611	1585
q5	5380	5368	5403	5368
q6	221	132	136	132
q7	2012	1655	1705	1655
q8	3177	3308	3290	3290
q9	8376	8319	8321	8319
q10	3388	3136	3146	3136
q11	582	490	505	490
q12	773	601	607	601
q13	17491	2970	2962	2962
q14	298	274	278	274
q15	520	490	481	481
q16	473	423	417	417
q17	1792	1479	1485	1479
q18	7721	7468	7557	7468
q19	1721	1561	1575	1561
q20	2026	1826	1799	1799
q21	5286	5194	5164	5164
q22	1073	1010	1019	1010
Total cold run time: 71857 ms
Total hot run time: 54342 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185753 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e29fa34413bcc02cb3980b63b57b18fda745c516, data reload: false

query1	919	373	364	364
query2	6460	1900	1863	1863
query3	6637	214	211	211
query4	33384	23114	23146	23114
query5	4203	493	490	490
query6	283	160	161	160
query7	4584	291	285	285
query8	233	202	194	194
query9	8577	2407	2366	2366
query10	427	277	266	266
query11	16525	14859	14898	14859
query12	150	96	100	96
query13	1644	375	364	364
query14	8655	7742	7606	7606
query15	224	170	170	170
query16	7712	478	470	470
query17	1377	569	554	554
query18	1832	290	289	289
query19	185	147	149	147
query20	114	109	107	107
query21	212	101	98	98
query22	4446	4016	4000	4000
query23	33864	33091	33087	33087
query24	12276	2851	2791	2791
query25	669	394	400	394
query26	1830	159	160	159
query27	2893	279	274	274
query28	7791	2029	2004	2004
query29	1107	419	418	418
query30	306	145	147	145
query31	1051	781	757	757
query32	102	56	58	56
query33	763	290	298	290
query34	940	465	476	465
query35	823	744	695	695
query36	1054	945	921	921
query37	175	82	84	82
query38	3961	3853	3857	3853
query39	1432	1389	1379	1379
query40	276	122	119	119
query41	48	45	47	45
query42	121	103	103	103
query43	511	472	473	472
query44	1225	742	745	742
query45	194	172	169	169
query46	1101	758	742	742
query47	1851	1769	1767	1767
query48	367	300	299	299
query49	1188	425	422	422
query50	801	400	404	400
query51	6825	6742	6785	6742
query52	108	93	91	91
query53	257	185	185	185
query54	965	462	451	451
query55	81	76	81	76
query56	272	254	248	248
query57	1156	1087	1044	1044
query58	263	249	230	230
query59	2960	2687	2752	2687
query60	297	280	280	280
query61	117	114	114	114
query62	821	643	646	643
query63	212	190	193	190
query64	10743	2307	1708	1708
query65	3198	3294	3170	3170
query66	1347	349	337	337
query67	15728	14911	15021	14911
query68	7903	555	573	555
query69	735	379	298	298
query70	1172	1103	1098	1098
query71	548	274	276	274
query72	7877	2242	2010	2010
query73	814	327	332	327
query74	9014	8801	8904	8801
query75	5114	2697	2684	2684
query76	4916	1008	996	996
query77	768	312	305	305
query78	9695	9105	8972	8972
query79	8278	527	524	524
query80	1186	501	493	493
query81	578	217	229	217
query82	777	133	135	133
query83	303	151	147	147
query84	268	74	76	74
query85	1416	264	271	264
query86	396	294	293	293
query87	4423	4181	4253	4181
query88	4513	2404	2416	2404
query89	522	289	278	278
query90	2060	194	202	194
query91	121	94	93	93
query92	62	50	49	49
query93	6545	543	541	541
query94	964	299	301	299
query95	348	260	256	256
query96	616	271	272	271
query97	3171	3116	3032	3032
query98	227	202	204	202
query99	1545	1288	1258	1258
Total cold run time: 319728 ms
Total hot run time: 185753 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.34 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e29fa34413bcc02cb3980b63b57b18fda745c516, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.06	0.05
query4	1.66	0.08	0.08
query5	0.51	0.49	0.49
query6	1.13	0.72	0.73
query7	0.02	0.01	0.01
query8	0.06	0.05	0.04
query9	0.53	0.46	0.48
query10	0.54	0.54	0.54
query11	0.16	0.11	0.11
query12	0.14	0.12	0.12
query13	0.59	0.59	0.58
query14	0.77	0.77	0.77
query15	0.86	0.82	0.81
query16	0.39	0.37	0.37
query17	1.07	1.01	1.04
query18	0.22	0.22	0.21
query19	1.90	1.85	1.69
query20	0.00	0.01	0.01
query21	15.40	0.76	0.66
query22	4.86	7.14	1.62
query23	18.21	1.43	1.24
query24	2.13	0.22	0.22
query25	0.14	0.08	0.08
query26	0.30	0.20	0.22
query27	0.46	0.23	0.22
query28	13.28	1.01	0.99
query29	12.67	3.25	3.25
query30	0.24	0.05	0.05
query31	2.86	0.39	0.39
query32	3.27	0.49	0.48
query33	2.95	2.99	3.01
query34	16.96	4.34	4.38
query35	4.44	4.42	4.41
query36	0.67	0.47	0.49
query37	0.19	0.16	0.16
query38	0.15	0.14	0.15
query39	0.05	0.04	0.04
query40	0.17	0.12	0.12
query41	0.10	0.05	0.04
query42	0.05	0.04	0.05
query43	0.05	0.04	0.05
Total cold run time: 110.5 s
Total hot run time: 30.34 s

Copy link
Contributor

PR approved by anyone and no changes requested.

@wm1581066 wm1581066 added usercase Important user case type label p0_b labels Aug 13, 2024
@deardeng
Copy link
Contributor Author

run buildall

dataroaring
dataroaring previously approved these changes Aug 13, 2024
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 13, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 40415 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ab08cd81917e277b3bd66fb79cb0fa7f30fc8f88, data reload: false

------ Round 1 ----------------------------------
q1	18079	4477	4402	4402
q2	2810	182	191	182
q3	10783	1199	1045	1045
q4	10496	767	724	724
q5	7928	2841	2850	2841
q6	228	139	142	139
q7	972	618	606	606
q8	9645	2036	2051	2036
q9	8690	6553	6555	6553
q10	7059	2179	2184	2179
q11	456	241	253	241
q12	394	215	223	215
q13	18618	3001	2976	2976
q14	291	241	230	230
q15	510	485	497	485
q16	518	398	395	395
q17	958	658	738	658
q18	8164	7577	7472	7472
q19	3627	1092	1077	1077
q20	670	335	331	331
q21	5489	4608	4755	4608
q22	1155	1044	1020	1020
Total cold run time: 117540 ms
Total hot run time: 40415 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4412	4303	4251	4251
q2	375	274	258	258
q3	2921	2676	2643	2643
q4	1872	1654	1594	1594
q5	5369	5380	5327	5327
q6	220	131	132	131
q7	2071	1669	1676	1669
q8	3171	3338	3370	3338
q9	8426	8404	8398	8398
q10	3402	3170	3132	3132
q11	611	512	503	503
q12	798	609	623	609
q13	16317	3037	2981	2981
q14	304	273	276	273
q15	529	491	469	469
q16	462	451	422	422
q17	1762	1511	1484	1484
q18	7619	7536	7430	7430
q19	3934	1636	1639	1636
q20	2043	1795	1783	1783
q21	5241	5144	5141	5141
q22	1107	993	1021	993
Total cold run time: 72966 ms
Total hot run time: 54465 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 183566 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ab08cd81917e277b3bd66fb79cb0fa7f30fc8f88, data reload: false

query1	924	395	374	374
query2	6457	1985	1845	1845
query3	6661	207	214	207
query4	30788	23458	23076	23076
query5	4186	476	478	476
query6	279	186	164	164
query7	4608	289	297	289
query8	247	207	209	207
query9	8513	2393	2403	2393
query10	459	263	263	263
query11	17785	15139	15023	15023
query12	142	98	94	94
query13	1613	367	344	344
query14	9654	6135	7724	6135
query15	228	173	170	170
query16	7705	518	496	496
query17	1169	559	537	537
query18	1816	283	271	271
query19	187	142	136	136
query20	115	100	106	100
query21	207	98	96	96
query22	4271	4060	3894	3894
query23	33706	32987	33166	32987
query24	12516	2778	2860	2778
query25	696	394	372	372
query26	1822	153	155	153
query27	2940	270	271	270
query28	7827	2018	2000	2000
query29	1143	400	393	393
query30	303	149	146	146
query31	983	735	776	735
query32	95	50	58	50
query33	750	279	269	269
query34	1029	464	474	464
query35	848	729	696	696
query36	1108	907	930	907
query37	283	79	80	79
query38	3975	3866	3880	3866
query39	1428	1373	1372	1372
query40	267	114	112	112
query41	76	43	44	43
query42	109	94	95	94
query43	503	460	458	458
query44	1210	725	730	725
query45	197	164	162	162
query46	1108	740	696	696
query47	1886	1774	1772	1772
query48	366	287	294	287
query49	1189	410	398	398
query50	803	401	396	396
query51	6763	6763	6692	6692
query52	99	89	88	88
query53	256	185	183	183
query54	979	436	432	432
query55	75	75	73	73
query56	254	246	247	246
query57	1173	1063	1061	1061
query58	234	214	229	214
query59	2899	2771	2712	2712
query60	294	257	258	257
query61	104	142	109	109
query62	845	653	620	620
query63	210	179	192	179
query64	10612	2233	1722	1722
query65	3230	3130	3128	3128
query66	1351	341	320	320
query67	15178	14901	14937	14901
query68	4514	565	553	553
query69	545	369	278	278
query70	1103	1028	1158	1028
query71	405	273	271	271
query72	6881	2244	2053	2053
query73	758	322	324	322
query74	9073	8870	8842	8842
query75	3409	2667	2657	2657
query76	2395	923	936	923
query77	636	307	300	300
query78	9731	8909	9047	8909
query79	2535	509	524	509
query80	1149	474	489	474
query81	601	219	215	215
query82	804	139	136	136
query83	264	145	145	145
query84	244	76	75	75
query85	1573	270	317	270
query86	476	318	304	304
query87	4422	4325	4270	4270
query88	3909	2466	2414	2414
query89	390	288	286	286
query90	1784	199	201	199
query91	123	96	93	93
query92	68	53	48	48
query93	1958	535	537	535
query94	911	300	279	279
query95	354	250	251	250
query96	597	278	271	271
query97	3217	2997	3034	2997
query98	228	203	200	200
query99	1577	1256	1253	1253
Total cold run time: 298370 ms
Total hot run time: 183566 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.3 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ab08cd81917e277b3bd66fb79cb0fa7f30fc8f88, data reload: false

query1	0.05	0.04	0.04
query2	0.09	0.05	0.04
query3	0.23	0.06	0.05
query4	1.67	0.09	0.09
query5	0.52	0.49	0.48
query6	1.12	0.73	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.48	0.48
query10	0.53	0.54	0.54
query11	0.15	0.11	0.12
query12	0.14	0.13	0.12
query13	0.60	0.61	0.59
query14	0.75	0.78	0.80
query15	0.86	0.83	0.81
query16	0.37	0.36	0.37
query17	0.98	0.94	1.04
query18	0.23	0.23	0.21
query19	1.76	1.77	1.74
query20	0.01	0.01	0.01
query21	15.39	0.76	0.66
query22	4.60	6.91	1.52
query23	18.35	1.30	1.26
query24	2.05	0.21	0.23
query25	0.17	0.08	0.08
query26	0.29	0.22	0.22
query27	0.45	0.23	0.22
query28	13.39	1.01	1.01
query29	12.63	3.32	3.32
query30	0.24	0.04	0.05
query31	2.89	0.39	0.39
query32	3.27	0.48	0.49
query33	2.94	2.97	2.95
query34	16.88	4.48	4.36
query35	4.42	4.46	4.36
query36	0.66	0.49	0.47
query37	0.18	0.15	0.15
query38	0.16	0.15	0.15
query39	0.04	0.03	0.04
query40	0.15	0.13	0.14
query41	0.09	0.04	0.04
query42	0.05	0.04	0.05
query43	0.05	0.05	0.04
Total cold run time: 110.01 s
Total hot run time: 30.3 s

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 13, 2024
@deardeng
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39605 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4f3173456ee7c5e74eea7f4977cf1fc83c127f9e, data reload: false

------ Round 1 ----------------------------------
q1	17922	4540	4426	4426
q2	2883	181	179	179
q3	11174	1221	1168	1168
q4	10331	776	713	713
q5	7832	2875	2844	2844
q6	230	142	143	142
q7	978	605	616	605
q8	9401	2043	2030	2030
q9	8701	6534	6513	6513
q10	7063	2132	2199	2132
q11	466	246	253	246
q12	397	221	217	217
q13	18841	2967	3014	2967
q14	280	229	238	229
q15	516	480	480	480
q16	523	386	384	384
q17	988	728	726	726
q18	8100	7380	7304	7304
q19	3349	981	1024	981
q20	650	326	347	326
q21	5380	4165	3996	3996
q22	1059	997	1000	997
Total cold run time: 117064 ms
Total hot run time: 39605 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4391	4264	4236	4236
q2	385	274	269	269
q3	2863	2633	2566	2566
q4	1890	1661	1634	1634
q5	5370	5399	5385	5385
q6	217	134	131	131
q7	2080	1647	1701	1647
q8	3170	3355	3347	3347
q9	8379	8396	8394	8394
q10	3405	3172	3173	3172
q11	604	504	486	486
q12	764	625	617	617
q13	17625	2989	3003	2989
q14	300	283	259	259
q15	532	487	474	474
q16	475	440	404	404
q17	1821	1491	1495	1491
q18	7675	7645	7283	7283
q19	1670	1615	1595	1595
q20	1990	1813	1797	1797
q21	5176	5112	5126	5112
q22	1108	992	1019	992
Total cold run time: 71890 ms
Total hot run time: 54280 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186030 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4f3173456ee7c5e74eea7f4977cf1fc83c127f9e, data reload: false

query1	913	375	381	375
query2	6460	1941	1929	1929
query3	6639	212	209	209
query4	34554	23281	23129	23129
query5	4191	510	501	501
query6	271	155	159	155
query7	4589	292	296	292
query8	249	204	192	192
query9	8716	2442	2412	2412
query10	431	275	272	272
query11	17910	14935	14931	14931
query12	150	98	97	97
query13	1640	373	362	362
query14	10259	7840	7587	7587
query15	241	171	173	171
query16	7791	497	494	494
query17	1585	559	550	550
query18	1987	295	296	295
query19	197	146	143	143
query20	112	114	109	109
query21	206	102	99	99
query22	4311	4000	3909	3909
query23	34248	33445	33210	33210
query24	11562	2871	2838	2838
query25	656	391	398	391
query26	1286	159	159	159
query27	2870	273	277	273
query28	7455	2034	2040	2034
query29	942	424	425	424
query30	324	151	147	147
query31	976	781	775	775
query32	104	55	59	55
query33	755	286	291	286
query34	948	479	470	470
query35	831	724	717	717
query36	1077	932	928	928
query37	147	81	84	81
query38	4035	3820	3895	3820
query39	1431	1399	1378	1378
query40	277	119	115	115
query41	51	46	47	46
query42	120	102	97	97
query43	518	486	457	457
query44	1243	732	743	732
query45	204	175	162	162
query46	1130	766	726	726
query47	1851	1765	1775	1765
query48	376	293	290	290
query49	1097	431	441	431
query50	799	409	409	409
query51	6984	6732	6593	6593
query52	109	88	99	88
query53	257	183	185	183
query54	1009	472	462	462
query55	78	75	76	75
query56	282	260	256	256
query57	1168	1068	1069	1068
query58	252	258	228	228
query59	2970	2772	2934	2772
query60	300	274	274	274
query61	117	116	230	116
query62	826	651	663	651
query63	204	180	199	180
query64	10756	2288	1707	1707
query65	3188	3180	3134	3134
query66	1428	321	330	321
query67	15501	15048	14958	14958
query68	8827	563	557	557
query69	658	408	311	311
query70	1306	1135	1136	1135
query71	528	271	283	271
query72	7917	2251	1963	1963
query73	1978	330	331	330
query74	9421	8781	8864	8781
query75	5292	2730	2711	2711
query76	5305	1004	958	958
query77	758	300	304	300
query78	9798	9021	8931	8931
query79	8333	547	544	544
query80	1062	509	499	499
query81	574	229	226	226
query82	781	136	140	136
query83	327	145	144	144
query84	270	74	78	74
query85	1365	283	296	283
query86	394	290	296	290
query87	4380	4221	4249	4221
query88	4693	2421	2414	2414
query89	526	289	285	285
query90	1965	204	196	196
query91	125	98	96	96
query92	65	49	55	49
query93	6845	543	542	542
query94	915	293	283	283
query95	360	269	264	264
query96	620	276	273	273
query97	3193	3037	3035	3035
query98	236	205	202	202
query99	1534	1231	1263	1231
Total cold run time: 326495 ms
Total hot run time: 186030 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.81 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4f3173456ee7c5e74eea7f4977cf1fc83c127f9e, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.07	0.07
query5	0.51	0.49	0.48
query6	1.13	0.73	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.56	0.49	0.48
query10	0.54	0.55	0.54
query11	0.15	0.11	0.11
query12	0.16	0.12	0.12
query13	0.60	0.60	0.59
query14	0.78	0.80	0.79
query15	0.87	0.82	0.80
query16	0.36	0.37	0.37
query17	1.02	0.97	1.04
query18	0.23	0.22	0.23
query19	1.76	1.75	1.71
query20	0.01	0.02	0.01
query21	15.39	0.76	0.65
query22	4.38	7.13	2.01
query23	18.29	1.36	1.28
query24	2.14	0.21	0.21
query25	0.16	0.08	0.08
query26	0.30	0.22	0.22
query27	0.46	0.23	0.23
query28	13.28	1.00	1.00
query29	12.64	3.35	3.30
query30	0.24	0.05	0.05
query31	2.89	0.40	0.39
query32	3.25	0.50	0.48
query33	2.96	2.97	2.95
query34	16.92	4.33	4.36
query35	4.45	4.38	4.42
query36	0.66	0.50	0.49
query37	0.18	0.17	0.16
query38	0.16	0.15	0.15
query39	0.05	0.03	0.04
query40	0.16	0.14	0.13
query41	0.10	0.05	0.05
query42	0.05	0.04	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.92 s
Total hot run time: 30.81 s

dataroaring
dataroaring previously approved these changes Aug 13, 2024
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 13, 2024
@deardeng
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 14, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 39827 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f20b48a3613d5a765487f2aeefafde791382660f, data reload: false

------ Round 1 ----------------------------------
q1	17607	4354	4293	4293
q2	2015	183	176	176
q3	11824	1061	1063	1061
q4	10514	800	726	726
q5	7759	2819	2781	2781
q6	224	138	140	138
q7	971	601	593	593
q8	9539	2007	2020	2007
q9	10146	6517	6570	6517
q10	7029	2196	2209	2196
q11	467	244	250	244
q12	386	220	213	213
q13	17755	2984	2955	2955
q14	285	236	231	231
q15	519	481	484	481
q16	479	421	383	383
q17	972	677	694	677
q18	8028	7426	7402	7402
q19	5946	980	1016	980
q20	682	330	319	319
q21	5331	4575	4477	4477
q22	1116	1033	977	977
Total cold run time: 119594 ms
Total hot run time: 39827 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4528	4280	4252	4252
q2	360	278	273	273
q3	2903	2788	2754	2754
q4	1956	1756	1715	1715
q5	5600	5860	5496	5496
q6	236	136	140	136
q7	2193	1753	1783	1753
q8	3296	3444	3422	3422
q9	8755	8870	8805	8805
q10	3480	3204	3259	3204
q11	613	519	536	519
q12	809	641	658	641
q13	16142	3229	3228	3228
q14	330	287	307	287
q15	538	495	494	494
q16	501	453	451	451
q17	1815	1519	1521	1519
q18	8309	7961	7850	7850
q19	5417	1696	1586	1586
q20	2202	1864	1885	1864
q21	5658	5317	5300	5300
q22	1146	1064	1050	1050
Total cold run time: 76787 ms
Total hot run time: 56599 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190960 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f20b48a3613d5a765487f2aeefafde791382660f, data reload: false

query1	1264	881	857	857
query2	6352	1942	1826	1826
query3	10599	3933	3722	3722
query4	58715	24056	23259	23259
query5	5547	517	491	491
query6	518	170	171	170
query7	6448	300	301	300
query8	305	209	202	202
query9	9099	2421	2390	2390
query10	497	274	265	265
query11	18407	15063	15174	15063
query12	161	102	101	101
query13	1607	379	384	379
query14	12718	8241	7923	7923
query15	242	177	171	171
query16	7691	515	532	515
query17	1131	584	574	574
query18	2077	296	293	293
query19	291	157	149	149
query20	118	108	121	108
query21	213	98	99	98
query22	4618	4496	4513	4496
query23	34528	33399	33232	33232
query24	5611	2970	2903	2903
query25	542	376	403	376
query26	692	157	155	155
query27	1806	267	275	267
query28	3817	2005	2015	2005
query29	698	403	402	402
query30	233	151	149	149
query31	958	758	750	750
query32	89	56	53	53
query33	483	283	274	274
query34	859	462	473	462
query35	853	709	751	709
query36	1055	899	929	899
query37	141	85	77	77
query38	4006	3776	3827	3776
query39	1442	1371	1373	1371
query40	202	116	116	116
query41	45	43	43	43
query42	124	100	96	96
query43	529	466	466	466
query44	1105	737	741	737
query45	194	168	166	166
query46	1085	772	744	744
query47	1863	1771	1760	1760
query48	362	288	293	288
query49	748	414	419	414
query50	812	419	408	408
query51	6834	6704	6658	6658
query52	98	93	90	90
query53	258	188	187	187
query54	568	444	448	444
query55	81	81	77	77
query56	285	255	313	255
query57	1122	1070	1070	1070
query58	229	221	246	221
query59	2920	2803	2915	2803
query60	300	267	266	266
query61	101	95	100	95
query62	770	665	645	645
query63	219	186	182	182
query64	9064	2303	1704	1704
query65	3187	3172	3136	3136
query66	646	346	329	329
query67	15147	14869	14943	14869
query68	4848	544	546	544
query69	440	267	269	267
query70	1176	1123	1130	1123
query71	458	286	276	276
query72	7106	2325	1920	1920
query73	760	326	326	326
query74	9317	8831	8850	8831
query75	3411	2706	2754	2706
query76	2558	981	1012	981
query77	535	364	317	317
query78	9792	9024	8986	8986
query79	2481	527	539	527
query80	1266	504	534	504
query81	563	222	222	222
query82	901	133	135	133
query83	254	145	147	145
query84	268	75	76	75
query85	1082	277	275	275
query86	447	297	259	259
query87	4284	4199	4281	4199
query88	3948	2378	2389	2378
query89	408	291	293	291
query90	1934	199	200	199
query91	130	95	98	95
query92	65	48	49	48
query93	2973	542	530	530
query94	883	292	298	292
query95	353	261	285	261
query96	614	271	267	267
query97	3290	3076	3053	3053
query98	272	199	208	199
query99	1509	1262	1250	1250
Total cold run time: 323655 ms
Total hot run time: 190960 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.92 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f20b48a3613d5a765487f2aeefafde791382660f, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.05	0.04
query3	0.23	0.06	0.05
query4	1.66	0.09	0.09
query5	0.51	0.50	0.49
query6	1.12	0.72	0.72
query7	0.01	0.01	0.02
query8	0.05	0.04	0.04
query9	0.56	0.48	0.49
query10	0.55	0.54	0.54
query11	0.15	0.11	0.11
query12	0.15	0.12	0.13
query13	0.60	0.60	0.60
query14	0.77	0.79	0.78
query15	0.88	0.82	0.83
query16	0.37	0.37	0.36
query17	0.96	1.01	0.99
query18	0.22	0.21	0.22
query19	1.79	1.71	1.76
query20	0.01	0.01	0.02
query21	15.39	0.74	0.67
query22	3.92	7.15	2.11
query23	18.29	1.29	1.35
query24	2.14	0.22	0.21
query25	0.16	0.08	0.08
query26	0.30	0.20	0.20
query27	0.46	0.22	0.23
query28	13.29	1.00	0.99
query29	12.63	3.28	3.30
query30	0.23	0.05	0.05
query31	2.87	0.40	0.39
query32	3.27	0.48	0.47
query33	2.98	2.96	2.99
query34	17.02	4.34	4.35
query35	4.42	4.46	4.39
query36	0.65	0.49	0.48
query37	0.19	0.15	0.15
query38	0.15	0.15	0.15
query39	0.05	0.03	0.04
query40	0.15	0.13	0.12
query41	0.09	0.05	0.05
query42	0.05	0.04	0.05
query43	0.05	0.05	0.04
Total cold run time: 109.46 s
Total hot run time: 30.92 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 14, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit e8fea85 into apache:master Aug 15, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.1-merged doing p0_b reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants