[Doris On ES][Optimization] Ignore _total node for efficiency and fully trusted document count #3932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuyunfeng
changed the title
chaoyli
approved these changes
Jun 24, 2020
chaoyli
added
kind/fix
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Jun 28, 2020
…#3932) Prior to this PR, Doris On ES merged another PR apache#3513 which misusing the `total` node. After Doris On ES introduce `terminate_after` (apache#2576), the `total` documents would not be computed, rely on this `total` field would be dangerous， we just rely on the actual document count by counting the `inner hits` node which it means to be. So we just remove all total parsing and related logic from Doris On ES, this maybe improve performance slightly because of ignoring and skipping `total` json node.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, Doris On ES merged another PR #3513 which misusing the
totalnode. After Doris On ES introduceterminate_after(#2576), thetotaldocuments would not be computed, rely on thistotalfield would be dangerous， we just rely on the actual document count by counting theinner hitsnode which it means to be. So we just remove all total parsing and related logic from Doris On ES, this maybe improve performance slightly because of ignoring and skippingtotaljson node.