Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug](compatibility) fix percentile_approx function coredump when upgrade #39320

Closed
wants to merge 1 commit into from

Conversation

zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Aug 13, 2024

Proposed changes

this pr #37330 have change the nullable of agg function,
But it's shouldn't change the old percentile_approx function.
this could cause it's core dump when upgrade.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhangstar333
Copy link
Contributor Author

run buildall

@zhangstar333
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39520 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2db2a5eba068e6fae4402d0bba483434bdf1780d, data reload: false

------ Round 1 ----------------------------------
q1	17609	4375	4341	4341
q2	2011	173	172	172
q3	11773	1028	1162	1028
q4	10526	760	675	675
q5	7761	2795	2707	2707
q6	220	132	133	132
q7	962	581	587	581
q8	9521	2014	2048	2014
q9	10171	6545	6532	6532
q10	7017	2216	2129	2129
q11	449	240	244	240
q12	392	218	216	216
q13	17759	2948	2965	2948
q14	292	237	246	237
q15	521	480	481	480
q16	501	386	384	384
q17	974	710	658	658
q18	7958	7342	7398	7342
q19	6055	1079	1010	1010
q20	666	341	321	321
q21	5443	4493	4362	4362
q22	1078	1013	1011	1011
Total cold run time: 119659 ms
Total hot run time: 39520 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4430	4255	4212	4212
q2	375	283	273	273
q3	2855	2711	2771	2711
q4	1931	1641	1715	1641
q5	5602	5601	5518	5518
q6	220	130	137	130
q7	2182	1792	1774	1774
q8	3310	3498	3407	3407
q9	8741	8835	8822	8822
q10	3532	3183	3206	3183
q11	594	506	507	506
q12	822	622	656	622
q13	17145	3152	3153	3152
q14	310	303	282	282
q15	535	493	510	493
q16	489	440	443	440
q17	1837	1533	1512	1512
q18	8033	8067	7681	7681
q19	2930	1537	1472	1472
q20	2110	1890	1854	1854
q21	5525	5277	5352	5277
q22	1145	1031	1032	1031
Total cold run time: 74653 ms
Total hot run time: 55993 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 188265 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2db2a5eba068e6fae4402d0bba483434bdf1780d, data reload: false

query1	1239	875	865	865
query2	6377	1885	1860	1860
query3	10596	3820	3828	3820
query4	58802	24114	23093	23093
query5	5812	490	488	488
query6	510	173	165	165
query7	6497	288	284	284
query8	303	208	210	208
query9	9327	2429	2392	2392
query10	539	281	243	243
query11	17216	15021	15182	15021
query12	162	114	106	106
query13	1620	364	361	361
query14	11814	6254	6825	6254
query15	254	165	167	165
query16	7879	492	512	492
query17	1164	589	553	553
query18	2135	290	291	290
query19	280	147	158	147
query20	121	122	107	107
query21	204	98	100	98
query22	4567	4356	4234	4234
query23	34041	33643	33276	33276
query24	5644	2799	2850	2799
query25	528	373	379	373
query26	688	159	156	156
query27	1816	272	264	264
query28	3697	2011	2009	2009
query29	714	414	408	408
query30	237	152	142	142
query31	937	754	711	711
query32	93	56	52	52
query33	534	276	282	276
query34	842	462	464	462
query35	872	713	719	713
query36	1052	938	930	930
query37	141	82	85	82
query38	3925	3922	3798	3798
query39	1463	1496	1391	1391
query40	197	116	118	116
query41	47	44	48	44
query42	118	96	92	92
query43	490	465	447	447
query44	1120	718	717	717
query45	194	160	160	160
query46	1089	755	737	737
query47	1835	1786	1738	1738
query48	356	289	292	289
query49	737	410	404	404
query50	792	397	393	393
query51	6766	6649	6667	6649
query52	104	92	87	87
query53	257	183	178	178
query54	550	438	439	438
query55	75	75	73	73
query56	260	243	237	237
query57	1144	1042	1070	1042
query58	228	222	240	222
query59	2995	2877	2705	2705
query60	295	255	253	253
query61	132	93	94	93
query62	762	651	630	630
query63	203	174	178	174
query64	9043	2294	1671	1671
query65	3205	3150	3130	3130
query66	705	324	326	324
query67	15239	14843	14805	14805
query68	4696	553	547	547
query69	400	271	273	271
query70	1109	1117	1112	1112
query71	422	264	267	264
query72	6936	2236	2040	2040
query73	769	325	320	320
query74	9166	8684	8723	8684
query75	3376	2637	2701	2637
query76	2664	1006	1032	1006
query77	568	332	304	304
query78	10327	9002	9012	9002
query79	2456	517	517	517
query80	1404	477	480	477
query81	544	228	222	222
query82	908	139	132	132
query83	305	145	146	145
query84	280	79	75	75
query85	991	280	274	274
query86	431	303	295	295
query87	4470	4190	4171	4171
query88	4438	2529	2385	2385
query89	394	290	281	281
query90	1847	202	196	196
query91	131	109	108	108
query92	58	51	55	51
query93	3223	537	529	529
query94	829	372	294	294
query95	350	258	257	257
query96	583	272	265	265
query97	3186	3004	3029	3004
query98	223	215	193	193
query99	1735	1285	1271	1271
Total cold run time: 322799 ms
Total hot run time: 188265 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.28 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2db2a5eba068e6fae4402d0bba483434bdf1780d, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.66	0.09	0.08
query5	0.50	0.50	0.49
query6	1.13	0.72	0.73
query7	0.02	0.01	0.02
query8	0.05	0.04	0.05
query9	0.53	0.47	0.48
query10	0.52	0.55	0.55
query11	0.15	0.11	0.11
query12	0.14	0.12	0.12
query13	0.60	0.61	0.58
query14	0.76	0.78	0.78
query15	0.86	0.81	0.82
query16	0.37	0.37	0.37
query17	1.02	1.06	1.05
query18	0.22	0.24	0.21
query19	1.77	1.78	1.68
query20	0.02	0.01	0.01
query21	15.39	0.73	0.65
query22	4.46	7.25	1.40
query23	18.28	1.37	1.23
query24	2.19	0.22	0.21
query25	0.16	0.08	0.08
query26	0.31	0.21	0.22
query27	0.45	0.23	0.22
query28	13.23	1.02	1.01
query29	12.62	3.49	3.46
query30	0.24	0.05	0.04
query31	2.92	0.38	0.40
query32	3.26	0.46	0.48
query33	2.92	3.04	2.94
query34	16.95	4.35	4.33
query35	4.48	4.39	4.41
query36	0.65	0.48	0.51
query37	0.18	0.15	0.16
query38	0.15	0.15	0.15
query39	0.05	0.03	0.03
query40	0.16	0.13	0.13
query41	0.08	0.04	0.04
query42	0.06	0.04	0.05
query43	0.04	0.05	0.04
Total cold run time: 109.9 s
Total hot run time: 30.28 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants