Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](upgrade) fix partition key problem introduced by be418110c #39373

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

dataroaring
Copy link
Contributor

Proposed changes

fix #31613

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@dataroaring
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the doing label Aug 14, 2024
@gavinchou gavinchou changed the title [fix](upgrade) fix partition key problem introduced by be418110c [fix](upgrade) fix partition key problem introduced by #31613 Aug 14, 2024
@gavinchou gavinchou changed the title [fix](upgrade) fix partition key problem introduced by #31613 [fix](upgrade) fix partition key problem introduced by be418110c Aug 14, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 14, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 37042 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bb0e91a690b3623cc94185719641b9e3778b883f, data reload: false

------ Round 1 ----------------------------------
q1	17635	4309	4291	4291
q2	2009	178	188	178
q3	11767	1004	1024	1004
q4	10488	729	701	701
q5	7769	2824	2764	2764
q6	225	136	133	133
q7	943	595	593	593
q8	9531	2021	2019	2019
q9	8632	6500	6516	6500
q10	6996	2183	2120	2120
q11	453	242	244	242
q12	386	218	215	215
q13	17780	2935	2971	2935
q14	293	231	244	231
q15	517	478	485	478
q16	498	399	373	373
q17	987	678	719	678
q18	7272	6827	6786	6786
q19	6452	1128	923	923
q20	709	346	359	346
q21	3923	2562	2881	2562
q22	1104	991	970	970
Total cold run time: 116369 ms
Total hot run time: 37042 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4488	4283	4258	4258
q2	364	270	266	266
q3	2885	2610	2549	2549
q4	1871	1636	1675	1636
q5	5656	5711	5651	5651
q6	230	137	133	133
q7	2118	1742	1717	1717
q8	3270	3518	3435	3435
q9	8856	8788	8817	8788
q10	3587	3284	3279	3279
q11	595	509	517	509
q12	854	635	610	610
q13	16203	3112	3175	3112
q14	320	293	270	270
q15	523	490	487	487
q16	496	432	458	432
q17	1813	1557	1526	1526
q18	8101	8081	7817	7817
q19	1739	1432	1664	1432
q20	2138	1925	1893	1893
q21	9514	5278	5213	5213
q22	1066	983	1005	983
Total cold run time: 76687 ms
Total hot run time: 55996 ms

@doris-robot
Copy link

TPC-H: Total hot run time: 37754 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bb0e91a690b3623cc94185719641b9e3778b883f, data reload: false

------ Round 1 ----------------------------------
q1	17671	4335	4258	4258
q2	2036	181	179	179
q3	11907	1234	1143	1143
q4	10515	828	801	801
q5	7734	2827	2822	2822
q6	223	138	139	138
q7	950	596	599	596
q8	9559	2033	2068	2033
q9	8780	6520	6462	6462
q10	7014	2190	2186	2186
q11	440	246	237	237
q12	390	229	219	219
q13	18870	2980	3011	2980
q14	287	239	247	239
q15	531	487	513	487
q16	504	405	384	384
q17	986	644	661	644
q18	7446	6714	6735	6714
q19	6301	1108	996	996
q20	752	332	329	329
q21	3911	2931	3012	2931
q22	1111	1010	976	976
Total cold run time: 117918 ms
Total hot run time: 37754 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4471	4258	4303	4258
q2	386	280	269	269
q3	2832	2634	2610	2610
q4	2016	1741	1767	1741
q5	5637	5723	5616	5616
q6	223	131	130	130
q7	2167	1733	1741	1733
q8	3318	3510	3464	3464
q9	8800	8767	8903	8767
q10	3529	3238	3286	3238
q11	606	523	495	495
q12	773	629	604	604
q13	15781	3134	3148	3134
q14	318	281	292	281
q15	538	498	488	488
q16	504	447	440	440
q17	1834	1554	1517	1517
q18	7991	8062	7945	7945
q19	1815	1591	1545	1545
q20	2156	1870	1870	1870
q21	5614	5388	5538	5388
q22	1080	1012	1027	1012
Total cold run time: 72389 ms
Total hot run time: 56545 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 189635 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bb0e91a690b3623cc94185719641b9e3778b883f, data reload: false

query1	1241	888	849	849
query2	6450	1958	1834	1834
query3	10599	4022	3788	3788
query4	60531	24686	23080	23080
query5	5719	507	485	485
query6	497	190	161	161
query7	6460	303	288	288
query8	294	201	197	197
query9	8954	2431	2417	2417
query10	492	260	255	255
query11	17650	14979	15314	14979
query12	170	100	100	100
query13	1566	390	374	374
query14	11705	7072	7062	7062
query15	247	175	172	172
query16	7149	532	527	527
query17	1131	579	580	579
query18	1944	339	315	315
query19	293	160	152	152
query20	122	120	117	117
query21	209	109	99	99
query22	4408	4412	4172	4172
query23	34529	33305	33327	33305
query24	5568	2866	2848	2848
query25	551	402	420	402
query26	697	160	160	160
query27	1787	286	281	281
query28	3705	2087	2052	2052
query29	676	425	423	423
query30	226	162	150	150
query31	938	738	749	738
query32	84	57	56	56
query33	495	299	284	284
query34	856	471	469	469
query35	817	727	721	721
query36	1061	949	945	945
query37	142	84	77	77
query38	3953	3814	3772	3772
query39	1425	1431	1387	1387
query40	200	115	119	115
query41	47	45	44	44
query42	112	98	95	95
query43	500	466	464	464
query44	1073	732	745	732
query45	205	165	166	165
query46	1108	736	761	736
query47	1886	1762	1749	1749
query48	365	295	283	283
query49	766	425	435	425
query50	814	398	405	398
query51	6778	6752	6672	6672
query52	102	102	89	89
query53	251	181	183	181
query54	560	464	455	455
query55	75	75	77	75
query56	280	269	260	260
query57	1151	1051	1045	1045
query58	325	216	240	216
query59	3103	2682	2838	2682
query60	320	260	263	260
query61	107	96	95	95
query62	755	651	651	651
query63	228	178	182	178
query64	3223	1723	1717	1717
query65	3181	3136	3136	3136
query66	663	326	320	320
query67	15399	15070	15120	15070
query68	4805	556	548	548
query69	619	270	273	270
query70	1202	1135	1134	1134
query71	482	274	270	270
query72	7524	2248	2014	2014
query73	839	321	321	321
query74	9387	8711	8720	8711
query75	3794	2729	2703	2703
query76	3053	1001	906	906
query77	742	299	292	292
query78	9615	9077	9083	9077
query79	7824	527	531	527
query80	1027	483	480	480
query81	588	223	228	223
query82	650	146	134	134
query83	357	151	156	151
query84	270	74	77	74
query85	873	264	263	263
query86	320	305	272	272
query87	4405	4200	4261	4200
query88	4492	2285	2304	2285
query89	531	284	289	284
query90	2234	190	189	189
query91	119	93	96	93
query92	60	48	50	48
query93	6081	535	529	529
query94	869	295	264	264
query95	340	249	246	246
query96	609	280	267	267
query97	3206	3024	3085	3024
query98	220	208	211	208
query99	1543	1266	1248	1248
Total cold run time: 327598 ms
Total hot run time: 189635 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.88 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bb0e91a690b3623cc94185719641b9e3778b883f, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.06
query4	1.66	0.08	0.08
query5	0.49	0.48	0.48
query6	1.13	0.73	0.72
query7	0.02	0.02	0.01
query8	0.05	0.04	0.05
query9	0.55	0.48	0.48
query10	0.54	0.54	0.55
query11	0.15	0.12	0.12
query12	0.16	0.12	0.12
query13	0.60	0.62	0.59
query14	0.76	0.77	0.79
query15	0.85	0.82	0.83
query16	0.38	0.37	0.37
query17	1.04	0.97	0.96
query18	0.24	0.22	0.22
query19	1.89	1.68	1.72
query20	0.02	0.01	0.01
query21	15.42	0.75	0.65
query22	3.91	6.93	2.00
query23	18.36	1.32	1.39
query24	2.08	0.21	0.24
query25	0.14	0.09	0.08
query26	0.31	0.22	0.21
query27	0.45	0.23	0.22
query28	13.31	1.04	1.01
query29	12.61	3.30	3.28
query30	0.24	0.05	0.05
query31	2.90	0.40	0.40
query32	3.24	0.48	0.49
query33	2.95	2.97	3.05
query34	17.10	4.38	4.40
query35	4.42	4.40	4.43
query36	0.66	0.48	0.49
query37	0.18	0.16	0.15
query38	0.15	0.15	0.15
query39	0.05	0.04	0.04
query40	0.16	0.12	0.12
query41	0.09	0.05	0.05
query42	0.05	0.05	0.06
query43	0.04	0.04	0.04
Total cold run time: 109.7 s
Total hot run time: 30.88 s

@dataroaring dataroaring merged commit 5c68c92 into apache:master Aug 15, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.1-merged doing reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants