Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webserver] Introduce mustache to simplify BE's website render #4062

Merged
merged 3 commits into from
Jul 16, 2020
Merged

[webserver] Introduce mustache to simplify BE's website render #4062

merged 3 commits into from
Jul 16, 2020

Conversation

acelyc111
Copy link
Member

cpp-mustache is a C++ implementation of a Mustache template engine
with support for RapidJSON, and in order to simplify RapidJSON object
building, we introduce class EasyJson from Apache Kudu.

@acelyc111
[webserver] Introduce mustache to simplify BE's website render
a1ce32b 
cpp-mustache is a C++ implementation of a Mustache template engine
with support for RapidJSON, and in order to simplify RapidJSON object
building, we introduce class EasyJson from Apache Kudu.
@acelyc111
Copy link
Member Author

acelyc111 commented Jul 9, 2020 •
edited
Loading

Ref: #3911
easy_json.{h,.cc} and easy_json-test.cpp are copied from Kudu repository, mustache.{h, cc} are copied from cpp-mustache repository.
Now BE's web site looks like:
image

morningman
morningman reviewed Jul 15, 2020
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help to comment out the logs/ entry? which is not implemented yet.

@acelyc111
Copy link
Member Author

Could you help to comment out the logs/ entry? which is not implemented yet.

@morningman I've updated to disable to show it on navigate bar.

morningman
morningman approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added approved Indicates a PR has been approved by one committer. kind/improvement labels Jul 15, 2020
@morningman morningman self-assigned this Jul 15, 2020
@morningman morningman added the area/be/frontpage Issues or PRs related to the BE's frontpage label Jul 15, 2020
@WingsGo WingsGo mentioned this pull request Jul 15, 2020
Open
@morningman morningman merged commit d07a23e into apache:master Jul 16, 2020
@EmmyMiao87 EmmyMiao87 mentioned this pull request Aug 17, 2020
Closed
acelyc111 added a commit to acelyc111/incubator-doris that referenced this pull request Jan 20, 2021
@acelyc111
[webserver] Introduce mustache to simplify BE's website render (apach…
6a31d0d 
…e#4062)

cpp-mustache is a C++ implementation of a Mustache template engine
with support for RapidJSON, and in order to simplify RapidJSON object
building, we introduce class EasyJson from Apache Kudu.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningman morningman morningman approved these changes

Assignees

@morningman morningman

Labels
approved Indicates a PR has been approved by one committer. area/be/frontpage Issues or PRs related to the BE's frontpage kind/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acelyc111 @morningman