-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improvement](jdbc catalog) Optimize JdbcCatalog case mapping stability #40891
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 41326 ms
|
TPC-DS: Total hot run time: 198860 ms
|
ClickBench: Total hot run time: 31.77 s
|
…ping stability (#41330) pick #40891 This PR makes the following changes to the uppercase and lowercase mapping of JdbcCatalog 1. The identifierMapping is managed by JdbcExternalCatalog instead of JdbcClient to better control its lifecycle 2. The identifierMapping no longer loads remoteName alone, but Catalog controls the loading uniformly 3. The identifierMapping will be loaded when each FE performs makeSureInitialized() to ensure that each FE has a mapping 4. The initialization of mapping will only be performed once in makeSureInitialized(), which means that even if you use metaCache, if your source data is updated when identifierMapping is enabled, you must refresh the catalog to query normally. 5. The identifierMapping is only responsible for the properties of the Catalog and is no longer affected by the fe config, simplifying the processing logic 6. If lower_case_mete_names is false and meta_names_mapping is empty in the catalog properties, the identifierMapping will no longer take effect, further enhancing the stability of the default settings 7. The JdbcClient is no longer closed during onRefreshCache, reducing the repeated creation of resources, improving reuse, and reducing the leakage of some global shared threads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
…ty (apache#40891) This PR makes the following changes to the uppercase and lowercase mapping of JdbcCatalog 1. The identifierMapping is managed by JdbcExternalCatalog instead of JdbcClient to better control its lifecycle 2. The identifierMapping no longer loads remoteName alone, but Catalog controls the loading uniformly 3. The identifierMapping will be loaded when each FE performs makeSureInitialized() to ensure that each FE has a mapping 4. The initialization of mapping will only be performed once in makeSureInitialized(), which means that even if you use metaCache, if your source data is updated when identifierMapping is enabled, you must refresh the catalog to query normally. 5. The identifierMapping is only responsible for the properties of the Catalog and is no longer affected by the fe config, simplifying the processing logic 6. If lower_case_mete_names is false and meta_names_mapping is empty in the catalog properties, the identifierMapping will no longer take effect, further enhancing the stability of the default settings 7. The JdbcClient is no longer closed during onRefreshCache, reducing the repeated creation of resources, improving reuse, and reducing the leakage of some global shared threads
This PR makes the following changes to the uppercase and lowercase mapping of JdbcCatalog