Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](pipelinex) fix fragment instance progress reports (#40325) #40987

Merged
merged 1 commit into from
Sep 19, 2024
Merged

[fix](pipelinex) fix fragment instance progress reports (#40325) #40987

merged 1 commit into from
Sep 19, 2024

Conversation

kaijchen
Copy link
Contributor

backport #40325

@kaijchen
[fix](pipelinex) fix fragment instance progress reports (apache#40325)
c9ef11f 
Fix progress in `show load` not 100% when load finished.

PipelineX has deprecated `fragmentInstanceId` in
`TReportExecStatusParams`.
The `finishedScanNums` should be reported with distinct
`fragmentInstanceId` to prevent being overwritten.

Before

```
| 38024 | lineitem_dup_1_replication_s3_2 | FINISHED | 30.00% (3/10)     | BROKER | ...
```

After

```
| 39025 | lineitem_dup_1_replication_s3_3 | FINISHED | 100.00% (10/10)   | BROKER | ...
```
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@kaijchen
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.16% (9330/25800)
Line Coverage: 27.73% (76663/276470)
Region Coverage: 26.51% (39370/148505)
Branch Coverage: 23.31% (20048/86016)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c9ef11f3bd070637a906db5681a9db59890ab514_c9ef11f3bd070637a906db5681a9db59890ab514/report/index.html

@yiguolei yiguolei merged commit 549bc3e into apache:branch-2.1 Sep 19, 2024
20 of 22 checks passed
@yiguolei yiguolei mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
meta-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaijchen @doris-robot @yiguolei