Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](Nereids) simplify range result wrong when reference is nullable #41356

Merged
merged 1 commit into from
Oct 17, 2024
Merged

[fix](Nereids) simplify range result wrong when reference is nullable #41356

merged 1 commit into from
Oct 17, 2024

Conversation

morrySnow
Copy link
Contributor

if reference is nullable and simplify result is boolean literal.
the real result should be:

IF(${reference} IS NULL, NULL, ${not_null_result})

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow
Copy link
Contributor Author

run feut

@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow morrySnow force-pushed the fix_simplify_range branch 2 times, most recently from 00c412b to 6b4c6f5 Compare October 15, 2024 08:43
@morrySnow
Copy link
Contributor Author

run buildall

starocean999
starocean999 previously approved these changes Oct 15, 2024
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 15, 2024
@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow
[fix](Nereids) simplify range result wrong when reference is nullable
5c4fa66 
if reference is nullable and simplify result should be

IF(${reference} IS NULL, ${nullable_result}, ${not_null_result})
@morrySnow
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@morrySnow morrySnow merged commit f64ed20 into apache:master Oct 17, 2024
25 of 27 checks passed
@morrySnow morrySnow deleted the fix_simplify_range branch October 17, 2024 06:23
@morrySnow morrySnow mentioned this pull request Oct 18, 2024
Merged
yiguolei pushed a commit that referenced this pull request Oct 18, 2024
@morrySnow
[fix](Nereids) simplify range result wrong when reference is nullable (…
c412de8 
…#41356) (#42096)

pick from master #41356

if reference is nullable and simplify result is boolean literal. the
real result should be:

IF(${reference} IS NULL, NULL, ${not_null_result})
@morrySnow morrySnow mentioned this pull request Oct 24, 2024
Merged
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 24, 2024
@morrySnow
[fix](Nereids) simplify range result wrong when reference is nullable (…
7b0d9fa 
…apache#41356)

pick from master apache#41356

if reference is nullable and simplify result is boolean literal.
the real result should be:

IF(${reference} IS NULL, NULL, ${not_null_result})
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 25, 2024
@morrySnow
[fix](Nereids) simplify range result wrong when reference is nullable (…
2fa2669 
…apache#41356)

pick from master apache#41356

if reference is nullable and simplify result is boolean literal.
the real result should be:

IF(${reference} IS NULL, NULL, ${not_null_result})
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 25, 2024
@morrySnow
[fix](Nereids) simplify range result wrong when reference is nullable (…
8dca006 
…apache#41356)

pick from master apache#41356

if reference is nullable and simplify result is boolean literal.
the real result should be:

IF(${reference} IS NULL, NULL, ${not_null_result})
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 28, 2024
@morrySnow
[fix](Nereids) simplify range result wrong when reference is nullable (…
d6f0342 
…apache#41356)

pick from master apache#41356

if reference is nullable and simplify result is boolean literal.
the real result should be:

IF(${reference} IS NULL, NULL, ${not_null_result})
morrySnow added a commit that referenced this pull request Oct 29, 2024
@morrySnow
[fix](Nereids) simplify range result wrong when reference is nullable (…
25b7d34 
…#41356) (#42373)

pick from master #41356

if reference is nullable and simplify result is boolean literal. the
real result should be:

IF(${reference} IS NULL, NULL, ${not_null_result})
@morrySnow morrySnow mentioned this pull request Oct 31, 2024
Merged
morrySnow added a commit that referenced this pull request Nov 1, 2024
@morrySnow
[fix](Nereids) simplify range result wrong when reference is nullable (…
60a852e 
…#41356) (#42990)

pick from master #41356

if reference is nullable and simplify result is boolean literal. the
real result should be:

IF(${reference} IS NULL, NULL, ${not_null_result})
@yiguolei yiguolei mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starocean999 starocean999 starocean999 approved these changes

@englefly englefly englefly approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.16-merged dev/2.1.7-merged dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@morrySnow @doris-robot @englefly @starocean999 @yiguolei