Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](cloud) enable_file_cache for cloud by default #41502

Merged
merged 3 commits into from
Oct 11, 2024
Merged

[fix](cloud) enable_file_cache for cloud by default #41502

merged 3 commits into from
Oct 11, 2024

Conversation

dataroaring
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@dataroaring
Copy link
Contributor Author

run buildall

dataroaring added a commit that referenced this pull request Sep 30, 2024
@dataroaring
[fix](cloud) enable_file_cache for cloud by default (#41502)
222c46c
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.32% (9630/25805)
Line Coverage: 28.71% (79891/278285)
Region Coverage: 28.14% (41298/146753)
Branch Coverage: 24.77% (21046/84976)
Coverage Report: http://coverage.selectdb-in.cc/coverage/57fd4ea5e30362aabf39208b1e57aff21cd17bf6_57fd4ea5e30362aabf39208b1e57aff21cd17bf6/report/index.html

@dataroaring
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.31% (9629/25805)
Line Coverage: 28.69% (79833/278287)
Region Coverage: 28.13% (41279/146753)
Branch Coverage: 24.76% (21039/84976)
Coverage Report: http://coverage.selectdb-in.cc/coverage/05192732687b5ca1657befb8c71e7a3b56b4bf06_05192732687b5ca1657befb8c71e7a3b56b4bf06/report/index.html

cjj2010
cjj2010 suggested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@cjj2010 cjj2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust the input parameters of set_comfig

@dataroaring
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.28% (9631/25834)
Line Coverage: 28.67% (79858/278590)
Region Coverage: 28.10% (41291/146933)
Branch Coverage: 24.72% (21038/85088)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6470487704aa5bdc859d2cb8b5ea19ea5516e446_6470487704aa5bdc859d2cb8b5ea19ea5516e446/report/index.html

@dataroaring
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

cjj2010
cjj2010 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@cjj2010 cjj2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

be/src/common/config.cpp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be modified to “auto st = config::set_config("enable_file_cache", "true", true, true);”

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.24% (9643/25894)
Line Coverage: 28.55% (79972/280120)
Region Coverage: 27.98% (41339/147740)
Branch Coverage: 24.58% (21042/85590)
Coverage Report: http://coverage.selectdb-in.cc/coverage/38ba931199f1254a27bf3bac87bf6e8ca39e8746_38ba931199f1254a27bf3bac87bf6e8ca39e8746/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit 954f98c into apache:master Oct 11, 2024
25 of 28 checks passed
@gavinchou gavinchou mentioned this pull request Oct 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjj2010 cjj2010 cjj2010 approved these changes

@gavinchou gavinchou gavinchou approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.2-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dataroaring @doris-robot @gavinchou @cjj2010