Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick](branch-2.1) Pick "[Fix](LZ4 compression) Fix wrong LZ4 compression max input size limit (#41239)" #41505

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

Yukang-Lian
Copy link
Collaborator

Proposed changes

LZ4 compression max supported value is LZ4_MAX_INPUT_SIZE, which is 0x7E000000(2,113,929,216 bytes). Doris use wrong max size INT_MAX, which is 2,147,483,647, to check. If input data size is between this two size, then it can pass the check but LZ4 compression will fail.

This PR fix it.

Proposed changes

Issue Number: close #xxx

…apache#41239)

## Proposed changes

LZ4 compression max supported value is LZ4_MAX_INPUT_SIZE, which is
0x7E000000(2,113,929,216 bytes). Doris use wrong max size INT_MAX, which
is 2,147,483,647, to check. If input data size is between this two size,
then it can pass the check but LZ4 compression will fail.

This PR fix it.

<!--Describe your changes.-->
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Yukang-Lian
Copy link
Collaborator Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.10% (9340/25874)
Line Coverage: 27.66% (76703/277328)
Region Coverage: 26.45% (39383/148874)
Branch Coverage: 23.24% (20035/86224)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1e4bf97a9a1d0d8f7aa1bbd49311675361f18de9_1e4bf97a9a1d0d8f7aa1bbd49311675361f18de9/report/index.html

@yiguolei yiguolei merged commit d33a3eb into apache:branch-2.1 Oct 1, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants