Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve](cloud) set default vaule for file_path #41507

Merged
merged 1 commit into from
Oct 11, 2024
Merged

[improve](cloud) set default vaule for file_path #41507

merged 1 commit into from
Oct 11, 2024

Conversation

dataroaring
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@dataroaring
Copy link
Contributor Author

run buildall

dataroaring added a commit that referenced this pull request Sep 30, 2024
@dataroaring
[improve](cloud) set default vaule for file_path (#41507)
5bc77b1
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.32% (9631/25805)
Line Coverage: 28.70% (79859/278281)
Region Coverage: 28.14% (41293/146751)
Branch Coverage: 24.77% (21046/84974)
Coverage Report: http://coverage.selectdb-in.cc/coverage/21cea3a779ffa7c44b311cd48304cf067f954955_21cea3a779ffa7c44b311cd48304cf067f954955/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 40538 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 21cea3a779ffa7c44b311cd48304cf067f954955, data reload: false

------ Round 1 ----------------------------------
q1	17563	7348	7205	7205
q2	2023	277	269	269
q3	12039	1051	1118	1051
q4	10566	751	748	748
q5	7769	2849	2818	2818
q6	233	153	149	149
q7	991	628	612	612
q8	9355	1872	1874	1872
q9	6588	6432	6395	6395
q10	6946	2266	2312	2266
q11	429	251	248	248
q12	407	217	217	217
q13	17785	2930	2992	2930
q14	241	207	213	207
q15	563	528	535	528
q16	661	575	601	575
q17	969	609	547	547
q18	7240	6624	6698	6624
q19	1340	922	895	895
q20	474	209	204	204
q21	3896	3221	3176	3176
q22	1093	1002	1004	1002
Total cold run time: 109171 ms
Total hot run time: 40538 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7240	7240	7218	7218
q2	328	230	231	230
q3	2896	2941	2938	2938
q4	2108	1921	1883	1883
q5	5748	5745	5714	5714
q6	228	151	145	145
q7	2276	1851	1817	1817
q8	3387	3514	3442	3442
q9	8969	8919	8820	8820
q10	3585	3585	3496	3496
q11	574	484	517	484
q12	827	604	663	604
q13	10065	3185	3179	3179
q14	313	278	269	269
q15	586	542	529	529
q16	693	649	643	643
q17	1904	1614	1613	1613
q18	8217	7676	7684	7676
q19	1692	1367	1560	1367
q20	2131	1888	1883	1883
q21	5645	5352	5262	5262
q22	1104	1092	1071	1071
Total cold run time: 70516 ms
Total hot run time: 60283 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191557 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 21cea3a779ffa7c44b311cd48304cf067f954955, data reload: false

query1	907	395	393	393
query2	6236	2116	2070	2070
query3	8689	195	198	195
query4	33674	23535	23302	23302
query5	3488	463	452	452
query6	280	178	172	172
query7	4194	307	304	304
query8	289	223	234	223
query9	9378	2649	2639	2639
query10	451	282	291	282
query11	17787	15160	15368	15160
query12	154	100	96	96
query13	1592	483	451	451
query14	9669	7362	7558	7362
query15	252	170	178	170
query16	7595	412	482	412
query17	1678	634	590	590
query18	2059	324	325	324
query19	361	159	167	159
query20	121	117	109	109
query21	222	110	106	106
query22	4800	4695	4512	4512
query23	34812	34008	34150	34008
query24	11008	2784	2838	2784
query25	615	411	399	399
query26	1123	164	160	160
query27	2272	299	307	299
query28	7400	2394	2395	2394
query29	786	447	430	430
query30	263	157	151	151
query31	1042	810	765	765
query32	98	55	53	53
query33	754	299	290	290
query34	909	507	532	507
query35	903	740	748	740
query36	1106	959	964	959
query37	150	96	93	93
query38	4161	3886	3847	3847
query39	1484	1448	1419	1419
query40	210	98	99	98
query41	48	42	45	42
query42	124	96	93	93
query43	532	488	484	484
query44	1174	798	779	779
query45	201	162	164	162
query46	1137	692	703	692
query47	1963	1889	1857	1857
query48	433	339	350	339
query49	916	407	404	404
query50	836	425	454	425
query51	7020	6910	6920	6910
query52	95	91	86	86
query53	254	179	173	173
query54	1230	461	462	461
query55	77	77	77	77
query56	273	265	261	261
query57	1283	1183	1143	1143
query58	242	241	234	234
query59	3271	3071	2840	2840
query60	289	254	254	254
query61	105	100	106	100
query62	868	665	663	663
query63	212	181	182	181
query64	4241	630	645	630
query65	3296	3158	3189	3158
query66	906	303	295	295
query67	15929	15722	15625	15625
query68	4383	566	563	563
query69	530	283	296	283
query70	1175	1118	1060	1060
query71	377	263	261	261
query72	7300	4134	4001	4001
query73	776	351	346	346
query74	10063	8907	9020	8907
query75	3538	2695	2682	2682
query76	3087	904	850	850
query77	614	299	289	289
query78	10725	9746	9551	9551
query79	1994	589	585	585
query80	1847	444	452	444
query81	574	239	238	238
query82	701	135	141	135
query83	294	149	133	133
query84	275	79	73	73
query85	1613	304	289	289
query86	464	292	293	292
query87	4407	4325	4317	4317
query88	3469	2452	2389	2389
query89	410	284	286	284
query90	2122	183	185	183
query91	138	108	106	106
query92	73	47	46	46
query93	2088	552	547	547
query94	1210	293	310	293
query95	362	260	259	259
query96	617	283	282	282
query97	3443	3193	3138	3138
query98	215	201	195	195
query99	1704	1299	1289	1289
Total cold run time: 300515 ms
Total hot run time: 191557 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.75 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 21cea3a779ffa7c44b311cd48304cf067f954955, data reload: false

query1	0.05	0.05	0.05
query2	0.06	0.02	0.03
query3	0.23	0.07	0.06
query4	1.65	0.10	0.10
query5	0.53	0.51	0.52
query6	1.12	0.72	0.73
query7	0.01	0.02	0.01
query8	0.04	0.03	0.03
query9	0.56	0.51	0.51
query10	0.55	0.57	0.55
query11	0.13	0.11	0.10
query12	0.13	0.10	0.11
query13	0.61	0.60	0.60
query14	2.85	2.74	2.80
query15	0.91	0.83	0.82
query16	0.39	0.38	0.39
query17	1.06	1.04	1.06
query18	0.19	0.19	0.20
query19	1.92	1.83	1.97
query20	0.02	0.01	0.01
query21	15.36	0.64	0.59
query22	2.68	2.19	2.37
query23	17.19	0.95	0.84
query24	2.41	0.77	0.55
query25	0.15	0.07	0.12
query26	0.51	0.15	0.13
query27	0.05	0.04	0.04
query28	11.63	1.10	1.07
query29	12.52	3.23	3.23
query30	0.24	0.06	0.05
query31	2.88	0.38	0.37
query32	3.30	0.48	0.47
query33	3.03	3.03	3.05
query34	17.07	4.45	4.49
query35	4.54	4.51	4.52
query36	0.66	0.49	0.50
query37	0.07	0.06	0.05
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.67 s
Total hot run time: 32.75 s

airborne12
airborne12 approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

PR approved by anyone and no changes requested.

@dataroaring
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.24% (9643/25894)
Line Coverage: 28.55% (79974/280114)
Region Coverage: 27.98% (41334/147738)
Branch Coverage: 24.59% (21046/85588)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5ea5bdde76c9af63e85472386bd889995b5c897d_5ea5bdde76c9af63e85472386bd889995b5c897d/report/index.html

gavinchou
gavinchou requested changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@gavinchou gavinchou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@dataroaring dataroaring merged commit 199148f into apache:master Oct 11, 2024
25 of 27 checks passed
@gavinchou gavinchou mentioned this pull request Oct 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinchou gavinchou gavinchou approved these changes

@airborne12 airborne12 airborne12 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.2-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dataroaring @doris-robot @airborne12 @gavinchou