[RoutineLoad] Support modify routine load job #4158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
added
kind/feature
wutiangan
reviewed
Jul 23, 2020
| RoutineLoadJob job = checkPrivAndGetJob(stmt.getDbName(), stmt.getLabel()); | ||
| if (stmt.hasDataSourceProperty() | ||
| && !stmt.getDataSourceProperties().getType().equalsIgnoreCase(job.dataSourceType.name())) { | ||
| throw new DdlException("The spciefied job type is not: " + stmt.getDataSourceProperties().getType()); |
There was a problem hiding this comment.
‘spciefied’ Wrong characters
wutiangan
reviewed
Jul 23, 2020
| | KW_ALTER KW_DATABASE ident:dbName KW_RENAME ident:newDbName | ||
| {: | ||
| RESULT = new AlterDatabaseRename(dbName, newDbName); | ||
| :} | ||
| | KW_ALTER KW_ROUTINE KW_LOAD job_label:jobLabel opt_properties:properties |
There was a problem hiding this comment.
Suggested change
| | KW_ALTER KW_ROUTINE KW_LOAD job_label:jobLabel opt_properties:properties | |
| | KW_ALTER KW_ROUTINE KW_LOAD job_label:jobLabel opt_properties:jobProperties |
EmmyMiao87
reviewed
Aug 3, 2020
| | KW_ALTER KW_DATABASE ident:dbName KW_RENAME ident:newDbName | ||
| {: | ||
| RESULT = new AlterDatabaseRename(dbName, newDbName); | ||
| :} | ||
| | KW_ALTER KW_ROUTINE KW_LOAD job_label:jobLabel opt_properties:jobProperties |
There was a problem hiding this comment.
Maybe KW_ALTER KW_ROUTINE KW_LOAD KW_FOR job_label:jobLabel is better. The other routine load stmt also has KW_FOR.
| @@ -1397,4 +1401,36 @@ public void readFields(DataInput in) throws IOException { | |||
| throw new IOException("error happens when parsing create routine load stmt: " + origStmt, e); | |||
| } | |||
| } | |||
|
|
|||
| abstract public void modifyProperties(AlterRoutineLoadStmt stmt) throws DdlException; | |||
There was a problem hiding this comment.
The job properties maybe could be modified in here instead of the subclass KafkaRoutineLoad.
There was a problem hiding this comment.
Maybe we could do this when we got second derived class from RoutineLoadJob
|
|
||
| abstract public void modifyProperties(AlterRoutineLoadStmt stmt) throws DdlException; | ||
|
|
||
| abstract public void replayModifyProperties(AlterRoutineLoadJobOperationLog log); |
EmmyMiao87
reviewed
Aug 3, 2020
docs/.vuepress/sidebar/zh-CN.js
Outdated
| @@ -409,6 +409,7 @@ module.exports = [ | |||
| title: "DML", | |||
| directoryPath: "Data Manipulation/", | |||
| children: [ | |||
| "alter-routine-load", | |||
There was a problem hiding this comment.
Put it between pause routine load and stop routine load.
morningman
force-pushed
the
modify_routine_load
branch
from
a94cb00 to
4b42b7d
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Support ALTER ROUTINE LOAD JOB stmt, for example:
Details can be found in
alter-routine-load.mdTypes of changes
Checklist