[charry-pick](branch3.0) support text hive #41656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
1. Support write hive text table 2. Add SessionVariable `hive_text_compression` to write compressed hive text table 3. Supported compression type: gzip, bzip2, snappy, lz4, zstd
followup apache#38549 If the large_block_len is 0, should not continue reading the block_len.
…#40291) ## Proposed changes related pr: apache#39700 support escape.delim and serialization.null.format for hive text
Impl ZstdDecompressor and support read hive text table which is compressed by zstd.
suxiaogang223
force-pushed
the
support_text_hive
branch
from
fcd45fe to
794c84c
Compare
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ZstdDecompressor() : Decompressor(CompressType::ZSTD) {} | ||
| Status init() override; | ||
|
|
||
| private: |
There was a problem hiding this comment.
warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]
Suggested change
| private: |
Additional context
be/src/exec/decompressor.h:149: previously declared here
private:
^| @@ -17,6 +17,7 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <gen_cpp/PlanNodes_types.h> | |||
There was a problem hiding this comment.
warning: 'gen_cpp/PlanNodes_types.h' file not found [clang-diagnostic-error]
#include <gen_cpp/PlanNodes_types.h>
^| @@ -174,6 +174,23 @@ void PlainCsvTextFieldSplitter::do_split(const Slice& line, std::vector<Slice>* | |||
| } | |||
| } | |||
|
|
|||
| void HiveCsvTextFieldSplitter::do_split(const Slice& line, std::vector<Slice>* splitted_values) { | |||
There was a problem hiding this comment.
warning: method 'do_split' can be made const [readability-make-member-function-const]
be/src/vec/exec/format/csv/csv_reader.cpp:177:
- values) {
+ values) const {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
pick from master:
#40315
#40291
#40183
#38549