Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite count(distinct if(bool, bitmap, null)) to bitmap_union_count #4201

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

liutang123
Copy link
Contributor

@liutang123 liutang123 commented Jul 29, 2020

Fix #4200

Add IF(BOOL, BITMAP, BITMAP) function.
Add UT.

@kangkaisen
Copy link
Contributor

nullif, ifnull, coalesce function should also update.

@liutang123
Copy link
Contributor Author

nullif, ifnull, coalesce function should also update.

Add ifnull(bitmap, bitmap) and coalesce(bitmap,...).

For nullif(bitmap, bitmap), I can not think of comparing two bitmaps.

@kangkaisen
Copy link
Contributor

nullif, ifnull, coalesce function should also update.

Add ifnull(bitmap, bitmap) and coalesce(bitmap,...).

For nullif(bitmap, bitmap), I can not think of comparing two bitmaps.

OK. But PR not update.

Copy link
Contributor

@kangkaisen kangkaisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@kangkaisen kangkaisen added approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug. area/sql Issues or PRs related to SQL labels Aug 12, 2020
@morningman morningman merged commit d5a0a73 into apache:master Aug 26, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/sql Issues or PRs related to SQL kind/fix Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite count(distinct if(bool, bitmap, null)) to bitmap_union_count
3 participants