Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement](LDAP Auth)Enhance LDAP authentication with a configurable group filter #42038

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

nsivarajan
Copy link
Contributor

Proposed changes

This PR enhances LDAP authentication by adding an optional configurable filter for retrieving user groups, primarily to support Open Directory LDAP implementations. If the configurable property is left empty, the existing workflow will remain unchanged.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@nsivarajan
Copy link
Contributor Author

run buildall

@nsivarajan
Copy link
Contributor Author

run buildall

Copy link
Contributor

@zddr zddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 20, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@nsivarajan
Copy link
Contributor Author

@morningman @zddr Please could you assist in merging this PR

@morningman morningman merged commit e567ee0 into apache:master Nov 5, 2024
26 of 27 checks passed
@morningman morningman self-assigned this Nov 5, 2024
github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
…le group filter (#42038)

## Proposed changes
<!--Describe your changes.-->

This PR enhances LDAP authentication by adding an optional configurable
filter for retrieving user groups, primarily to support Open Directory
LDAP implementations. If the configurable property is left empty, the
existing workflow will remain unchanged.

---------

Co-authored-by: Sivarajan Narayanan <narayanan_sivarajan@apple.com>
github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
…le group filter (#42038)

## Proposed changes
<!--Describe your changes.-->

This PR enhances LDAP authentication by adding an optional configurable
filter for retrieving user groups, primarily to support Open Directory
LDAP implementations. If the configurable property is left empty, the
existing workflow will remain unchanged.

---------

Co-authored-by: Sivarajan Narayanan <narayanan_sivarajan@apple.com>
dataroaring pushed a commit that referenced this pull request Nov 7, 2024
…a configurable group filter (#43292)

Cherry-picked from #42038

Co-authored-by: nsivarajan <117266407+nsivarajan@users.noreply.github.com>
Co-authored-by: Sivarajan Narayanan <narayanan_sivarajan@apple.com>
yiguolei pushed a commit that referenced this pull request Nov 10, 2024
…a configurable group filter (#43293)

Cherry-picked from #42038

Co-authored-by: nsivarajan <117266407+nsivarajan@users.noreply.github.com>
Co-authored-by: Sivarajan Narayanan <narayanan_sivarajan@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.3-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants