Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ColocateJoin] ColocateJoin support table join itself (#4230) #4231

Merged
merged 1 commit into from
Aug 2, 2020

Conversation

HappenLee
Copy link
Contributor

if left table and right table is same table, they are naturally colocate relationship.

Proposed changes

#4230

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on #ISSUE, and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

if left table and right table is same table, they are naturally colocate relationship.
@kangkaisen
Copy link
Contributor

Good work!

Copy link
Contributor

@kangkaisen kangkaisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kangkaisen kangkaisen added approved Indicates a PR has been approved by one committer. kind/feature Categorizes issue or PR as related to a new feature. area/colocated Issues or PRs related to colocated tables branch-0.13 PR which need to merge to branch 0.13 labels Jul 31, 2020
@morningman morningman merged commit 5caa347 into apache:master Aug 2, 2020
@EmmyMiao87 EmmyMiao87 mentioned this pull request Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/colocated Issues or PRs related to colocated tables branch-0.13 PR which need to merge to branch 0.13 kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants