[Bug][MemTracker] Cleanup the mem tracker's constructor to avoid wrong usage #4345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… usage If a mem tracker has parent, it should be created by 'CreateTracker'. So I removed other unused contructors.
morningman
added
kind/fix
be/src/runtime/mem_tracker.h
Outdated
| /// TODO(cmy): this method is not used for now. the memtracker returned from here is | ||
| /// got from a shared_ptr in `pool_to_mem_trackers_`. | ||
| /// I don't know why it need to return a raw pointer. | ||
| /// If this method be further used, please notice that. |
There was a problem hiding this comment.
GetRequestPoolMemTracker is from
https://github.com/cloudera/Impala/blob/495397101e5807c701df71ea288f4815d69c2c8a/be/src/runtime/mem-tracker.h#L497
So we didn't make it shared last time, just Ieave it as it is. Maybe we could return shared ptr, I think there should be no problem.
There was a problem hiding this comment.
Okay, since this function has not been used yet, I will change the return value to shared_ptr
acelyc111
pushed a commit
to acelyc111/incubator-doris
that referenced
this pull request
Aug 21, 2020
…g usage (apache#4345) After PR: apache#4135, If a mem tracker has parent, it should be created by 'CreateTracker'. So I removed other unused constructors. And also fix the bug described in apache#4344
wangbo
pushed a commit
to wangbo/incubator-doris
that referenced
this pull request
Sep 2, 2020
…g usage (apache#4345) After PR: apache#4135, If a mem tracker has parent, it should be created by 'CreateTracker'. So I removed other unused constructors. And also fix the bug described in apache#4344
wangbo
pushed a commit
to wangbo/incubator-doris
that referenced
this pull request
Sep 2, 2020
…g usage (apache#4345) After PR: apache#4135, If a mem tracker has parent, it should be created by 'CreateTracker'. So I removed other unused constructors. And also fix the bug described in apache#4344
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
After PR: #4135, If a mem tracker has parent, it should be created by 'CreateTracker'.
So I removed other unused constructors.
And also fix the bug described in #4344
Types of changes
Checklist