[MySQL Compatibility 1/4][Bug] Fix bug that set sql_mode with concat() function failed #4359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
added
kind/fix
morningman
changed the title
EmmyMiao87
reviewed
Aug 20, 2020
| try { | ||
| VariableMgr.fillValue(ConnectContext.get().getSessionVariable(), (SysVariableDesc) constExpr); | ||
| return ((SysVariableDesc) constExpr).getLiteralExpr(); | ||
| } catch (AnalysisException e) { |
There was a problem hiding this comment.
Why not just throw the exception to the user?
There was a problem hiding this comment.
This method is used for constant folding rules. If it fails, it will directly return to the original expression, and other processes will handle this error.
Closed
6 tasks
morningman
pushed a commit
that referenced
this pull request
Nov 18, 2021
…and MySQL (#7108) Introduce by pr #4359 VariableMgr.fillValue() method should not call in ExpressionFunctions.eval(), because in method analyzeImpl() of SysVariableDesc, it has been already called once. If VariableMgr.fillValue() was called twice, the type of SysVariableDesc will become BigInt, which is incorrect.
|
BUT still failed for this (when I use SAP DataService to connect Doris ):
the client side auto execute this when connect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Support
set sql_mode = concat(@@sql_mode, "STRICT_TRANS_TABLES");Types of changes
Checklist