Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mysql Compatibility 3/4] Support convert() and signed/unsigned interger cast #4364

Merged
merged 1 commit into from
Aug 27, 2020
Merged

[Mysql Compatibility 3/4] Support convert() and signed/unsigned interger cast #4364

merged 1 commit into from
Aug 27, 2020

Conversation

morningman
Copy link
Contributor

Proposed changes

  1. Support convert(expr, target_type) function, which is same as CastExpr
  2. Support cast (expr as signed/unsigned int)
    This is just for compatibility, the signed/unsigned specification is meaningless.
  3. Add more columns for table information_schema.columns

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

@morningman-cmy
[Mysql Compatibility] Support convert() and signed/unsigned interger …
f7fb33a 
…cast

1. Support convert(expr, target_type) function, which is same as CastExpr
2. Support cast (expr as signed/unsigned int)
   This is just for compatibility, the signed/unsigned specification is meaningless.
@morningman morningman added the area/mysql-compatibility Issues or PRs related to the mysql compatibility label Aug 16, 2020
@morningman morningman self-assigned this Aug 16, 2020
kangkaisen
kangkaisen approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@kangkaisen kangkaisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kangkaisen kangkaisen added the approved Indicates a PR has been approved by one committer. label Aug 26, 2020
@morningman morningman merged commit f218327 into apache:master Aug 27, 2020
morningman pushed a commit to morningman/doris that referenced this pull request Sep 2, 2020
@morningman-cmy
[Bug] Fix bug that BE will crash when querying information_schema.col…
629356d 
…umns

This bug is introduced from apache#4364
@morningman morningman mentioned this pull request Sep 2, 2020
Merged
1 task
morningman pushed a commit to morningman/doris that referenced this pull request Sep 2, 2020
@morningman-cmy
[Bug] Fix bug that BE will crash when querying information_schema.col…
94025ee 
…umns

This bug is introduced from apache#4364
morningman added a commit that referenced this pull request Sep 3, 2020
@morningman
[Bug] Fix bug that BE will crash when querying information_schema.col…
d7ac44a 
…umns (#4511)

This bug is introduced from #4364
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangkaisen kangkaisen kangkaisen approved these changes

Assignees

@morningman morningman

Labels
approved Indicates a PR has been approved by one committer. area/mysql-compatibility Issues or PRs related to the mysql compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MysqlCompatibility] Support convert() function and signed/unsigned integer
3 participants
@morningman @kangkaisen @morningman-cmy