Fix errors when alter materialized view which based on dup table #4375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Input the correct keys type when mv is updated. The keys type of mv should be used in schema change job rather then keys type of base table. Otherwise, the be will core and thrown exception "Create replicas failed". 2. Forbidden add non-key column on agg mv directly when base table is duplicate model If a dup table has a agg mv, user will not add a non-key column on mv. The non-key column can only be added to dup index. Fixed apache#4374 Change-Id: I375f695b3109e513622110cf0ca04a4034780909
EmmyMiao87
added
kind/fix
wutiangan
reviewed
Aug 17, 2020
| @@ -556,6 +556,10 @@ private void addColumnInternal(OlapTable olapTable, Column newColumn, ColumnPosi | |||
| throw new DdlException("Can not assign aggregation method on column in Duplicate data model table: " + newColName); | |||
| } | |||
| if (!newColumn.isKey()) { | |||
There was a problem hiding this comment.
why not put "from lint 559 to line 562" outside of if stmt?
There was a problem hiding this comment.
I didn't understand what you mean...
morningman
reviewed
Aug 17, 2020
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java
Outdated
Show resolved
Hide resolved
Change-Id: Ifb3b3ad2ba44770a2a0fcf0317f63e3e508161da
acelyc111
pushed a commit
to acelyc111/incubator-doris
that referenced
this pull request
Aug 21, 2020
…apache#4375) 1. Input the correct keys type when mv is updated. The keys type of mv should be used in schema change job rather then keys type of base table. Otherwise, the be will core and thrown exception "Create replicas failed". 2. Forbidden add non-key column on agg mv directly when base table is duplicate model If a dup table has a agg mv, user will not add a non-key column on mv. The non-key column can only be added to dup index.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Input the correct keys type when mv is updated.
The keys type of mv should be used in schema change job rather then keys type of base table.
Otherwise, the be will core and thrown exception "Create replicas failed".
Forbidden add non-key column on agg mv directly when base table is duplicate model
If a dup table has a agg mv, user will not add a non-key column on mv.
The non-key column can only be added to dup index.
Fixed #4374
Change-Id: I375f695b3109e513622110cf0ca04a4034780909
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.