[ODBC SCAN NODE] 1/4 Add unix odbc library. #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
approved these changes
Aug 17, 2020
morningman
requested changes
Aug 17, 2020
thirdparty/build-thirdparty.sh
Outdated
| @@ -692,6 +705,7 @@ build_cctz() { | |||
| # we just comment it, instead of remove it. | |||
| # build_llvm | |||
|
|
|||
| build_libodbc | |||
There was a problem hiding this comment.
Suggested change
| build_libodbc | |
| build_libunixodbc |
morningman
reviewed
Aug 17, 2020
be/test/exec/unix_odbc_test.cpp
Outdated
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| #include "odbc/sql.h" |
There was a problem hiding this comment.
Suggested change
| #include "odbc/sql.h" | |
| #include "sql.h" |
There was a problem hiding this comment.
may be <odbc/sql.h> or <sql.h>
There was a problem hiding this comment.
sql.h is in thirdparty/installed/included, so it should be "sql.h"
There was a problem hiding this comment.
I think only Doris own code use "", for third-party code use <>.
Glog, protobuf are all in the thirdparty, however we inlcude them with ""
There was a problem hiding this comment.
Oh, I misunderstood.
yes, it should be <>.
morningman
added
approved
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue:#4376
Proposed changes
Add unix odbc library for ODBC Scan Node
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.