Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JsonLoad] Fix bug that row num stat is not correct when loading json #4379

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

morningman
Copy link
Contributor

Proposed changes

When all fields are null, the row is invalid, it should be filtered

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes

When all fields are null, the row is invalid, it should be filtered
@morningman morningman added kind/fix Categorizes issue or PR as related to a bug. area/load Issues or PRs related to all kinds of load labels Aug 18, 2020
@morningman morningman self-assigned this Aug 18, 2020
Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added approved Indicates a PR has been approved by one committer. branch-0.13 PR which need to merge to branch 0.13 labels Aug 18, 2020
@morningman morningman merged commit b6859f1 into apache:master Aug 20, 2020
acelyc111 pushed a commit to acelyc111/incubator-doris that referenced this pull request Aug 21, 2020
…apache#4379)

When all fields are null, the row is invalid, it should be filtered
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/load Issues or PRs related to all kinds of load branch-0.13 PR which need to merge to branch 0.13 kind/fix Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants