Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](Export) fix a memory leak in the FE because of the ExportJob #44019

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

BePPPower
Copy link
Contributor

@BePPPower BePPPower commented Nov 15, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
When an Export job has finished or been cancelled, ExportMgr will maintain a reference of the ExportJob object. Therefore, we need to clear these no longer used objects; otherwise it will cause a memory leak in the FE.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason: It can not be figured out in neither Unit Test nor Regression test.
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BePPPower
Copy link
Contributor Author

run buildall

@BePPPower BePPPower changed the title [fix](Export) fix memory leak of FE because of the ExportJob [fix](Export) fix memory leak in the FE because of the ExportJob Nov 15, 2024
@BePPPower BePPPower changed the title [fix](Export) fix memory leak in the FE because of the ExportJob [fix](Export) fix a memory leak in the FE because of the ExportJob Nov 15, 2024
@wm1581066 wm1581066 added the p0_b label Nov 15, 2024
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 16, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@kaka11chen kaka11chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 27132c8 into apache:master Nov 17, 2024
32 of 33 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 17, 2024
…44019)

### What problem does this PR solve?

Problem Summary:
When an `Export` job has finished or been cancelled, `ExportMgr` will
maintain a reference of the `ExportJob` object. Therefore, we need to
clear these no longer used objects; otherwise it will cause a memory
leak in the FE.
github-actions bot pushed a commit that referenced this pull request Nov 17, 2024
…44019)

### What problem does this PR solve?

Problem Summary:
When an `Export` job has finished or been cancelled, `ExportMgr` will
maintain a reference of the `ExportJob` object. Therefore, we need to
clear these no longer used objects; otherwise it will cause a memory
leak in the FE.
morningman pushed a commit that referenced this pull request Nov 17, 2024
…ExportJob #44019 (#44088)

Cherry-picked from #44019

Co-authored-by: Tiewei Fang <ftw2139@163.com>
yiguolei pushed a commit that referenced this pull request Nov 18, 2024
…ExportJob #44019 (#44089)

Cherry-picked from #44019

Co-authored-by: Tiewei Fang <ftw2139@163.com>
@yiguolei yiguolei mentioned this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.3-merged p0_b reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants