Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](iceberg)Fix count(*) error with dangling delete problem #44039

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

wuwenchi
Copy link
Contributor

@wuwenchi wuwenchi commented Nov 15, 2024

What problem does this PR solve?

Prevent 'dangling delete' problem after rewrite_data_files action.
ref: https://iceberg.apache.org/docs/nightly/spark-procedures/#rewrite_position_delete_files.

Because we don’t know whether the user has performed a rewrite operation, total-records will only be used directly when equalitydelete and positiondelete are both 0.

Issue Number: close #42240

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wuwenchi wuwenchi changed the title [fix] dangling delete [fix](iceberg)Fix count(*) error with dangling delete problem Nov 15, 2024
@wuwenchi
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 15, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@kaka11chen kaka11chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit d593ffa into apache:master Nov 18, 2024
31 of 33 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 18, 2024
### What problem does this PR solve?

Prevent 'dangling delete' problem after `rewrite_data_files` action.
ref:
https://iceberg.apache.org/docs/nightly/spark-procedures/#rewrite_position_delete_files.

Because we don’t know whether the user has performed a rewrite
operation, `total-records` will only be used directly when
equalitydelete and positiondelete are both 0.

Issue Number: close #42240
github-actions bot pushed a commit that referenced this pull request Nov 18, 2024
### What problem does this PR solve?

Prevent 'dangling delete' problem after `rewrite_data_files` action.
ref:
https://iceberg.apache.org/docs/nightly/spark-procedures/#rewrite_position_delete_files.

Because we don’t know whether the user has performed a rewrite
operation, `total-records` will only be used directly when
equalitydelete and positiondelete are both 0.

Issue Number: close #42240
yiguolei pushed a commit that referenced this pull request Nov 19, 2024
…blem #44039 (#44101)

Cherry-picked from #44039

Co-authored-by: wuwenchi <wuwenchi@selectdb.com>
dataroaring pushed a commit that referenced this pull request Nov 26, 2024
…blem #44039 (#44100)

Cherry-picked from #44039

Co-authored-by: wuwenchi <wuwenchi@selectdb.com>
@yiguolei yiguolei mentioned this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] V2.1.6 Iceberg Dangling Deletes影响数量统计
6 participants