Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](Nereids) simplify comparison predicate do wrong cast #44054

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

morrySnow
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #41151

Problem Summary:

lead to analysis error: Invalid precision and scale

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

related PR apache#41151

lead to analysis error

```
Invalid precision and scale
```
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow
Copy link
Contributor Author

run feut

@morrySnow
Copy link
Contributor Author

run p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 17, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@starocean999 starocean999 merged commit b3d924d into apache:master Nov 18, 2024
27 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 18, 2024
Related PR: #41151
Problem Summary:
lead to analysis error: Invalid precision and scale
@morrySnow morrySnow deleted the fix_simplify_comparison branch November 18, 2024 02:42
github-actions bot pushed a commit that referenced this pull request Nov 18, 2024
Related PR: #41151
Problem Summary:
lead to analysis error: Invalid precision and scale
@morrySnow morrySnow added the p0_b label Nov 18, 2024
morrySnow added a commit that referenced this pull request Nov 18, 2024
…#44054 (#44107)

Cherry-picked from #44054

Co-authored-by: morrySnow <zhangwenxin@selectdb.com>
yiguolei pushed a commit that referenced this pull request Nov 18, 2024
…#44054 (#44119)

Cherry-picked from #44054

Co-authored-by: morrySnow <zhangwenxin@selectdb.com>
@yiguolei yiguolei mentioned this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants