-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate the param of rand function in compile step #4439
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangkaisen
reviewed
Aug 25, 2020
kangkaisen
reviewed
Aug 25, 2020
fe/fe-core/src/test/java/org/apache/doris/analysis/ExprTest.java
Outdated
Show resolved
Hide resolved
kangkaisen
reviewed
Aug 25, 2020
fe/fe-core/src/test/java/org/apache/doris/analysis/ExprTest.java
Outdated
Show resolved
Hide resolved
kangkaisen
reviewed
Aug 25, 2020
fe/fe-core/src/test/java/org/apache/doris/analysis/SelectStmtTest.java
Outdated
Show resolved
Hide resolved
kangkaisen
previously approved these changes
Aug 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
kangkaisen
added
kind/fix
Categorizes issue or PR as related to a bug.
area/sql/function
Issues or PRs related to the SQL functions
approved
Indicates a PR has been approved by one committer.
labels
Aug 26, 2020
Hi @xinghuayu007 , you have to rebase to master to solve the conflict. |
done |
kangkaisen
approved these changes
Aug 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
area/sql/function
Issues or PRs related to the SQL functions
kind/fix
Categorizes issue or PR as related to a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The param of rand() function should be literal, but current compiler ingore to validate the literal param of rand function, it is validated in execution step. This PR make it validated in compile step, anbd make it more earlier to find the usage error of rand() function.
Types of changes
What types of changes does your code introduce to Doris?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...