Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the param of rand function in compile step #4439

Merged
merged 23 commits into from
Sep 2, 2020

Conversation

xinghuayu007
Copy link
Contributor

Proposed changes

The param of rand() function should be literal, but current compiler ingore to validate the literal param of rand function, it is validated in execution step. This PR make it validated in compile step, anbd make it more earlier to find the usage error of rand() function.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

kangkaisen
kangkaisen previously approved these changes Aug 26, 2020
Copy link
Contributor

@kangkaisen kangkaisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kangkaisen kangkaisen added kind/fix Categorizes issue or PR as related to a bug. area/sql/function Issues or PRs related to the SQL functions approved Indicates a PR has been approved by one committer. labels Aug 26, 2020
@morningman
Copy link
Contributor

Hi @xinghuayu007 , you have to rebase to master to solve the conflict.

@xinghuayu007
Copy link
Contributor Author

Hi @xinghuayu007 , you have to rebase to master to solve the conflict.

done

Copy link
Contributor

@kangkaisen kangkaisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@morningman morningman merged commit 1a22f3b into apache:master Sep 2, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/sql/function Issues or PRs related to the SQL functions kind/fix Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants